From: Quentin Monnet <qmo@kernel.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Mykyta Yatsenko <mykyta.yatsenko5@gmail.com>,
bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Kernel Team <kernel-team@meta.com>,
Mykyta Yatsenko <yatsenko@meta.com>
Subject: Re: [PATCH v2 bpf-next] bpftool: introduce btf c dump sorting
Date: Fri, 10 May 2024 00:39:31 +0100 [thread overview]
Message-ID: <abc638ce-7985-4c43-82a5-7d1589d42305@kernel.org> (raw)
In-Reply-To: <CAADnVQKUZtOjMKWq9OxmLVH=zShnOF7DNCmncK+qFkTpdRz9dg@mail.gmail.com>
On 10/05/2024 00:24, Alexei Starovoitov wrote:
> On Thu, May 9, 2024 at 4:09 PM Quentin Monnet <qmo@kernel.org> wrote:
>>
>> Nit: Most variables in the file are declared in "reverse-Christmas-tree"
>> order (longest lines first, unless there's a reason not to). Could you
>> please try to preserve this order, here and elsewhere, for consistency?
>
> I so hate this nitpick.
Yes, I've seen you push back before; I was wondering if you'd react on
this one. I don't mind too much about the ordering, to be honest. To me,
this is mostly a matter of consistency in the file.
> I'll start introducing non-rev-xmas tree everywhere just
> to stop this madness.
That's maybe not necessary :), at least as far as I'm concerned. I'm
fine with dropping this for future reviews (starting with the current one).
Quentin
prev parent reply other threads:[~2024-05-09 23:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 15:17 [PATCH v2 bpf-next] bpftool: introduce btf c dump sorting Mykyta
2024-05-09 16:08 ` Alan Maguire
2024-05-09 18:42 ` Mykyta Yatsenko
2024-05-09 21:27 ` Andrii Nakryiko
2024-05-09 21:39 ` Andrii Nakryiko
2024-05-09 23:09 ` Quentin Monnet
2024-05-09 23:14 ` Andrii Nakryiko
2024-05-09 23:24 ` Alexei Starovoitov
2024-05-09 23:39 ` Quentin Monnet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abc638ce-7985-4c43-82a5-7d1589d42305@kernel.org \
--to=qmo@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@meta.com \
--cc=mykyta.yatsenko5@gmail.com \
--cc=yatsenko@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox