From: Pu Lehui <pulehui@huawei.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Pu Lehui <pulehui@huaweicloud.com>,
Alan Maguire <alan.maguire@oracle.com>
Cc: <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH bpf-next] kbuild, bpf: Correct pahole version that supports distilled base btf feature
Date: Mon, 24 Feb 2025 20:16:50 +0800 [thread overview]
Message-ID: <abf6baeb-ac7a-44da-8c00-a0bb409760df@huawei.com> (raw)
In-Reply-To: <CAEf4BzYJLKZpuEsbU-A1s7wtpG0YQKUHG3QDaQoDH8B+VY0oSQ@mail.gmail.com>
On 2025/2/21 8:30, Andrii Nakryiko wrote:
> On Tue, Feb 18, 2025 at 10:29 PM Pu Lehui <pulehui@huaweicloud.com> wrote:
>>
>> From: Pu Lehui <pulehui@huawei.com>
>>
>> pahole commit [0] of supporting distilled base btf feature released on
>> pahole v1.28 rather than v1.26. So let's correct this.
>>
>> Link: https://git.kernel.org/pub/scm/devel/pahole/pahole.git/commit/?id=c7b1f6a29ba1 [0]
>> Signed-off-by: Pu Lehui <pulehui@huawei.com>
>> ---
>> scripts/Makefile.btf | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/Makefile.btf b/scripts/Makefile.btf
>> index c3cbeb13de50..fbaaec2187e5 100644
>> --- a/scripts/Makefile.btf
>> +++ b/scripts/Makefile.btf
>> @@ -24,7 +24,7 @@ else
>> pahole-flags-$(call test-ge, $(pahole-ver), 126) = -j$(JOBS) --btf_features=encode_force,var,float,enum64,decl_tag,type_tag,optimized_func,consistent_func,decl_tag_kfuncs
>>
>> ifneq ($(KBUILD_EXTMOD),)
>> -module-pahole-flags-$(call test-ge, $(pahole-ver), 126) += --btf_features=distilled_base
>> +module-pahole-flags-$(call test-ge, $(pahole-ver), 128) += --btf_features=distilled_base
>> endif
>
> Alan,
>
> Is this correct? Can you please check and ack? Thanks!
Maybe Alan doesn't have time to reply at the moment. We can use the
following command to check that in pahole.git:
$ git name-rev c7b1f6a29ba1
c7b1f6a29ba1 tags/v1.28~73
>
>>
>> endif
>> --
>> 2.34.1
>>
next prev parent reply other threads:[~2025-02-24 12:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 6:31 [PATCH bpf-next] kbuild, bpf: Correct pahole version that supports distilled base btf feature Pu Lehui
2025-02-21 0:30 ` Andrii Nakryiko
2025-02-24 12:16 ` Pu Lehui [this message]
2025-02-24 22:24 ` Andrii Nakryiko
2025-02-25 9:32 ` Alan Maguire
2025-02-24 22:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=abf6baeb-ac7a-44da-8c00-a0bb409760df@huawei.com \
--to=pulehui@huawei.com \
--cc=alan.maguire@oracle.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=pulehui@huaweicloud.com \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox