From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D11483E3D9A for ; Wed, 1 Apr 2026 10:18:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775038720; cv=none; b=imaH7vJ3dVQNZcFNC0/ynwMsJvM0cBE2PpiWJ+TzYmkExQ+e/i0IfRLqPxXMdAN+ZFkoxtZBwXSyw9z5IBaDam5u1ge6qm1TnLI4X/mXTYKiDjaE4hp8jxgUU54GKTmF1XsJVS5Fz2iYs4C7D/4a6O2YnL2c0JMZ9/X3vtkmt2g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775038720; c=relaxed/simple; bh=Wz+rTxMXFXCcsbcqYERrHHqU3UlCN8/24cOvHBXTsX0=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=C6ioR0n8lf0IPIzstTVILD5kpAwkTDmAYsuVJJucDu82iLnTG7RjNwUWmkY/hwVZN6cXmrCXaH2Jo8degSsVK9AQOnORgK1uzw2BZDVY6dO+0D+MgfA15MFmgVkeoN+yyNKtdR+UKqdUrB2k8daC9FKyUytqZgeX2GcbT5lUM5k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=r7RgJ0lK; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r7RgJ0lK" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-486fe655187so87662695e9.2 for ; Wed, 01 Apr 2026 03:18:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775038706; x=1775643506; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=anYzjF7hGyuvz8IMGvRz0rbiAkEEPyOMLi1vC2Btujg=; b=r7RgJ0lK9peugos1A1ObMup3WsgNM1guHw208SoGiYJcGcfjsM0lNSlgYF4BRD+t/7 fNF91wMvZhyZVDgxXTzeIMhZTbr9PIw5C75w8E9Zh6DjC8zP4zc6NKUNJyFixAhjjcD/ fcOFmqMj9fjkHoDWN4XzJ7s8EofmHLgNEPUpiVoO+2P+iuTOWix9hbbJCf1Xxw86Avyl OavWJ3dA9VL8HcgfLD4320n1tKm7rouQtzgd2K4rdQjN9niAGpOnIIMqfXmHdG1xC/FN /pLopLzXc9eeYyr1YrtkSODujes8HFACGwCuK8P2QkD3mv+enQbsYhJvnQZHCB4Mx2cl +tvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775038706; x=1775643506; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=anYzjF7hGyuvz8IMGvRz0rbiAkEEPyOMLi1vC2Btujg=; b=AG3fMfsg/dGyPQ1fZFKYSQ+MDmlM8yrrVAzSliQFWzMatY1b/5uSpYOwrH5P7wq1lP E3zyhqnnuPxvNeH0C35EeauTxtz2cK0tyrg+Y5XadwKVltGgz39oUBAy+SQ5FskyYkFj 6/jmtpQV3daVmQYanGaJclUVO8Aep2oyM+dWzXpLoE1XQRkoZ92UmUxPgQ7kjXZNjchc W1ojGwuetTdUmEsFWWSLkZw4y9D6ykqFhP36E8yWHi8FIqnQszgUpt8Ke9/HI61HtWI5 ZVr6wPTGgpvjCgPwx+g+OJCW9w85PbMwsTcRKarV5By9DQX8mrTSMSuLrbATFF/6dK2C om7A== X-Gm-Message-State: AOJu0YyEKuW1GiSv5pfwdq2phAPf7gsvKzmsVdjCM0V3rPk1QbhAhyr7 MUrgH1j5B4YS2EhF2V4c9OkQAocV2VNLxdY1Ygv7k0tNs54gI/pjm1bv X-Gm-Gg: ATEYQzx37IUk3JuywDUWtCVWRqKv9JWmRlG2wzROKoeKmTM2yqKK4i7B9CQw8gDp/gl Tpg6/uNUy54wfE3RJWXJYMTBZTUi1xnOw1o5Pnk1/w0Xij+L+T0tQQYIeB/fhDgHOnRRpIm0DTt XKVdr1+bLnlv1Qemcwx+HhNS5ki/FZ3NCNWb3P7/32Fta5Z93gWk8CsHj2J8533l4PdOqSQfaCA AazqAWkmihD2Dz3qiGBdL6uqRazgZmf5mrmLC5OorA5REVe3ESL5MZXWf9EW9Onf+3IoPUT7Svj hF9qEY4/Yc1xdlPRMl4Oj7w8Y4UPPEdVeolEI0RoLBOftW7gqJGKx3EVNzfT/BJB8WzHsTsEOCv 2+SaDWyGyhydXTC4B7e+G1+1mFUFsVpBNHO2rBCXVscZNmw8EsazqPHtPyn6AW1KOKIHkFnVM X-Received: by 2002:a05:600c:3f19:b0:485:35a4:939f with SMTP id 5b1f17b1804b1-48883599371mr44116175e9.28.1775038705666; Wed, 01 Apr 2026 03:18:25 -0700 (PDT) Received: from krava ([2a02:8308:a00c:e200::d99c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43cf21e9e18sm32503913f8f.9.2026.04.01.03.18.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Apr 2026 03:18:25 -0700 (PDT) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Wed, 1 Apr 2026 12:18:23 +0200 To: Hoyeon Lee Cc: bpf@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Kumar Kartikeya Dwivedi , Song Liu , Yonghong Song , Shuah Khan , Feng Yang , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf-next v6 1/3] libbpf: use direct error codes for kprobe/uprobe attach Message-ID: References: <20260401070738.122709-1-hoyeon.lee@suse.com> <20260401070738.122709-2-hoyeon.lee@suse.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260401070738.122709-2-hoyeon.lee@suse.com> On Wed, Apr 01, 2026 at 04:05:02PM +0900, Hoyeon Lee wrote: > perf_event_open_probe() and perf_event_{k,u}probe_open_legacy() helpers > are returning negative error codes directly on failure. This commit > changes bpf_program__attach_{k,u}probe_opts() to use those return > values directly instead of reading -errno again. because the errno might be changed by the error path cleanup code, right? Acked-by: Jiri Olsa jirka > > Signed-off-by: Hoyeon Lee > --- > tools/lib/bpf/libbpf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > index 9ea41f40dc82..536c19c14d21 100644 > --- a/tools/lib/bpf/libbpf.c > +++ b/tools/lib/bpf/libbpf.c > @@ -11835,7 +11835,7 @@ bpf_program__attach_kprobe_opts(const struct bpf_program *prog, > offset, -1 /* pid */); > } > if (pfd < 0) { > - err = -errno; > + err = pfd; > pr_warn("prog '%s': failed to create %s '%s+0x%zx' perf event: %s\n", > prog->name, retprobe ? "kretprobe" : "kprobe", > func_name, offset, > @@ -12825,7 +12825,7 @@ bpf_program__attach_uprobe_opts(const struct bpf_program *prog, pid_t pid, > binary_path, func_offset, pid); > } > if (pfd < 0) { > - err = -errno; > + err = pfd; > pr_warn("prog '%s': failed to create %s '%s:0x%zx' perf event: %s\n", > prog->name, retprobe ? "uretprobe" : "uprobe", > binary_path, func_offset, > -- > 2.52.0 >