From: Eduard Zingerman <eddyz87@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Martin KaFai Lau <martin.lau@linux.dev>,
Kernel Team <kernel-team@fb.com>,
Yonghong Song <yonghong.song@linux.dev>,
Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH bpf-next v2 3/5] bpf: simple DFA-based live registers analysis
Date: Tue, 04 Mar 2025 09:55:52 -0800 [thread overview]
Message-ID: <ad24890b32b7e6fbcb1ace4eefd8fa365e0de0e7.camel@gmail.com> (raw)
In-Reply-To: <CAADnVQ+gBOK_KODR0AD7tEVqjeCn9QTPjOjS=6A1bbbNr55nnA@mail.gmail.com>
On Tue, 2025-03-04 at 09:00 -0800, Alexei Starovoitov wrote:
> On Mon, Mar 3, 2025 at 11:43 PM Eduard Zingerman <eddyz87@gmail.com> wrote:
> >
> > + case BPF_STX:
> > + switch (mode) {
> > + case BPF_MEM:
> > + def = 0;
> > + use = dst | src;
> > + break;
> > + case BPF_ATOMIC:
> > + use = dst | src;
> > + if (insn->imm & BPF_FETCH) {
> > + if (insn->imm == BPF_CMPXCHG)
> > + def = r0;
> > + else
> > + def = src;
> > + } else {
> > + def = 0;
> > + }
> > + break;
> > + }
>
> This would need a follow up to recognize newly introduced
> load_acq/store_rel insns.
Missed that load_acq landed.
Will send v3 shortly.
next prev parent reply other threads:[~2025-03-04 17:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 7:42 [PATCH bpf-next v2 0/5] bpf: simple DFA-based live registers analysis Eduard Zingerman
2025-03-04 7:42 ` [PATCH bpf-next v2 1/5] bpf: jmp_offset() and verbose_insn() utility functions Eduard Zingerman
2025-03-04 7:42 ` [PATCH bpf-next v2 2/5] bpf: get_call_summary() utility function Eduard Zingerman
2025-03-04 7:42 ` [PATCH bpf-next v2 3/5] bpf: simple DFA-based live registers analysis Eduard Zingerman
2025-03-04 17:00 ` Alexei Starovoitov
2025-03-04 17:55 ` Eduard Zingerman [this message]
2025-03-04 7:42 ` [PATCH bpf-next v2 4/5] bpf: use register liveness information for func_states_equal Eduard Zingerman
2025-03-04 7:42 ` [PATCH bpf-next v2 5/5] selftests/bpf: test cases for compute_live_registers() Eduard Zingerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad24890b32b7e6fbcb1ace4eefd8fa365e0de0e7.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@linux.dev \
--cc=tj@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox