public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bpf: update outdated comment for refactored btf_check_kfunc_arg_match()
@ 2026-03-21 10:56 Kexin Sun
  2026-03-21 15:20 ` Yonghong Song
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Kexin Sun @ 2026-03-21 10:56 UTC (permalink / raw)
  To: ast, daniel, john.fastabend, andrii, martin.lau, eddyz87, song,
	yonghong.song, kpsingh, sdf, haoluo, jolsa, bpf, linux-kernel
  Cc: julia.lawall, xutong.ma, kexinsun, yunbolyu, ratnadiraw

The function btf_check_kfunc_arg_match() was refactored into
check_kfunc_args() by commit 00b85860feb8 ("bpf: Rewrite kfunc
argument handling").  Update the comment accordingly.

Assisted-by: unnamed:deepseek-v3.2 coccinelle
Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
---
 kernel/bpf/verifier.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
index bb12ba020649..c0ecf02a1b78 100644
--- a/kernel/bpf/verifier.c
+++ b/kernel/bpf/verifier.c
@@ -14410,7 +14410,7 @@ static int check_kfunc_call(struct bpf_verifier_env *env, struct bpf_insn *insn,
 		if (btf_type_is_ptr(t))
 			mark_btf_func_reg_size(env, regno, sizeof(void *));
 		else
-			/* scalar. ensured by btf_check_kfunc_arg_match() */
+			/* scalar. ensured by check_kfunc_args() */
 			mark_btf_func_reg_size(env, regno, t->size);
 	}
 
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] bpf: update outdated comment for refactored btf_check_kfunc_arg_match()
  2026-03-21 10:56 [PATCH] bpf: update outdated comment for refactored btf_check_kfunc_arg_match() Kexin Sun
@ 2026-03-21 15:20 ` Yonghong Song
  2026-03-23  7:39 ` Jiayuan Chen
  2026-03-24 20:40 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: Yonghong Song @ 2026-03-21 15:20 UTC (permalink / raw)
  To: Kexin Sun, ast, daniel, john.fastabend, andrii, martin.lau,
	eddyz87, song, kpsingh, sdf, haoluo, jolsa, bpf, linux-kernel
  Cc: julia.lawall, xutong.ma, yunbolyu, ratnadiraw



On 3/21/26 3:56 AM, Kexin Sun wrote:
> The function btf_check_kfunc_arg_match() was refactored into
> check_kfunc_args() by commit 00b85860feb8 ("bpf: Rewrite kfunc
> argument handling").  Update the comment accordingly.
>
> Assisted-by: unnamed:deepseek-v3.2 coccinelle
> Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>

Acked-by: Yonghong Song <yonghong.song@linux.dev>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] bpf: update outdated comment for refactored btf_check_kfunc_arg_match()
  2026-03-21 10:56 [PATCH] bpf: update outdated comment for refactored btf_check_kfunc_arg_match() Kexin Sun
  2026-03-21 15:20 ` Yonghong Song
@ 2026-03-23  7:39 ` Jiayuan Chen
  2026-03-24 20:40 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: Jiayuan Chen @ 2026-03-23  7:39 UTC (permalink / raw)
  To: Kexin Sun, ast, daniel, john.fastabend, andrii, martin.lau,
	eddyz87, song, yonghong.song, kpsingh, sdf, haoluo, jolsa, bpf,
	linux-kernel
  Cc: julia.lawall, xutong.ma, yunbolyu, ratnadiraw


On 3/21/26 6:56 PM, Kexin Sun wrote:
> The function btf_check_kfunc_arg_match() was refactored into
> check_kfunc_args() by commit 00b85860feb8 ("bpf: Rewrite kfunc
> argument handling").  Update the comment accordingly.
>
> Assisted-by: unnamed:deepseek-v3.2 coccinelle
> Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>


Reviewed-by: Jiayuan Chen <jiayuan.chen@linux.dev>

> ---
>   kernel/bpf/verifier.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> index bb12ba020649..c0ecf02a1b78 100644
> --- a/kernel/bpf/verifier.c
> +++ b/kernel/bpf/verifier.c
> @@ -14410,7 +14410,7 @@ static int check_kfunc_call(struct bpf_verifier_env *env, struct bpf_insn *insn,
>   		if (btf_type_is_ptr(t))
>   			mark_btf_func_reg_size(env, regno, sizeof(void *));
>   		else
> -			/* scalar. ensured by btf_check_kfunc_arg_match() */
> +			/* scalar. ensured by check_kfunc_args() */
>   			mark_btf_func_reg_size(env, regno, t->size);
>   	}
>   

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] bpf: update outdated comment for refactored btf_check_kfunc_arg_match()
  2026-03-21 10:56 [PATCH] bpf: update outdated comment for refactored btf_check_kfunc_arg_match() Kexin Sun
  2026-03-21 15:20 ` Yonghong Song
  2026-03-23  7:39 ` Jiayuan Chen
@ 2026-03-24 20:40 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2026-03-24 20:40 UTC (permalink / raw)
  To: Kexin Sun
  Cc: ast, daniel, john.fastabend, andrii, martin.lau, eddyz87, song,
	yonghong.song, kpsingh, sdf, haoluo, jolsa, bpf, linux-kernel,
	julia.lawall, xutong.ma, yunbolyu, ratnadiraw

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Sat, 21 Mar 2026 18:56:58 +0800 you wrote:
> The function btf_check_kfunc_arg_match() was refactored into
> check_kfunc_args() by commit 00b85860feb8 ("bpf: Rewrite kfunc
> argument handling").  Update the comment accordingly.
> 
> Assisted-by: unnamed:deepseek-v3.2 coccinelle
> Signed-off-by: Kexin Sun <kexinsun@smail.nju.edu.cn>
> 
> [...]

Here is the summary with links:
  - bpf: update outdated comment for refactored btf_check_kfunc_arg_match()
    https://git.kernel.org/bpf/bpf-next/c/70b5f3f7822a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-03-24 20:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-21 10:56 [PATCH] bpf: update outdated comment for refactored btf_check_kfunc_arg_match() Kexin Sun
2026-03-21 15:20 ` Yonghong Song
2026-03-23  7:39 ` Jiayuan Chen
2026-03-24 20:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox