From: Eduard Zingerman <eddyz87@gmail.com>
To: Ihor Solodrai <ihor.solodrai@pm.me>,
bpf@vger.kernel.org, andrii@kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, mykolal@fb.com
Subject: Re: [PATCH bpf-next 1/2] selftests/bpf: specify libbpf headers required for %.bpf.o progs
Date: Wed, 28 Aug 2024 14:20:30 -0700 [thread overview]
Message-ID: <ade54d9b9422e514f053ab38582a3758e6fb0325.camel@gmail.com> (raw)
In-Reply-To: <20240828174608.377204-1-ihor.solodrai@pm.me>
On Wed, 2024-08-28 at 17:46 +0000, Ihor Solodrai wrote:
[...]
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index c120617b64ad..53cc13b92ee2 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -516,6 +516,12 @@ xdp_features.skel.h-deps := xdp_features.bpf.o
> LINKED_BPF_OBJS := $(foreach skel,$(LINKED_SKELS),$($(skel)-deps))
> LINKED_BPF_SRCS := $(patsubst %.bpf.o,%.c,$(LINKED_BPF_OBJS))
>
> +HEADERS_FOR_BPF_OBJS := $(wildcard $(BPFDIR)/*.bpf.h) \
> + $(addprefix $(BPFDIR)/, bpf_core_read.h \
> + bpf_endian.h \
> + bpf_helpers.h \
> + bpf_tracing.h)
> +
Note, this states dependency on bpf_helpers.h and excludes
bpf_helpers_defs.h, however bpf_helpers.h includes bpf_helpers_defs.h.
Granted, bpf_helpers_defs.h is automatically generated so it probably
needs some trick similar to vmlinux.h?
> # Set up extra TRUNNER_XXX "temporary" variables in the environment (relies on
> # $eval()) and pass control to DEFINE_TEST_RUNNER_RULES.
> # Parameters:
> @@ -566,8 +572,7 @@ $(TRUNNER_BPF_OBJS): $(TRUNNER_OUTPUT)/%.bpf.o: \
> $(TRUNNER_BPF_PROGS_DIR)/%.c \
> $(TRUNNER_BPF_PROGS_DIR)/*.h \
> $$(INCLUDE_DIR)/vmlinux.h \
> - $(wildcard $(BPFDIR)/bpf_*.h) \
> - $(wildcard $(BPFDIR)/*.bpf.h) \
> + $(HEADERS_FOR_BPF_OBJS) \
> | $(TRUNNER_OUTPUT) $$(BPFOBJ)
> $$(call $(TRUNNER_BPF_BUILD_RULE),$$<,$$@, \
> $(TRUNNER_BPF_CFLAGS) \
next prev parent reply other threads:[~2024-08-28 21:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-28 17:46 [PATCH bpf-next 1/2] selftests/bpf: specify libbpf headers required for %.bpf.o progs Ihor Solodrai
2024-08-28 17:46 ` [PATCH bpf-next 2/2] selftests/bpf: do not update vmlinux.h unnecessarily Ihor Solodrai
2024-08-28 22:02 ` Eduard Zingerman
2024-08-28 23:25 ` Alexei Starovoitov
2024-08-30 20:34 ` Andrii Nakryiko
2024-08-30 21:03 ` Alan Maguire
2024-08-30 23:42 ` Arnaldo Carvalho de Melo
2024-08-30 21:23 ` Mykyta Yatsenko
2024-08-30 22:18 ` Andrii Nakryiko
2024-08-31 18:18 ` Ihor Solodrai
2024-09-03 16:58 ` Andrii Nakryiko
2024-08-28 21:20 ` Eduard Zingerman [this message]
2024-08-30 20:40 ` [PATCH bpf-next 1/2] selftests/bpf: specify libbpf headers required for %.bpf.o progs patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ade54d9b9422e514f053ab38582a3758e6fb0325.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=ihor.solodrai@pm.me \
--cc=mykolal@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox