From: David Ahern <dsahern@gmail.com>
To: Rumen Telbizov <rumen.telbizov@menlosecurity.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>, bpf@vger.kernel.org
Subject: Re: bpf_fib_lookup support for firewall mark
Date: Fri, 11 Jun 2021 19:13:08 -0600 [thread overview]
Message-ID: <ae33242e-25c0-744b-6060-4cdecb32e3dc@gmail.com> (raw)
In-Reply-To: <CA+FoirA-eAfux3PfxjgyO=--7duWCKuyeJfxWTdW6jiMWzShTw@mail.gmail.com>
On 6/11/21 5:56 PM, Rumen Telbizov wrote:
> Hey David,
>
> I just tested your proposed patch and I want to confirm that it works
> great for my use-case.
> I get the same rule-selected route based on firewall mark as the outside
> ip route get ... mark ...
> Also since we didn't touch the ports, multipathing works as expected -
> gives a different route
> based on the hash of the socket tuple.
great.
>
> So having said that I can't help but wonder what the next steps might be.
>
> Are you able/willing to incorporate this work in the kernel?
I do not have the time or hardware at the moment to do the testing - or
create the selftest for it. If you do have the time for the selftest, we
can tag team it.
> If yes I also wonder if it would be possible to backport it into 5.10
> branch?
>
5.10 backports are done out of tree, so you are on your own there.
next prev parent reply other threads:[~2021-06-12 1:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-08 22:59 bpf_fib_lookup support for firewall mark Rumen Telbizov
2021-06-09 1:21 ` David Ahern
2021-06-09 18:30 ` Rumen Telbizov
2021-06-09 21:56 ` Rumen Telbizov
2021-06-09 22:08 ` Daniel Borkmann
2021-06-10 14:37 ` David Ahern
2021-06-10 17:41 ` Rumen Telbizov
2021-06-10 18:52 ` David Ahern
2021-06-10 20:58 ` Daniel Borkmann
2021-06-11 1:41 ` David Ahern
2021-06-11 17:32 ` Rumen Telbizov
[not found] ` <CA+FoirA-eAfux3PfxjgyO=--7duWCKuyeJfxWTdW6jiMWzShTw@mail.gmail.com>
2021-06-12 0:00 ` Rumen Telbizov
2021-06-12 1:13 ` David Ahern [this message]
2021-06-14 16:53 ` Rumen Telbizov
2021-06-29 17:18 ` Rumen Telbizov
2021-06-29 17:21 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae33242e-25c0-744b-6060-4cdecb32e3dc@gmail.com \
--to=dsahern@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=rumen.telbizov@menlosecurity.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).