From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66C283793DA for ; Tue, 21 Apr 2026 08:54:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776761698; cv=none; b=Z6oWw9caBuJtCDm7TQ9tzkET9E2OOw0D4whUX3HiL6uIUIgwt9kxWaGV11yvCb5tkugj4eyr40akqZx8TzbWKgkALiua/pBq0aiu65KUEmmGo9ugvhRYINK37X2VhnWcWZbwUzbbPkCeIjpwhLnjDBFpCJv0GN4C9deLHe0uqmk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776761698; c=relaxed/simple; bh=KOd+LAoM7dvqCxKW/Ccet+yk/av8Oxjn8Nrd8ta9Gd0=; h=From:Date:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hG9LEhsd3/t7E9EcbM1IK+0Pfp/H1oN2lmSofFL5WvdTruO9cKIA5J56HYJUMP1A+0ovXGF8b0+PbvL1rfLthGjlGSI8hqzGGDqBRDewLqjDg74O5UXx+q3hHJKOdWD9xFFKkR8R6GPoAwjGyA5J7rKYueV1j7fNavp0Uma8KAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XsmtRqsF; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XsmtRqsF" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4893940bb5eso9978905e9.3 for ; Tue, 21 Apr 2026 01:54:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776761696; x=1777366496; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=QsEGDw0sph5lbiDCNcPBIQnZObof1B1mZata9gcne4o=; b=XsmtRqsF7q3sSwD7bnH71eBnmrEDSk/MHvCEqr2hXgqcEXBLdCCKEKQIuDhVtmQFCR MsVztfnZGSGzlR4hRL1312Oibzc/Lo2W+nmP8p1SM8D2UZ8GWligvDsbnhF7C4KPMS7c +YF57Cg2ugPvsUCt6dBArbDEjStS5odrauZTucIu2AuGVWlVo0LWNIHSX32/4sc44sFK wiNK498/7MhkUkIgSr4J+GYnMl1yK7l50XGf615RnmRbt+OJZSrQZYcGwHRVR1M5+8Jt OCv5VGPM/LgdAzAJyEtiyOYodvLcyFbTUsk05lDCbaeN75CsloW5Y0Blrr0Z1tusX0og 4pUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776761696; x=1777366496; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QsEGDw0sph5lbiDCNcPBIQnZObof1B1mZata9gcne4o=; b=mHiEKaeJAng9Q44+PVbIXISyrpT/smhU1DktsIas6SCLfEKz8w6DbbzB24vzIXB4RK 203fN/vJURdkKxNyqvQuBc6WcMfIg6p9Jnkup5/KyeOZoDGa2lGtOrGlfR3QeHlYfgcg mRaAz7zHrQw4aouB32HEpDFtUWk71E8nuhyhW0H2tRTS5cZOCpyAoG7hxK3fSBYHRE/Z nG0NZjgkAb+luYnzdisrnJ5lB7FaQJ3FccHnn3EVAH7eSc9u8PUFwV1iS53xb19GBpXh eyfkQpk8FeCb2gKHwqJ9S7Gn4AWv+T5UWTtPkGselgYRL6VipqiNvaSLG2IrBdJ6L9Bk HDpg== X-Forwarded-Encrypted: i=1; AFNElJ868eGSicRYD+0zbrIRhYJoNo/B+hBOxC+oA5Z1u2pgdyd/SywtKG7NVVjFiVum/XB2EVM=@vger.kernel.org X-Gm-Message-State: AOJu0YxD9Npas1yNywAx/6VIbDFy8W3qXrp0VI9DN9zVsuDa2OJkSobh GHzrrYMeM+WhzfrU05+ppWCTtvq0GI1umKAYTsas7ZMYBdAS++vOspSH X-Gm-Gg: AeBDietCr5JhPviH2etZkWzu3jPfOE/vQ/RUtR0bCBqNK79S3599v3AdMg003BvIpM/ jGyAMDfnWT1LjyzI043etjZ3FDAzv+rYRvvLtAqSswf2EG50mHbPUZ35Rz+UfPlztgEAA6V4ySB EZLAwmRcT/bPqRNAKczx+tkNeRow5RtvJNs0oLyrInd6sgLDvaJs2d6+q1+qymOfFAAY016HMzQ J6m5b8O0SJc5cipeXE7HdAV45645u3WvlQbfXqatWNGlfEaVzkPEP5wUuU5nosYJc01vIiDiVEF o6QR5PsJnvXzY3V+p4TcT0bmWb8xljplRp0+HC8jVgJyVVl2g+r4BFXDYjzF1O4UAuljME4XiMB MJQdmVKI8EzERPOnvUcDmpihfIOfVwM1NfwRmT/omH4+dECcvbhQ5MmOeAyoeGTBVkHBjaVfWtW wlubeYuc2AmNJ6dG6D/w== X-Received: by 2002:a05:600c:c0d3:b0:488:a916:14a8 with SMTP id 5b1f17b1804b1-488fb74fe74mr194042495e9.10.1776761695708; Tue, 21 Apr 2026 01:54:55 -0700 (PDT) Received: from krava ([2a02:8308:a00c:e200::d99c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fb77b001sm160849805e9.3.2026.04.21.01.54.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Apr 2026 01:54:55 -0700 (PDT) From: Jiri Olsa X-Google-Original-From: Jiri Olsa Date: Tue, 21 Apr 2026 10:54:53 +0200 To: bot+bpf-ci@kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org, kafai@fb.com, eddyz87@gmail.com, songliubraving@fb.com, yhs@fb.com, menglong8.dong@gmail.com, rostedt@kernel.org, martin.lau@kernel.org, yonghong.song@linux.dev, clm@meta.com, ihor.solodrai@linux.dev Subject: Re: [PATCHv5 bpf-next 02/28] ftrace: Add ftrace_hash_remove function Message-ID: References: <20260417192502.194548-3-jolsa@kernel.org> <14d32b2f6aacddfce59d73dc5e1c0ea423f84e373ca130f6830c3e26154e70b3@mail.kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <14d32b2f6aacddfce59d73dc5e1c0ea423f84e373ca130f6830c3e26154e70b3@mail.kernel.org> On Sat, Apr 18, 2026 at 06:10:52AM +0000, bot+bpf-ci@kernel.org wrote: > > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h > > --- a/include/linux/ftrace.h > > +++ b/include/linux/ftrace.h > > @@ -416,6 +416,7 @@ void free_ftrace_hash(struct ftrace_hash *hash); > > struct ftrace_func_entry *add_ftrace_hash_entry_direct(struct ftrace_hash *hash, > > unsigned long ip, unsigned long direct); > > unsigned long ftrace_hash_count(struct ftrace_hash *hash); > > +void ftrace_hash_remove(struct ftrace_hash *hash); > > > > /* The hash used to know what functions callbacks trace */ > > struct ftrace_ops_hash { > > diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c > > --- a/kernel/trace/ftrace.c > > +++ b/kernel/trace/ftrace.c > > @@ -1249,6 +1249,25 @@ remove_hash_entry(struct ftrace_hash *hash, > > hash->count--; > > } > > > > +void ftrace_hash_remove(struct ftrace_hash *hash) > > +{ > > + struct hlist_head *hhd; > > + struct hlist_node *tn; > > + struct ftrace_func_entry *entry; > > + int size = 1 << hash->size_bits; > ^^^^^^^^^^^^^^^^ > > Can this dereference a NULL pointer? The code computes the size using > hash->size_bits before checking if hash is NULL: > > int size = 1 << hash->size_bits; > ... > if (!hash || !hash->count) > return; yep, we should deref after the check, will fix jirka