From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C69C63C4574 for ; Mon, 18 May 2026 11:30:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779103845; cv=none; b=RbMPs/cfA+D6qHYCLGXdm3/H4PoXsDIi4ptgtG0FxSsw1gB+C3uWpygCe0oOgExJOkOdsvEJR0JfUC6ENoR2mLqEsE1G9VMslQor9L2u6OcKkhnX0kAtKBBQLsrKqNQFTU7jS5U1lwyvAvwRyfV5ZuzzBJvXurby1ld7H/N+yXY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779103845; c=relaxed/simple; bh=a8pMTZrbCVo8ggCBj+04CNraHKq2UJhbdckV3vw1Iug=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BnwOjuI5fuOd/l23wjAI5dXyYH3v6bHT7GYOLmPaBTs+VW+mDbUiPHX1Jny3cBmA3AdMP31vp8iDcVBBNIjqUHrZdXYM300WZQ90TcOnJGN4C48cz++6k/g5rTq4yaQMees987xXaDE1chevgfQ4pGYztIxhEwOyRWk4BuL+Ruk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=j/w7ML8J; arc=none smtp.client-ip=209.85.221.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="j/w7ML8J" Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-44b330c5cc6so1534780f8f.1 for ; Mon, 18 May 2026 04:30:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779103840; x=1779708640; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cq2IndJkk2Z/xx3Cj2HaRpHci4EMlQjTZVq9ezC+9Ls=; b=j/w7ML8J73W63tCtdkT/b7bwilbqX+p9hoDdVfWb0P9dzWJmRSjZoWLM41bZjAbowc FY3zaxdMtKx7ma7DJY+nxCbYsolsV3+uahYbCNTaEi9v2JaoVnSj73UGf8imubNP062/ R/gOtWyWQSO4Zkla0Tet3ldXO+xVEuxbJlRPs719to5ccOIamfykCcPtBVWk9wb7JZ6W /87XySZcz2mhBiFrMzI4fLvPswOLi/Q3ijCbjZ0TYsAdDpCaPyC7ujKXc0YY8cSC6Vxn 9IeXdMNKall1KQ9t6vBfgulrE6SSWFLbY0jpquojWA2Zh8zI/LX4E41rnQPva9zQu0Dz hlNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779103840; x=1779708640; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cq2IndJkk2Z/xx3Cj2HaRpHci4EMlQjTZVq9ezC+9Ls=; b=SQ9HD3a/1ybNNByPAxXs/cTfoHSvWaqwH2P7lOMN7b6el68Qi+WVb+2GUZebquG1p+ J2GxjHPEuU3RpVJ+zDUJh8O1owqS6uqSApSnqoZSvzhO9KSYkyrjUOxPbyZ7lFMPIkoM GQTSrWrtTzA2wGFDW/Qaf8/UTNoP7yMNwrjYdQ0b7bx6YpCEps+lpg1RlmgReSubWw6A 94txbL8M8cgU50CT+dIryVbjlpGNvLfFl6w1/1LMoaQtmask9n2mMCnTXInw/hjNUxkS PTjST7wzdfutspl2jS/+082B8fhfZTvia61uNOL1LQRTxk1EJPR7Tcnhf7bvT0fhNW1k +8Ig== X-Gm-Message-State: AOJu0YyewCBQxVb/tU0XDKfegQ/rqKrpNsMwhJ1H0PR4QKHeeI44YaWe vMiG9dZKgM8vEUge4e61GPM11GrpEbSWF0tGV/lRQnB1AfiTAYCIrU4+ X-Gm-Gg: Acq92OGxf+sLGVaWQZW2NNL1L1IWJTU7FVF2NsBZv77JY7hX28RDEOewLVgAuRdUyVA 94Vk5pJiWvkz7qQGq+Zy0XlcAKWVTVKysvsMzF5Qpymro5BEw7RsBCyWmPIjf60VZhtJa9W9/uD 0OUAm7f4X7eOUnB09NSazws46TXugnUgyDsxB58hmdLJcB1NR5g1EgrS5xL685GlMk/+apSs/dB bCgOBVDz01wQaVM8mdjAH937vozVvhXEF+f2/M00kVVmIerDv14oOoFrRKUp2wo/kdeIvZjTkSo cIdtmE4Wexyhvvjm2x2STwAEogsUQLjSmj4pZZKOcoShx3sle0NnQqCPb38HADrT0p5tuZW17tv uu8OTl2lTxLigp7tj91tjkfrUC4TtvJpFiPCIVrAxXSP51ZddScqs/8BlFQ+5TN1eJ/PKOU1KE8 bTE1AYlazusEn6CY45laW/pw3ZG5P+M8SYYzRt6fOi61X3K93l0TZnr10sZfeN9QjZxQE03t06M mim6uAS+SdGOBiyXDooVRqVtFVFIPAnCpJ6OlKnfTvkM4SuBjUlu6dyr1x3dViEAAT8ivHuP/wV ILhHDHiZbYIzYfYQOXXV2XdtTon0tRTDEapvEUWI9sw= X-Received: by 2002:a05:6000:2dc2:b0:45d:4c20:7285 with SMTP id ffacd0b85a97d-45e5c5bbe46mr24159481f8f.6.1779103840151; Mon, 18 May 2026 04:30:40 -0700 (PDT) Received: from mail.gmail.com (2a01cb0889497e003b74b873959997d2.ipv6.abo.wanadoo.fr. [2a01:cb08:8949:7e00:3b74:b873:9599:97d2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45da0fe13b4sm37171571f8f.28.2026.05.18.04.30.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 May 2026 04:30:38 -0700 (PDT) Date: Mon, 18 May 2026 13:30:36 +0200 From: Paul Chaignon To: Roman Kvasnytskyi Cc: bpf@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Kumar Kartikeya Dwivedi , Song Liu , Yonghong Song , Jiri Olsa , Shuah Khan , KP Singh , linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH bpf] selftests/bpf: Reject unsupported -k option in vmtest.sh Message-ID: References: <20260516120625.80839-1-roman@kvasnytskyi.net> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260516120625.80839-1-roman@kvasnytskyi.net> On Sat, May 16, 2026 at 02:06:25PM +0200, Roman Kvasnytskyi wrote: > vmtest.sh does not document a -k option and does not handle it in the > getopts case statement. However, the getopts optstring includes k, which > causes the script to accept -k silently instead of reporting it as an > invalid option. > > Remove k from the optstring so unsupported options are rejected through > the existing invalid-option path. > > Fixes: c9709f52386d ("bpf: Helper script for running BPF presubmit tests") > Signed-off-by: Roman Kvasnytskyi I'm unsure this needs to go through the bpf tree, but it currently applies cleanly to both bpf-next and bpf anyway. Acked-by: Paul Chaignon > --- > tools/testing/selftests/bpf/vmtest.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/vmtest.sh b/tools/testing/selftests/bpf/vmtest.sh > index 2f869daf8a06..9ca802285393 100755 > --- a/tools/testing/selftests/bpf/vmtest.sh > +++ b/tools/testing/selftests/bpf/vmtest.sh > @@ -382,7 +382,7 @@ main() > local exit_command="poweroff -f" > local debug_shell="no" > > - while getopts ':hskl:id:j:' opt; do > + while getopts ':hsl:id:j:' opt; do > case ${opt} in > l) > LOCAL_ROOTFS_IMAGE="$OPTARG" > > base-commit: a828abbb897657451d96ad7bf20f1893ac983bb9 > -- > 2.54.0 > >