BPF List
 help / color / mirror / Atom feed
From: Kuan-Wei Chiu <visitorckw@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: geert@linux-m68k.org, ast@kernel.org, daniel@iogearbox.net,
	andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com,
	martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev,
	jolsa@kernel.org, jserv@ccns.ncku.edu.tw, eleanor15x@gmail.com,
	marscheng@google.com, linux-kernel@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org, bpf@vger.kernel.org,
	Daniel Palmer <daniel@thingy.jp>
Subject: Re: [PATCH bpf-next v3] m68k, bpf: Add initial BPF JIT compiler support
Date: Tue, 19 May 2026 01:12:40 +0800	[thread overview]
Message-ID: <agtIiKuoTlp-4XAO@google.com> (raw)
In-Reply-To: <87h5oc4jpf.fsf@igel.home>

Hi Andreas,

On Tue, May 12, 2026 at 07:32:44PM +0200, Andreas Schwab wrote:
> On Mai 11 2026, Kuan-Wei Chiu wrote:
> 
> > +
> > +			emit_16(ctx, 0x4a80 | d_lo);			/* tst.l d_lo */
> > +			emit_16(ctx, 0x6b04);				/* bmi.s .+6 */
> > +			emit_16(ctx, 0x7000 | (d_hi << 9));		/* moveq #0, d_hi */
> > +			emit_16(ctx, 0x6002);				/* bra.s .+4 */
> > +			emit_16(ctx, 0x70ff | (d_hi << 9));		/* moveq #-1, d_hi */
> 
> I think this could be "tst.l d_lo; smi d_hi; extb.l d_hi".
> 
Sorry for the late reply, and thanks for the review.

This makes sense.
I initially kept things simple to focus on correctness first, but since
you pointed it out, I will include this optimization in the next
respin.

Thanks!

Regards,
Kuan-Wei

  reply	other threads:[~2026-05-18 17:12 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 21:27 [PATCH bpf-next v3] m68k, bpf: Add initial BPF JIT compiler support Kuan-Wei Chiu
2026-05-11 22:12 ` bot+bpf-ci
2026-05-18 17:21   ` Kuan-Wei Chiu
2026-05-12 11:57 ` Greg Ungerer
2026-05-18 17:07   ` Kuan-Wei Chiu
2026-05-12 17:32 ` Andreas Schwab
2026-05-18 17:12   ` Kuan-Wei Chiu [this message]
2026-05-13  1:03 ` sashiko-bot
2026-05-18 17:32   ` Kuan-Wei Chiu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agtIiKuoTlp-4XAO@google.com \
    --to=visitorckw@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=daniel@thingy.jp \
    --cc=eddyz87@gmail.com \
    --cc=eleanor15x@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=jolsa@kernel.org \
    --cc=jserv@ccns.ncku.edu.tw \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=marscheng@google.com \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=schwab@linux-m68k.org \
    --cc=song@kernel.org \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox