Re: [PATCHv6 bpf-next 18/29] libbpf: Add bpf_link_create support for tracing_multi link

[Jiri Olsa <olsajiri@gmail.com>]

On Wed, May 27, 2026 at 12:09:05PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Low] The patch references new UAPI constants and struct members that are not defined in the corresponding UAPI headers.
> --
> 
> commit 950db3ba53901f76f22567de80577ef3f82cd57b
> Author: Jiri Olsa <jolsa@kernel.org>
> 
> libbpf: Add bpf_link_create support for tracing_multi link
> 
> This commit adds bpf_link_create support for the tracing_multi link by handling
> the new attach types and extracting the tracing_multi options from the user
> provided bpf_link_create_opts struct.
> 
> > diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c
> > index 3cd7058023304..ff342972ca4a4 100644
> > --- a/tools/lib/bpf/bpf.c
> > +++ b/tools/lib/bpf/bpf.c
> > @@ -843,6 +843,15 @@ int bpf_link_create(int prog_fd, int target_fd,
> >  		if (!OPTS_ZEROED(opts, uprobe_multi))
> >  			return libbpf_err(-EINVAL);
> >  		break;
> > +	case BPF_TRACE_FENTRY_MULTI:
> > +	case BPF_TRACE_FEXIT_MULTI:
> > +	case BPF_TRACE_FSESSION_MULTI:
> > +		attr.link_create.tracing_multi.ids = ptr_to_u64(OPTS_GET(opts, tracing_multi.ids, 0));
> 
> [Severity: Low]
> Will this compile without the corresponding UAPI header updates?
> 
> It appears the constants BPF_TRACE_FENTRY_MULTI, BPF_TRACE_FEXIT_MULTI, and
> BPF_TRACE_FSESSION_MULTI, as well as the tracing_multi struct in union
> bpf_attr, are not defined in the UAPI headers included in this patch.

it compiles at this changes, uapi changes are there from earlier change:
  bpf: Add support for tracing multi link

jirka

> 
> > +		attr.link_create.tracing_multi.cookies = ptr_to_u64(OPTS_GET(opts, tracing_multi.cookies, 0));
> > +		attr.link_create.tracing_multi.cnt = OPTS_GET(opts, tracing_multi.cnt, 0);
> > +		if (!OPTS_ZEROED(opts, tracing_multi))
> > +			return libbpf_err(-EINVAL);
> > +		break;
> 
> -- 
> Sashiko AI review · https://sashiko.dev/#/patchset/20260527113951.46265-19-jolsa@kernel.org?part=1