From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 612874657F8 for ; Mon, 29 Jun 2026 16:40:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782751224; cv=none; b=PvV7BPcNGhbGpWE+WfxOh8188Qacy2j2t89R33wCHTHjnRuNiYIyIftFFagqQBvaXAWn4NGc60EkKOfb6S+oXGpNle3wF72ntrFosaIR1IL1Fndi+WBccveP4hjJOgUR0acwoWzQMl47Zsp0OHaSqTOW+DNap9pd6sRVp28XH/M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782751224; c=relaxed/simple; bh=T1fLXCn3FavD3bJ3PxuobqPBjZ+A8RlVrG4IjG7DiNE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rtXZsoUhw9X5yF205Lkgtn7rO1TlnuDZuk+ZmoebPxj8c/AgVxSxH2pGU9cZ62USmXMQY1OMQYrM1hJTid/pyesfmIyvAwkHIK9f3SzgmC5eI0ZhU2FzSlF0Igd+MjdOKCFyRSVf/C6Zhgex83fBFXEkHZSVVrgKvHKk6OttKiE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UE2QrexO; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UE2QrexO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782751217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CviOjkV9/YgKW2WypG09pJ964/zY+DekGBGC6jJ7pxM=; b=UE2QrexO/BGSvAHBa3oSwFZalPY8n8OTvSxwxoyHVuieKbLaKI5Eoyr9qJbQQ65Jc8JZOx JgSsucZh5BnnJSuEhZYkV2A/1hJ2YzMPfmSthfn0CdOC8TcvSzAll5bxZaB6uoiTALOP10 KuBtshhvhnwAZ6MFeAU3mGibgrCfr3Y= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-637-rpdYnSZOPrigYNwYjzgDog-1; Mon, 29 Jun 2026 12:40:13 -0400 X-MC-Unique: rpdYnSZOPrigYNwYjzgDog-1 X-Mimecast-MFC-AGG-ID: rpdYnSZOPrigYNwYjzgDog_1782751212 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7874B1955F44; Mon, 29 Jun 2026 16:40:12 +0000 (UTC) Received: from fedora (unknown [10.44.32.37]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id 6085F3000B76; Mon, 29 Jun 2026 16:40:09 +0000 (UTC) Received: by fedora (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 29 Jun 2026 18:40:12 +0200 (CEST) Date: Mon, 29 Jun 2026 18:40:07 +0200 From: Oleg Nesterov To: Jiri Olsa Cc: Peter Zijlstra , Ingo Molnar , Masami Hiramatsu , Andrii Nakryiko , bpf@vger.kernel.org, linux-trace-kernel@vger.kernel.org Subject: Re: [PATCHv4 05/13] uprobes/x86: Move optimized uprobe from nop5 to nop10 Message-ID: References: <20260526205840.173790-1-jolsa@kernel.org> <20260526205840.173790-6-jolsa@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 On 06/29, Jiri Olsa wrote: > > --- a/arch/x86/kernel/uprobes.c > +++ b/arch/x86/kernel/uprobes.c > @@ -265,6 +265,10 @@ static bool is_prefix_bad(struct insn *insn) > > attr = inat_get_opcode_attribute(p); > switch (attr) { > + case INAT_MAKE_PREFIX(INAT_PFX_CS): > + if (insn->x86_64) > + break; > + fallthrough; > case INAT_MAKE_PREFIX(INAT_PFX_ES): > case INAT_MAKE_PREFIX(INAT_PFX_DS): > case INAT_MAKE_PREFIX(INAT_PFX_SS): > > or we could just skip it for nop10.. maybe that's better Well, if you ask me I'd agree with the "maybe that's better" plan ;) I mean... I don't think that INAT_PFX_CS should be "special" in is_prefix_bad. But, whatever you do - I agree, feel free to keep my r-b. Oleg.