From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BDB61479882 for ; Thu, 6 Aug 2026 17:18:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786036711; cv=none; b=WUDo6rRO0UXitufcF/on66KGjUKAqDWEJ1W2H9cC62Mh/39BWfJEDIUJs2OP43fUcW0qTIMF4TPUL5EijKByYWfD/iidnMxF+fzybalSWdUsOjUzl1yPggzYnVsSgEFjveGH8DTn99g8TzeTKBcoh20ffyvVDtpEHQuK+z4qoPE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786036711; c=relaxed/simple; bh=qvL3nCCpR5lk9Hk8P+wRnrAYaQeYlVNsbJ6hCuqZZy8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SmGy9S9I3QdKtjBXCt0lAJVmYFIrF05J6HAhVaI0/lJUKtVHvreuRxQIJL81UY5jQKVcWut9o6CSjULEsvjKpc21sQ/08Nmfu+E0LjzgOggpfP0WXWDEWWVQlA7c2Z2GrHwaaKAeN4/mV2grH2Yg3d5sZCB8uPrRgMagEzdXxRU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=E6e+eXgU; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="E6e+eXgU" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-498028b3d5eso24678905e9.1 for ; Thu, 06 Aug 2026 10:18:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786036708; x=1786641508; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=qYLZD645akLQlKnPufmUkf56Es45Q9w4M4KndfohRRc=; b=E6e+eXgUyt2NvGqh9EdDDlz5ZS1wkeDFgCH+T5QzN2BuTVhgdoq7+njAHez+nlhGHd H4q8BdQXh6QV8nMm7nlVsI15ztmj9/tm9cTD8AmEu3+OQ6XvCu9ndG1U9RaUegZ1DktF ebx4wTO7CHVBc8HNd/5xEwxX+Ltn24fl089y5x2ZimboFpylkVGzSU2iVLre+vHzvvM8 g067JLs+Sbd5Y1TD65jViwVmuaPbRrBI5b4wSzifS4kF+qsi2nquMY86WZjFH5IgQFCr URtYZ4XqtBAkKiQVr34bMrc5MLEv2GhwRB5ywTwkn4wA9bquHVLr64fXXeZN8IUSn7Ah c4lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786036708; x=1786641508; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=qYLZD645akLQlKnPufmUkf56Es45Q9w4M4KndfohRRc=; b=TicwV8p1EnE0RoXHG+hl7BogvBt0PF2dnjlzgt5EhADZQUz5PGCS3M5MeWkTqT51Uv Wn88eYmuLQkyGz5kO7p6W4yWVps4R8CFEBCP+FNFrb+cAVqY/tvSRTUppOuHbBKsk2O/ fsfzXwZqTau4rJ+zmOF4gHsIFZznnemtYdU7W1GsyTG5XbN/aUJpP8KeJNUjCJjcxwg1 fJV2JeGdxdS/NTubKzMDHdp9zGpYcXTbMFC4GZZFpvXyCKVKB+KpxTvNjQqYUhrEqueF FWnBfKikS2crWKuBhXpNSe8gym031ZKunLVG4SHw9xk+xsA/upsnybfd8SsUUoL9hZ1m jeiQ== X-Gm-Message-State: AOJu0Ywry/e7j+vbmFeUjCuFtbQ0xw6juRpm0xv96mSmkj+eTs4tQLJ6 HAyJGCg9BSvdWu+BLy3XhgQN8WFEJDXTefjrtr0tJdBspEW+uRfH6F+q X-Gm-Gg: AR+sD118c0nohQxhna/YGRnVVUyFqvi6j+HkA16Oty1j7wNGCz4Eu5DMTxiBUba257p fqSJ1BbZ0tboFyXTy68ED1K8tFajBqpK88VICLHAXYqBL74xsg3Rg1F003sPKQjTCqFk6rycTcY ER0B+YCWt43zac98qMdJVevK+G2+kqKKy6c+NfOf9D1KcNCg8nm9X6NXff/Accw4RKYp3HLuGOu lQhBUCaFgZodLNmNjEWaI0DUqqAu1oIg7+PgSpHVZzLi9u4aNm6JZwySA5ogvcfv4rY3eBBY2yf 9vzWC3VJ8KXw0oH+6DzBdCFaQ/A75KLUfmj+1+iVPjakf1L5kv1OInatgYmUuSJdsJFk6x+0xv0 OPBYHwl55ihHeUOfFVM8UeE5x/62qGMnyXvRnT7fqGsrj3EkuEn3PrQ33iR0C1bl6cDoidonRgP 56Gi/QW46dFKvifVP4Hk5DETOI7HACOLWCFf9jROK4Q4UQ7Q4EnnSDDGls9siTh/xD+mftLAGzN MFcN3IMzmcPGGZJh9NvdA== X-Received: by 2002:a05:600c:22ca:b0:498:ee7:e40a with SMTP id 5b1f17b1804b1-4994e7d2c19mr183148595e9.16.1786036707630; Thu, 06 Aug 2026 10:18:27 -0700 (PDT) Received: from gmail.com (deskosmtp.auranext.com. [195.134.167.217]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47ff7b329cbsm7813135f8f.37.2026.08.06.10.18.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2026 10:18:27 -0700 (PDT) Date: Thu, 6 Aug 2026 19:18:25 +0200 From: Mahe Tardy To: Song Liu Cc: bpf@vger.kernel.org, andrew+netdev@lunn.ch, andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, eddyz87@gmail.com, edumazet@google.com, john.fastabend@gmail.com, kuba@kernel.org, liamwisehart@meta.com, martin.lau@linux.dev, pabeni@redhat.com, netdev@vger.kernel.org, sdf.kernel@gmail.com, ameryhung@gmail.com, kuniyu@google.com Subject: Re: [PATCH bpf-next v3 1/5] net: Add __sys_connect_socket() helper Message-ID: References: <20260804164652.296919-1-mahe.tardy@gmail.com> <20260804164652.296919-2-mahe.tardy@gmail.com> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Aug 04, 2026 at 09:05:28PM -0700, Song Liu wrote: > On Tue, Aug 4, 2026 at 9:47 AM Mahe Tardy wrote: > > > > Add a helper that connects an existing socket while invoking the LSM > > hook. Reuse it in __sys_connect_file() to avoid duplicating the connect > > logic. Other socket operations have equivalent helpers that trigger the > > appropriate LSM hooks that can be reused, this one was the only one > > missing. > > > > Signed-off-by: Mahe Tardy > > --- > > include/linux/socket.h | 2 ++ > > net/socket.c | 32 ++++++++++++++++++-------------- > > 2 files changed, 20 insertions(+), 14 deletions(-) > > > > diff --git a/include/linux/socket.h b/include/linux/socket.h > > index 2a8d7b14f1d1..48f1eb8193de 100644 > > --- a/include/linux/socket.h > > +++ b/include/linux/socket.h > > @@ -461,6 +461,8 @@ extern struct file *__sys_socket_file(int family, int type, int protocol); > > extern int __sys_bind(int fd, struct sockaddr __user *umyaddr, int addrlen); > > extern int __sys_bind_socket(struct socket *sock, struct sockaddr_storage *address, > > int addrlen); > > +extern int __sys_connect_socket(struct socket *sock, struct sockaddr_storage *addr, > > + int addrlen, int flags); > > IIUC, __sys_ prefix is for functions behind syscalls. Do we really want this > prefix here? Yeah let's remove it. > > Thanks, > Song > > > extern int __sys_connect_file(struct file *file, struct sockaddr_storage *addr, > > int addrlen, int file_flags); > > extern int __sys_connect(int fd, struct sockaddr __user *uservaddr, > > diff --git a/net/socket.c b/net/socket.c > > index 63c69a0fa74e..c7427dd4dd52 100644 > > --- a/net/socket.c > > +++ b/net/socket.c