BPF List
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@debian.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: sashiko-reviews@lists.linux.dev, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH] bpf: arena: reschedule while freeing the arena pages
Date: Wed, 26 Aug 2026 03:03:17 -0700	[thread overview]
Message-ID: <ao61BrPZiCx7erAR@gmail.com> (raw)
In-Reply-To: <CAADnVQKP8R=1aZiDcnfkqD3mA=32R2Yrw642u3w7de4JSfMWKg@mail.gmail.com>

Hello Alexei,

On Tue, Aug 25, 2026 at 09:35:03AM -0700, Alexei Starovoitov wrote:
> Just to be clear.. Is this needed to backport to some older kernel?
> New kernel with CONFIG_PREEMPT_LAZY=y shouldn't need
> this old practice of sprinkling cond_resched().

Yes, this is happening on our Meta kernel, and it is crashing a lot on old
kernel in production.

It does crash a lot for us: 56780 crashes over 1538 hosts in the last 30
days, 41% of all our kernel crashes in that window.  But it stops dead
at 6.13:

    6.11.1     26060 crashes /  160 hosts
    6.13.2     26014 crashes / 1119 hosts

Looking further, it seems that commit 517e8a7835e8c ("bpf: Fix softlockup in
arena_map_free on 64k page kernel") is what is what makes the
difference, which landed in v6.14.  Meta's arm64 kernels use 64k pages,
so before that commit GUARD_SZ / 2 is 32768 and
bpf_arena_get_kern_vm_start() is not page aligned

So there is nothing to fix upstream, and nothing to fix in the teardown
loop.  We just need 517e8a7835e8c in our 6.11 and 6.13 branches.

Sorry for the noise
Thanks,

--
pw-bot: rejected

  reply	other threads:[~2026-08-26 10:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-24 16:54 [PATCH] bpf: arena: reschedule while freeing the arena pages Breno Leitao
2026-08-24 17:08 ` sashiko-bot
2026-08-25 14:06   ` Breno Leitao
2026-08-25 16:35     ` Alexei Starovoitov
2026-08-26 10:03       ` Breno Leitao [this message]
2026-08-24 17:48 ` bot+bpf-ci

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ao61BrPZiCx7erAR@gmail.com \
    --to=leitao@debian.org \
    --cc=alexei.starovoitov@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox