From: Ratheesh Kannoth <rkannoth@marvell.com>
To: <sashiko-reviews@lists.linux.dev>
Cc: <bpf@vger.kernel.org>
Subject: Re: [PATCH v13 net-next] octeontx2-pf: add mqprio bandwidth offload for NIX TX schedulers
Date: Tue, 8 Sep 2026 11:51:42 +0530 [thread overview]
Message-ID: <ap-pdktpQJ8y3LYx@rkannoth-OptiPlex-7090> (raw)
In-Reply-To: <20260905031641.F3C191F00A3D@smtp.kernel.org>
On 2026-09-05 at 08:46:41, sashiko-bot@kernel.org (sashiko-bot@kernel.org) wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
>
> New issues:
> - [High] Use-After-Free of transmit queue structure (qset.sq) due to direct ndo_stop() call without disabling TX
> - [High] Non-atomic read-modify-write of `pfvf->flags` causes a lost update of `OTX2_FLAG_INTF_DOWN`, leading to a double free of queue memory and IRQs.
>
> Pre-existing issues:
> - [High] Hardware QoS queues are not re-allocated after an interface bounce, causing configuration of invalid/unallocated TX schedulers.
> --
Will address in v14
pw-bot: changes-requested
next prev parent reply other threads:[~2026-09-08 6:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 3:15 [PATCH v13 net-next] octeontx2-pf: add mqprio bandwidth offload for NIX TX schedulers Ratheesh Kannoth
2026-09-05 3:16 ` sashiko-bot
2026-09-08 6:21 ` Ratheesh Kannoth [this message]
2026-09-09 21:20 ` netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ap-pdktpQJ8y3LYx@rkannoth-OptiPlex-7090 \
--to=rkannoth@marvell.com \
--cc=bpf@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox