From: Anton Protopopov <a.s.protopopov@gmail.com>
To: bot+bpf-ci@kernel.org
Cc: sidchintamaneni@gmail.com, bpf@vger.kernel.org, ast@kernel.org,
daniel@iogearbox.net, john.fastabend@gmail.com,
andrii@kernel.org, eddyz87@gmail.com, memxor@gmail.com,
martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev,
jolsa@kernel.org, emil@etsalapatis.com, ihor.solodrai@linux.dev,
puranjay@kernel.org, rlmenge@gmail.com, hargar@microsoft.com,
apais@microsoft.com, martin.lau@kernel.org, mason@kernel.org
Subject: Re: [PATCH bpf-next v2 1/2] bpf: allow terminal gotox instructions
Date: Tue, 1 Sep 2026 13:51:30 +0000 [thread overview]
Message-ID: <apbYYiTCT8w6a4MF@mail.gmail.com> (raw)
In-Reply-To: <08bc375fdf3ed6ec599f4f9a8b220f46d8d485a2c8420531f081797b33cf1296@mail.kernel.org>
On 26/08/31 11:26PM, bot+bpf-ci@kernel.org wrote:
> > bpf: allow terminal gotox instructions
>
> This isn't a bug, but Anton Protopopov requested capitalizing "allow" in
> the commit title when he provided his Reviewed-by tag. Should this be
> "bpf: Allow terminal gotox instructions"?
+1
>
> > diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c
> > index 8f585ceb2cd51..483473df7746c 100644
> > --- a/kernel/bpf/verifier.c
> > +++ b/kernel/bpf/verifier.c
>
> [ ... ]
>
> > @@ -3107,7 +3109,8 @@ static int check_subprogs(struct bpf_verifier_env *env)
> > if (i == subprog_end - 1) {
> > /* to avoid fall-through from one subprog into another
> > * the last insn of the subprog should be either exit
> > * or unconditional jump back or bpf_throw call
> > */
> > if (code != (BPF_JMP | BPF_EXIT) &&
> > code != (BPF_JMP32 | BPF_JA) &&
> > - code != (BPF_JMP | BPF_JA)) {
> > + code != (BPF_JMP | BPF_JA) &&
> > + !insn_is_gotox(&insn[i])) {
>
> This isn't a bug, but would it be worth extending the comment above this
> condition to mention gotox, since the accepted-terminator list right
> below it now has a fourth entry?
I would ignore this, indirect jumps are unconditional as well
>
> ---
> AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
> See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
>
> CI run summary: https://github.com/kernel-patches/bpf/actions/runs/33447655511
prev parent reply other threads:[~2026-09-01 13:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-31 22:33 [PATCH bpf-next v2 1/2] bpf: allow terminal gotox instructions Siddharth Chintamaneni
2026-08-31 22:33 ` [PATCH bpf-next v2 2/2] selftests/bpf: Test " Siddharth Chintamaneni
2026-08-31 23:26 ` bot+bpf-ci
2026-09-01 13:58 ` Anton Protopopov
2026-09-01 16:21 ` Siddharth Chintamaneni
2026-08-31 23:26 ` [PATCH bpf-next v2 1/2] bpf: allow " bot+bpf-ci
2026-09-01 13:51 ` Anton Protopopov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apbYYiTCT8w6a4MF@mail.gmail.com \
--to=a.s.protopopov@gmail.com \
--cc=andrii@kernel.org \
--cc=apais@microsoft.com \
--cc=ast@kernel.org \
--cc=bot+bpf-ci@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=hargar@microsoft.com \
--cc=ihor.solodrai@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=martin.lau@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mason@kernel.org \
--cc=memxor@gmail.com \
--cc=puranjay@kernel.org \
--cc=rlmenge@gmail.com \
--cc=sidchintamaneni@gmail.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox