From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk2-f42.google.com (mail-qk2-f42.google.com [74.125.230.234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E411C411A08 for ; Thu, 24 Sep 2026 17:17:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.230.234 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790270254; cv=none; b=sfOTOWbpyOZaikiyK+HtFKJbH/D5QooSjjh1sWTW/YXNU+9by2uMubQLxP0GiWH0jAfPiT0RCa9tzVlI3cJWsv0nhj1/dROhryQY3wsVrJAchqD2Hrxetu8akcDSBkkZbgsVejxYWw+DASffTUiu38DQL1GkpD8GH0pwvhDU0S8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790270254; c=relaxed/simple; bh=N9G2xDWLJkhjpVHjPudlC9eB56JQvy0Q3UFpvQ70GnM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kW/jTB9MLNEwbYTxidsqZaovFyr0CwnL61kvTRWs/q/JuVy+jMjaJs68XS+F2qOvos5GasjlhGMtnpfQDH0QJNFQfXTRM3CTKzR5AEnMB9d0D/kr5vsJDF6B6t8ucX2WR+OXdlmNOOLkss1Hf/EvaeKwWItBn+CFKRb+Dxdny5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=tprV5yBU; arc=none smtp.client-ip=74.125.230.234 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="tprV5yBU" Received: by mail-qk2-f42.google.com with SMTP id d75a77b69052e-52fb76bcb1eso559501cf.3 for ; Thu, 24 Sep 2026 10:17:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1790270251; x=1790875051; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=feTLx7y3sxZ57LB+c+M8YbdddVhljMzyHzPRAu6TpA4=; b=tprV5yBUII/qRzLyqKPdJDICtcHMIXdxXt3R1PhRppTAqbBmNEs7Uqtgc/IauT7bas 6q+btZ6riiYDfPxMNxJ9LlKIzVy4E/rMZS8FF2kWFWhC/RTZ0m/dLDIeIJEc6DmgUeKW rRe5l+D4Gb5EgFoh0bNUVpRhgcRfueygz54BCmywUEAofeJDIrYo8R8bOOlnVVhbm8Xx 8y1PvkD+okpXc2BYxVcdIyuBwaEwabsdPE+xSDWc5coaNizNqVaWAFRlWZ+CHrBLXEHc +ibea7n8Gc0GPrQRe/RTIUKy7LATsQy5mAZvm52IfaGHNyUnZEVBqjo1InS2m+tWjzj5 xc4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790270251; x=1790875051; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=feTLx7y3sxZ57LB+c+M8YbdddVhljMzyHzPRAu6TpA4=; b=MUsqXkktF/S26qxz4/37Jr1FqWgVpndhDBOluFD17t8enmwvk7/RhjJkOjIo4X4V34 yr8uOntvRbX8wkyAQS5NgUVIGMrhEbDi20zg9iMwnBuNNZli+ZpvoHkKf2xeykekZJi6 Onuw6QfnaoajEX58md8C2d2/0evKsCxPMGf/PD5Bj5dOdyiCfFVArsRulZeAFY3KPfi/ 89ASLKksksonWZ5kBTFjriz7WP/Ko5OTzTVitTP32yfW7GhsN+7/DRp7oNkQjJv5Xhww 9UdQYzwHbMbguLZiI1eROEE6HA0bNDqWIWusomEqIBgF3WEpXKtiIg3d1NRNzL+l+MCh YUdg== X-Forwarded-Encrypted: i=1; AKwUvBzon8idkNj/Mi3ps/aLVcGwr2f4nEV35YLmy4bD22SxigjpfECDiMhrJ0QNbzDqxD4dM5w=@vger.kernel.org X-Gm-Message-State: AFuF++lNwm8Kr9Kl3mkgRtRyGsiN7pKKWw9GyEjPP8kF54bDZw0bsoQD 1kO0T9wtaFLx60hy2ECN4Ij2JU2JTL6H2aOtD2tvXMYR5jC0KJW8k8SQt5gOOFJAozw= X-Gm-Gg: AYBFou0k60kFnTlqGlT7mi5lrgL1U7Ms7OPFP4sQwQklUZAiFliy7ip7/wc7CC27R6O bzQCfiU75cVyhqsNG0r6BHkV1Fx8OYI6zAcMZyysYI/1bsIEX+J97Lz1PeWqz42bmwGmq1b99Dc Wt4p/LvG/FIEK1di0/of4SctysJSMtP3BCrOtV2T5uhybrWA9jSIsTOK3C4BgnZrBAMDQa4mOqW 81MfnXJUqBn5OtGmeaD3Aanb6Jk3xzbnkY7S/wHDvvsy3LJaeRkWE8owoEBIR6oex06oMw+PLUB xIbl7XXDWen6Ez6RnEofEr8umxO7sDObNv4pZDx5GPea6PGO8RN32czByLg3Hgeq++/+H/Szd4q 1ZCHDIN3QVb4fpc0bubknQ5zsmAFebEqaLhn8Q97AvhDsNr27Sq6Vb7P9wzq0xdT1UuscWY5VPe Ti+SBPC4k8AkRTVeB8rieGx0rmJwLKgwiL3PTxNBUqGCsdtvfPDpDBvaCbrCW6IvYvFsSaBqs+u KU67NqCakEd8Zfy768FHAsVI5BpPdhm9lbDZ/moNyGA7Anl8EHiQHc= X-Received: by 2002:a05:622a:2b05:b0:530:42e4:f001 with SMTP id d75a77b69052e-532feb3025amr31555731cf.46.1790270250746; Thu, 24 Sep 2026 10:17:30 -0700 (PDT) Received: from gourry-fedora-PF4VCD3F (pool-173-79-60-52.washdc.fios.verizon.net. [173.79.60.52]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-532f8b7174asm25743881cf.14.2026.09.24.10.17.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Sep 2026 10:17:30 -0700 (PDT) Date: Thu, 24 Sep 2026 13:17:28 -0400 From: Gregory Price To: "Lorenzo Stoakes (ARM)" Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-usb@vger.kernel.org, linux-rdma@vger.kernel.org, selinux@vger.kernel.org, linux-sound@vger.kernel.org, bpf@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, fuse-devel@lists.linux.dev Subject: Re: [PATCH v3 04/40] mm: consistently validate VMA state after mmap[_prepare] hooks Message-ID: References: <20260917-b4-mmap-prepare-vma-flag-sanify-v3-0-4583d8a23bca@kernel.org> <20260917-b4-mmap-prepare-vma-flag-sanify-v3-4-4583d8a23bca@kernel.org> Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260917-b4-mmap-prepare-vma-flag-sanify-v3-4-4583d8a23bca@kernel.org> On Thu, Sep 17, 2026 at 05:22:13PM +0100, Lorenzo Stoakes (ARM) wrote: > static inline int mmap_file(struct file *file, struct vm_area_struct *vma) > { ... > + err = mmap_hook_validate(prev_start, prev_end, &prev_flags, vma); > + if (unlikely(err)) { > + vma->vm_start = prev_start; > + vma->vm_end = prev_end; > + vma_close(vma); > } > + > + return err; > } > I indepdeantly validated the sashiko report on this chunk. Seems like close() should be deferred until after __map_new_file_vma() calls unmap_region(). suggested fix is to drop vma_close() from mmap_file() and update the cleanup in __mmap_new_file_vma() if (error) { UNMAP_STATE(unmap, vmi, vma, vma->vm_start, vma->vm_end, map->prev, map->next); vma_iter_set(vmi, vma->vm_end); unmap_region(&unmap); /* Release driver state only after its mappings are gone. */ vma_close(vma); if (map_same_file(map)) fput(map->vm_file); vma->vm_file = NULL; return error; } Example race: Thread A Thread B mmap(MAP_FIXED, address A) driver remap_pfn_range(A, page P) load/store at known address A hardware finds the new present PTE validation fails ->close() frees page P UAF unmap_region() TLB shootdown With that fix Reviewed-by: Gregory Price (Meta) ~Gregory