Re: [PATCH v5 dwarves 05/10] pahole: Support inline BTF location encoding

[Jiri Olsa <olsajiri@gmail.com>]

On Fri, Oct 02, 2026 at 06:40:33PM +0100, Alan Maguire wrote:

SNIP

> +static int btf_encoder__add_inline_expansion(struct btf_encoder *encoder,
> +					     struct inline_expansion *ie)
> +{
> +	struct ftype *ftype;
> +	struct loc *loc;
> +	struct parameter *param;
> +	uint32_t section_idx, section_offset;
> +	int err;
> +
> +	if (!ie->function || !ie->name ||
> +	    !btf_encoder__inline_addr_to_section(encoder, ie->ip.addr,
> +						 &section_idx, &section_offset))
> +		return 0;

hi,
we get inline locations also from .init.text, which then fail kprobe
address validation.. is there some usecase for keeping .init.text
locations?

I currently disable them in kprobe_multi change I have on top of this,
but I wonder we could just drop them completely in here with something
like:

	if (strstarts(encoder->secinfo[section_idx].name, ".init"))
		return 0;

thanks,
jirka


> +	ftype = &ie->function->proto;
> +	loc = calloc(1, sizeof(*loc));
> +	if (!loc)
> +		return -ENOMEM;
> +	loc->name = strdup(ie->name);
> +	if (!loc->name) {
> +		err = -ENOMEM;
> +		goto out;
> +	}
> +	loc->section_idx = section_idx;
> +	loc->section_offset = section_offset;
> +	loc->nparams = ftype->nr_parms + (ftype->unspec_parms ? 1 : 0);
> +	loc->params = calloc(loc->nparams ? loc->nparams : 1, sizeof(*loc->params));
> +	if (!loc->params) {
> +		err = -ENOMEM;
> +		goto out;
> +	}
> +	inline_expansion__for_each_parameter(ie, param) {
> +		if (param->idx < loc->nparams)
> +			btf_encoder__add_loc_param(param, encoder->addr_base,
> +						   &loc->params[param->idx]);
> +	}
> +	err = btf_encoder__save_func(encoder, ie->function, NULL, loc);
> +	loc = NULL; /* save_func owns loc after this point, including on error */
> +	if (!err)
> +		return 0;
> +out:
> +	loc__delete(loc);
> +	return err;
> +}
> +

SNIP