From: Jiri Olsa <olsajiri@gmail.com>
To: bot+bpf-ci@kernel.org
Cc: ast@kernel.org, daniel@iogearbox.net, bpf@vger.kernel.org,
linux-mm@kvack.org, andrii@kernel.org, eddyz87@gmail.com,
memxor@gmail.com, ljs@kernel.org, john.fastabend@gmail.com,
nierro92@gmail.com, martin.lau@kernel.org,
yonghong.song@linux.dev, mason@kernel.org,
ihor.solodrai@linux.dev
Subject: Re: [PATCH bpf-next 8/8] selftests/bpf: Test user memory kfunc errors
Date: Fri, 30 Oct 2026 14:08:30 +0100 [thread overview]
Message-ID: <auSWzm7W1SiQN0Ul@krava> (raw)
In-Reply-To: <d023b011d67ae13695a93c94ae0197e96fb5d42bbc3a4a63b42fcd0c1852a605@mail.kernel.org>
On Thu, Oct 29, 2026 at 09:59:33PM +0000, bot+bpf-ci@kernel.org wrote:
> > selftests/bpf: Test user memory kfunc errors
>
> TL;DR: Commit message only: it claims tests for partial copy faults and
> read-only mappings that were added by the previous patch, and omits the new
> RUN_TESTS(user_mem) verifier-failure tests.
>
> > selftests/bpf: Test user memory kfunc errors
> >
> > Test invalid copy arguments, zero-length mapping operations, partial copy
> > faults, and copying to read-only mappings. Verify that a failed unmap
> > leaves the mapping intact, and that non-sleepable programs and programs
> > without CAP_SYS_ADMIN cannot call bpf_user_mmap.
> >
> > Assisted-by: Codex:GPT-6
> > Signed-off-by: Jiri Olsa <jolsa@kernel.org>
>
> The changelog says this commit tests "partial copy faults, and copying to
> read-only mappings". Is that accurate for this patch?
>
> test_partial_copy_fault() and test_copy_to_readonly_mapping() were added by
> the previous commit 8f0bac0f80cd ("selftests/bpf: Test bpf_copy_to_user
> kfunc"), whose changelog already describes them, and this diff does not touch
> them.
>
> What this diff adds is test_zero_length_mapping(), test_failed_unmap(),
> test_invalid_copy(), the three verifier-failure programs
> (user_mem_nonsleepable, user_mem_kprobe and user_mem_no_sysadmin), and the
> RUN_TESTS(user_mem) call that runs them.
>
> The changelog also does not mention RUN_TESTS(user_mem), which turns the
> existing user_mem_test program into a privileged load-only subtest.
>
> Could the changelog be reworded to describe what this patch adds?
yep, will fix
jirka
prev parent reply other threads:[~2026-10-30 13:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 21:25 [PATCH bpf-next 0/8] bpf: Add user memory kfuncs Jiri Olsa
2026-10-29 21:25 ` [PATCH bpf-next 1/8] bpf: Add __srcptr kfunc argument suffix Jiri Olsa
2026-10-29 21:49 ` Andrii Nakryiko
2026-10-30 10:50 ` Jiri Olsa
2026-10-30 16:26 ` Alexei Starovoitov
2026-10-29 21:25 ` [PATCH bpf-next 2/8] bpf: Add user memory kfuncs Jiri Olsa
2026-10-29 22:00 ` Andrii Nakryiko
2026-10-30 11:08 ` Jiri Olsa
2026-10-29 22:12 ` bot+bpf-ci
2026-10-30 13:07 ` Jiri Olsa
2026-10-30 13:08 ` Jiri Olsa
2026-10-29 21:25 ` [PATCH bpf-next 3/8] selftests/bpf: Add get_procmap_info helper Jiri Olsa
2026-10-29 21:25 ` [PATCH bpf-next 4/8] selftests/bpf: Test __srcptr kfunc arguments Jiri Olsa
2026-10-29 21:25 ` [PATCH bpf-next 5/8] selftests/bpf: Test user memory mmap kfuncs Jiri Olsa
2026-10-29 21:59 ` bot+bpf-ci
2026-10-30 13:08 ` Jiri Olsa
2026-10-29 21:25 ` [PATCH bpf-next 6/8] selftests/bpf: Test user memory page exec Jiri Olsa
2026-10-29 21:25 ` [PATCH bpf-next 7/8] selftests/bpf: Test bpf_copy_to_user kfunc Jiri Olsa
2026-10-29 21:25 ` [PATCH bpf-next 8/8] selftests/bpf: Test user memory kfunc errors Jiri Olsa
2026-10-29 21:59 ` bot+bpf-ci
2026-10-30 13:08 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=auSWzm7W1SiQN0Ul@krava \
--to=olsajiri@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bot+bpf-ci@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=ihor.solodrai@linux.dev \
--cc=john.fastabend@gmail.com \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=martin.lau@kernel.org \
--cc=mason@kernel.org \
--cc=memxor@gmail.com \
--cc=nierro92@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox