From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=217.74.67.63 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795010148; b=KLAAa6MEh6IIF/YrUVxjhhkh6Ohy3Sfdyluv6uvIgndKVuYoK56u1b8FTt+1Y1u5Qeze w+km4Jw1Mlvr4+fvqwov5ggg8chdcY9WRgtipYMn9p+4sScMx71izQl0rZuYUfa1lz2x5 IVaIsmeu47ntKbYJb4gjsBaGc6R0HEYTB6aY5+T0dnEXHOgwgprKrtdAIeEoruhEp/Bc5 rGiaMtgInmRohHBO8Dwai1BWgFPIyd3s/9HyaPA1ULG2JY9DCSdZtTg4jIX8jsNo2UmTA 5sRrx0VV1FMxdIQKnhX757KYVyh/EhbgOVSBskf08hvce82jMSBAIt6H3mlA6aIG8cA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795010148; h=DMARC-Filter:Received:Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:Content-Disposition:In-Reply-To: DKIM-Signature; bh=Ogx7B9wYG+j6Vq592flq68qRXyFMeckjKevPe2O6vnI=; b=cGXY3pMEiPNccvkZKfr7TWcv3tpnXET7w5Qq5jgzQnWhfjP+XlJdd5MUPR+6HV1L/Ii7 +i6xg23PVbhagd8irqn2qyrJGgZV/TkWxKPrXZNngCPlejvoDws4Xe2gQNSEAo6qjDo33 cotjtMmZv0ZL3xqyBDDGiS0EYkdJi63SWSu6kX/sJGgjNiYzZK9qxprY4Pjjx9FOtpTlm vMIcD8atv6chQzJky2u+G9PDKqS8U3xKPmHbna2ObQs13gy+6Zrdgh71zZwRe0ae+y/gv SI/5BqaOZkYQfS0xpyantPhp7CVoapIrvuIkRNg8Oem/rnthU5hZwVkG7t7PrzWSWvw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=poczta.fm; spf=pass smtp.mailfrom=poczta.fm; dkim=pass header.d=poczta.fm header.i=@poczta.fm header.a=rsa-sha256 header.s=dk header.b=uyvMz5ao; arc=none smtp.remote-ip=217.74.67.63 Received: from smtpo63.interia.pl (smtpo63.interia.pl [217.74.67.63]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE4F3606A32F for ; Wed, 18 Nov 2026 13:55:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org DE4F3606A32F Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=poczta.fm Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=poczta.fm Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=poczta.fm header.i=@poczta.fm header.a=rsa-sha256 header.s=dk header.b=uyvMz5ao Received: from nr200 (unknown [80.68.231.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by poczta.interia.pl (INTERIA.PL) with ESMTPSA; Wed, 18 Nov 2026 14:55:37 +0100 (CET) Date: Wed, 18 Nov 2026 14:55:35 +0100 From: Slawomir Stepien To: Jesper Dangaard Brouer , Maciej Fijalkowski Cc: ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net, kuba@kernel.org, john.fastabend@gmail.com, sdf@fomichev.me, netdev@vger.kernel.org, bpf@vger.kernel.org, magnus.karlsson@intel.com, aleksander.lobakin@intel.com, ilias.apalodimas@linaro.org, toke@redhat.com, lorenzo@kernel.org, ihor.solodrai@linux.dev, tavip@google.com, Tianyi Gao Subject: Re: [PATCH v6 bpf 0/3] xdp: fix page_pool leaks Message-ID: References: <20261104121316.1155680-1-sst@poczta.fm> <833b2ebf-ac7c-42b1-bb75-2fc56e0f0fbe@kernel.org> X-Mailing-List: bpf@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <833b2ebf-ac7c-42b1-bb75-2fc56e0f0fbe@kernel.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=poczta.fm; s=dk; t=1795010139; bh=Ogx7B9wYG+j6Vq592flq68qRXyFMeckjKevPe2O6vnI=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=uyvMz5aom9duPGcsEm7UNdWyCC17IvZdWUZ2oxosnGEXQ85vrhuFQFgThYCCXn3k5 Rmt20U3Cn8awhBOSuUc1HnI9Qb5L9ndyAUfX92M70QwxUyRkF1D6gGLfDhOLMBbLs+ FjDgIWQvxa7ullvakUA9vF1vx8U6aMpfz3F3GF3A= On lis 05, 2026 10:59, Jesper Dangaard Brouer wrote: > On 11/5/26 09:17, Slawomir Stepien wrote: > > On lis 04, 2026 13:44, Maciej Fijalkowski wrote: > > > On Wed, Nov 04, 2026 at 01:13:13PM +0100, Slawomir Stepien wrote: > > > > v1: > > > > https://lore.kernel.org/bpf/20251003140243.2534865-1-maciej.fijalkowski@intel.com/ > > > > v1->v2: > > > > - add skb to xdp_buff converter (Jakub) > > > > - postpone restoration of veth's xdp_rxq_info mem model (AI) > > > > > > > > v2: > > > > https://lore.kernel.org/bpf/20251017143103.2620164-1-maciej.fijalkowski@intel.com/T/ > > > > v2->v3: > > > > - make skb->xdp_buff conversion agnostic of current skb->data position > > > > (Toke) > > > > - do not pull mac header in veth (Toke) > > > > - use virt_to_head_page() when checking if xdp->data comes from > > > > page_pool (Olek) > > > > - add ack from Toke > > > > > > > > v3: > > > > https://lore.kernel.org/bpf/20251022125209.2649287-1-maciej.fijalkowski@intel.com/ > > > > v3->v4: > > > > - include skb->head when calculating packet length (Toke, lkp) > > > > > > > > v4: > > > > https://lore.kernel.org/bpf/20251027121318.2679226-1-maciej.fijalkowski@intel.com/ > > > > v4->v5: > > > > - rely again on sk_buff::pp_recycle when setting mem type on rxq > > > > (Jesper, Jakub) > > > > - add ack from Toke on patch 2 and restore it on patch 1 > > > > > > > > v5: > > > > https://lore.kernel.org/bpf/20251029221315.2694841-1-maciej.fijalkowski@intel.com/ > > > > v5->v6: > > > > - rebase onto bpf/master > > > > - patch 1: set MEM_TYPE_PAGE_POOL unconditionally in > > > > xdp_convert_skb_to_buff(); mem type only matters for frags consumed > > > > by the program, and those always come from skb_pp_cow_data() (Jakub) > > > > - patch 1: add DEBUG_NET_WARN_ON_ONCE() for a non-linear skb without > > > > pp_recycle and document the expectation in kdoc (Jakub); the warning > > > > is limited to non-linear skbs since linear ones legitimately skip > > > > the CoW > > > > - new patch 2: veth_xdp_rcv_one() ran the program on an xdp_frame with > > > > whatever mem type the previous packet left on rq->xdp_rxq; use the > > > > frame's mem type instead, as cpumap and devmap do. With patch 3 alone > > > > veth sends page_pool frames to its peer and the peer's program > > > > trimming frags crashed the kernel, so this comes first > > > > - patch 3 (was 2): veth turns the buff into an xdp_frame on > > > > XDP_{TX,REDIRECT}, so the head is released through mem type too; > > > > keep the queue's original model unless the buffer was copied into > > > > rq->page_pool (Jakub) > > > > - patch 3: take page_pool refs on compound heads via netmem helpers > > > > - patch 3: do not restore the rxq mem model after XDP_{TX,REDIRECT} > > > > and on the error path; with patch 2 every path sets its own mem type > > > > - patch 3: veth can now redirect MEM_TYPE_PAGE_POOL frames, which needs > > > > commit b3ca872947ef ("bpf: Use the frame mem type in devmap egress > > > > XDP") in devmap; list it as a stable prerequisite > > > > - drop Reviewed-by/Tested-by tags as patches 1 and 3 changed > > > > > > I mentioned the changes [0] that were developed after v5 revision yet you > > > decided to go with what you had - that might be okay but to be transparent > > > it would be worth stating *why* you chose not to pursue further or explore > > > approach where __do_xdp_generic() is called from veth. > > > > > > Was it due to semantics change pointed out by Bjorn? Or is it too big a > > > hammer for fixing page_pool leaks and should be implemented as a > > > follow-up? > > > > That. For me, at this point in time it is easier to reason about the fix first rather than refactor. > > > > I like approach where __do_xdp_generic() is called from veth. > Look at patch link[0] below - how much (ugly) code is removed from veth.c > > > > Regardless, thank you for reviving this work, I am to blame for not > > > dedicating further effort here. > > > > No worries Maciej! You did a great job and I think it is worth pushing. > > > > > [0]: https://lore.kernel.org/bpf/20260509084858.773921-5-maciej.fijalkowski@intel.com/ > > > > I like how much code this [0] patch removes. Especially removing the > ugly veth_xdp_get() function that manipulate the refcnt directly on pages. Hi Jesper and Maciej I know that the RFC from [0] is doing a lot of nice things, but after working on v3 of it, I still see some regression. I was able to fix some (v3 will have the additional PATCHes), but more work is still needed (or more discussion is need about how to approach this regression removal). That is why I would like to keep this fix still alive and I will send v7 soon. I will also send RFC v3 - as a place where more discussion can take place on the direction of that refactor. -- Slawomir Stepien