From: Jarkko Sakkinen <jarkko@kernel.org>
To: sashiko-reviews@lists.linux.dev
Cc: David Howells <dhowells@redhat.com>,
bpf@vger.kernel.org, dm-devel@lists.linux.dev,
fsverity@lists.linux.dev, keyrings@vger.kernel.org,
linux-security-module@vger.kernel.org,
Alasdair Kergon <agk@redhat.com>,
Alexei Starovoitov <ast@kernel.org>, Alex Shi <alexs@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andrii Nakryiko <andrii@kernel.org>,
Benjamin Marzinski <bmarzins@redhat.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Dongliang Mu <dzm91@hust.edu.cn>,
Eduard Zingerman <eddyz87@gmail.com>,
Emil Tsalapatis <emil@etsalapatis.com>,
Eric Biggers <ebiggers@kernel.org>,
Ignat Korchagin <ignat@linux.win>,
Ihor Solodrai <ihor.solodrai@linux.dev>,
James Morris <jmorris@namei.org>, Jiri Olsa <jolsa@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Martin KaFai Lau <martin.lau@linux.dev>,
Mike Snitzer <snitzer@kernel.org>,
Mikulas Patocka <mpatocka@redhat.com>,
Paul Moore <paul@paul-moore.com>,
Randy Dunlap <rdunlap@infradead.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Song Liu <song@kernel.org>, "Theodore Y. Ts'o" <tytso@mit.edu>,
Yanteng Si <si.yanteng@linux.dev>,
Yonghong Song <yonghong.song@linux.dev>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH v7 2/3] KEYS: Replace assoc_array with rhashtable
Date: Tue, 10 Nov 2026 06:11:36 +0200 [thread overview]
Message-ID: <avKZeB9VH0cavfr4@kernel.org> (raw)
In-Reply-To: <sashiko-outbox-206155@kernel.org>
On Tue, Nov 10, 2026 at 03:56:03AM +0000, sashiko-bot@kernel.org wrote:
> [Severity: Medium]
> As reported by Eric Biggers on v5 [1], should keyring_link_params set
> .insecure_elasticity = true instead of looping on -EBUSY here?
>
> Without .insecure_elasticity, rhashtable_insert_fast() enforces the
> 16-entry bucket chain limit (RHT_ELASTICITY) and returns -EBUSY to trigger
> a rehash. Because keyring_obj_hashfn() only hashes the 32-bit link->hash
> via jhash_1word(), entries with colliding 32-bit SipHash digests cannot be
> split by rehashing with a new seed, so __key_link_begin() can spin
> indefinitely in this loop while holding keyring->sem. This was fixed in
> v6 by setting .insecure_elasticity = true and dropping the retry loop, but
> appears to have been lost in v7.
Ugh, I fixed this already.
Clearly something went wrong with the rebase :-/
I'll manually apply v6 patches and send v8.
I honestly don't know what happened (likely the branch was not up to
date in the first place). Sorry.
Br, Jarkko
next prev parent reply other threads:[~2026-11-10 4:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-10 3:37 [PATCH v7 0/3] KEYS: Replace assoc_array with rhashtable Jarkko Sakkinen
2026-11-10 3:37 ` [PATCH v7 1/3] KEYS: Introduce keyring_is_empty() Jarkko Sakkinen
2026-11-10 3:37 ` [PATCH v7 2/3] KEYS: Replace assoc_array with rhashtable Jarkko Sakkinen
2026-11-10 3:56 ` sashiko-bot
2026-11-10 4:11 ` Jarkko Sakkinen [this message]
2026-11-10 3:37 ` [PATCH v7 3/3] lib: Remove assoc_array Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=avKZeB9VH0cavfr4@kernel.org \
--to=jarkko@kernel.org \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=alexs@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bmarzins@redhat.com \
--cc=bpf@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=daniel@iogearbox.net \
--cc=dhowells@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=dzm91@hust.edu.cn \
--cc=ebiggers@kernel.org \
--cc=eddyz87@gmail.com \
--cc=emil@etsalapatis.com \
--cc=fsverity@lists.linux.dev \
--cc=ignat@linux.win \
--cc=ihor.solodrai@linux.dev \
--cc=jmorris@namei.org \
--cc=jolsa@kernel.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=mpatocka@redhat.com \
--cc=paul@paul-moore.com \
--cc=rdunlap@infradead.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=serge@hallyn.com \
--cc=si.yanteng@linux.dev \
--cc=skhan@linuxfoundation.org \
--cc=snitzer@kernel.org \
--cc=song@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox