From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E6D6F803; Mon, 8 Jul 2024 02:36:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720406189; cv=none; b=ChqUmXFFuTF8SECGlxzBkOjS4nKDQ0byBQqKaZ6pkEIkWEn9hR92ABx4IePGZ2IpODfc7sh3a5DkJFQw5Vq53B244ComJne4e6SYEnKW58s8sCwo9Az7XS3vsG6w+G48LNobkV1+lOrauvdRRlQNjvhwUOM/yaNvb+7d0JSTD6s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720406189; c=relaxed/simple; bh=nTAvQZ89uE71cApYup/pCqbVjP0YZ60Aayd0dTkMo74=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Yn+4Re4N0X7d6fr98v2MFeS/UghcRWnmK/SmtCYx67ZQJF2E0qSJ2/y5Bcnr0tpNszks9xmIGT+g83B32yEUPvF01ojtLGJAzjbtKikSUJ4/4L7TUNwONc4Rn/gbZ38Msud1V+1U+A2solVUpRh9ZZ01fNw/S24MUDDQSGBkmjU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=RKih7AnC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="RKih7AnC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 562DBC4AF07; Mon, 8 Jul 2024 02:36:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720406188; bh=nTAvQZ89uE71cApYup/pCqbVjP0YZ60Aayd0dTkMo74=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=RKih7AnC92A0BTGwX7vTB6d8IN6oaAt0vLnmo6RsWAqMsbJ/S4A25jdmeMEjYp6OQ s1uQN6yGTrl3jHggYmM06jnjccE08vZJ1TlzS0Svy6PE+slIXEyJ3duuSk1+vz+I/1 0F4z7ntC4uvGTKAudEF+aZ9VGmbvJjY572wRFbMas+vXqL6zotBN309yMtvqLgUAE/ TI4gM08RKLyW7IgWJsE5F6nj3DikGgQTPW6Sr8D/40UZYgruZ/TkVTrI+FEgynmmlu CdthrGxa+naFHWXxyWdkKa7KDxaTe74Vut67XN6CRx6MJ4LmkU0Ol8A72R+kOTGpNO 12FI/03gqHL/w== Message-ID: Subject: Re: [PATCH bpf-next v9 00/11] use network helpers, part 8 From: Geliang Tang To: Andrii Nakryiko , Eduard Zingerman , Mykola Lysenko , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan Cc: Geliang Tang , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org Date: Mon, 08 Jul 2024 10:36:19 +0800 In-Reply-To: References: Autocrypt: addr=geliang@kernel.org; prefer-encrypt=mutual; keydata=mQINBGWKTg4BEAC/Subk93zbjSYPahLCGMgjylhY/s/R2ebALGJFp13MPZ9qWlbVC8O+X lU/4reZtYKQ715MWe5CwJGPyTACILENuXY0FyVyjp/jl2u6XYnpuhw1ugHMLNJ5vbuwkc1I29nNe8 wwjyafN5RQV0AXhKdvofSIryqm0GIHIH/+4bTSh5aB6mvsrjUusB5MnNYU4oDv2L8MBJStqPAQRLl P9BWcKKA7T9SrlgAr0VsFLIOkKOQPVTCnYxn7gfKogH52nkPAFqNofVB6AVWBpr0RTY7OnXRBMInM HcjVG4I/NFn8Cc7oaGaWHqX/yHAufJKUsldieQVFd7C/SI8jCUXdkZxR0Tkp0EUzkRc/TS1VwWHav 0x3oLSy/LGHfRaIC/MqdGVqgCnm6wapUt7f/JHloyIyKJBGBuHCLMpN6n/kNkSCzyZKV7h6Vw1OL5 18p0U3Optyakoh95KiJsKzcd3At/eftQGlNn5WDflHV1+oMdW2sRgfVDPrYeEcYI5IkTc3LRO6ucp VCm9/+poZSHSXMI/oJ6iXMJE8k3/aQz+EEjvc2z0p9aASJPzx0XTTC4lciTvGj62z62rGUlmEIvU2 3wWH37K2EBNoq+4Y0AZsSvMzM+CcTo25hgPaju1/A8ErZsLhP7IyFT17ARj/Et0G46JRsbdlVJ/Pv X+XIOc2mpqx/QARAQABtCVHZWxpYW5nIFRhbmcgPGdlbGlhbmcudGFuZ0BsaW51eC5kZXY+iQJUBB MBCgA+FiEEZiKd+VhdGdcosBcafnvtNTGKqCkFAmWKTg4CGwMFCRLMAwAFCwkIBwIGFQoJCAsCBBY CAwECHgECF4AACgkQfnvtNTGKqCmS+A/9Fec0xGLcrHlpCooiCnNH0RsXOVPsXRp2xQiaOV4vMsvh G5AHaQLb3v0cUr5JpfzMzNpEkaBQ/Y8Oj5hFOORhTyCZD8tY1aROs8WvbxqvbGXHnyVwqy7AdWelP +0lC0DZW0kPQLeel8XvLnm9Wm3syZgRGxiM/J7PqVcjujUb6SlwfcE3b2opvsHW9AkBNK7v8wGIcm BA3pS1O0/anP/xD5s5L7LIMADVB9MqQdeLdFU+FFdafmKSmcP9A2qKHAvPBUuQo3xoBOZR3DMqXIP kNCBfQGkAx5tm1XYli1u3r5tp5QCRbY5LSkntMNJJh0eWLU8I+zF6NWhqNhHYRD3zc1tiXlG5E0ob pX02Dy25SE2zB3abCRdAK30nCI4lMyMCcyaeFqvf6uhiugLiuEPRRRdJDWICOLw6KOFmxWmue1F71 k08nj5PQMWQUX3X2K6jiOuoodYwnie/9NsH3DBHIVzVPWASFd6JkZ21i9Ng4ie+iQAveRTCeCCF6V RORJR0R8d7mI9+1eqhNeKzs21gQPVf/KBEIpwPFDjOdTwS/AEQQyhB+5ALeYpNgfKl2p30C20VRfJ GBaTc4ReUXh9xbUx5OliV69iq9nIVIyculTUsbrZX81Gz6UlbuSzWc4JclWtXf8/QcOK31wputde7 Fl1BTSR4eWJcbE5Iz2yzgQu0IUdlbGlhbmcgVGFuZyA8Z2VsaWFuZ0BrZXJuZWwub3JnPokCVAQTA QoAPhYhBGYinflYXRnXKLAXGn577TUxiqgpBQJlqclXAhsDBQkSzAMABQsJCAcCBhUKCQgLAgQWAg MBAh4BAheAAAoJEH577TUxiqgpaGkP/3+VDnbu3HhZvQJYw9a5Ob/+z7WfX4lCMjUvVz6AAiM2atD yyUoDIv0fkDDUKvqoU9BLU93oiPjVzaR48a1/LZ+RBE2mzPhZF201267XLMFBylb4dyQZxqbAsEhV c9VdjXd4pHYiRTSAUqKqyamh/geIIpJz/cCcDLvX4sM/Zjwt/iQdvCJ2eBzunMfouzryFwLGcOXzx OwZRMOBgVuXrjGVB52kYu1+K90DtclewEgvzWmS9d057CJztJZMXzvHfFAQMgJC7DX4paYt49pNvh cqLKMGNLPsX06OR4G+4ai0JTTzIlwVJXuo+uZRFQyuOaSmlSjEsiQ/WsGdhILldV35RiFKe/ojQNd 4B4zREBe3xT+Sf5keyAmO/TG14tIOCoGJarkGImGgYltTTTM6rIk/wwo9FWshgKAmQyEEiSzHTSnX cGbalD3Do89YRmdG+5eP7HQfsG+VWdn8IH6qgIvSt8GOw6RfSP7omMXvXji1VrbWG4LOFYcsKTN+d GDhl8LmU0y44HejkCzYj/b28MvNTiRVfucrmZMGgI8L5A4ZwQ3Inv7jY13GZSvTb7PQIbqMcb1P3S qWJFodSwBg9oSw21b+T3aYG3z3MRCDXDlZAJONELx32rPMdBva8k+8L+K8gc7uNVH4jkMPkP9jPnV Px+2P2cKc7LXXedb/qQ3MuQINBGWKTg4BEADJxiOtR4SC7EHrUDVkp/pJCQC2wxNVEiJOas/q7H62 BTSjXnXDc8yamb+HDO+Sncg9SrSRaXIh+bw9G3rvOiC2aQKB6EyIWKMcuDlD7GbkLJGRoPCA5nSfH Szht2PdNvbDizODhtBy8BOQA6Vb21XOb1k/hfD8Wy6OnvkA4Er61cf66BzXeTEFrvAIW+eUeoYTBA eOOc2m4Y0J28lXhoQftpNGV5DxH9HSQilQZxEyWkNj8oomVJ6Db7gSHre0odlt5ZdB7eCJik12aPI dK5W97adXrUDAclipsyYmZoC1oRkfUrHZ3aYVgabfC+EfoHnC3KhvekmEfxAPHydGcp80iqQJPjqn eDJBOrk6Y51HDMNKg4HJfPV0kujgbF3Oie2MVTuJawiidafsAjP4r7oZTkP0N+jqRmf/wkPe4xkGQ Ru+L2GTknKtzLAOMAPSh38JqlReQ59G4JpCqLPr00sA9YN+XP+9vOHT9s4iOu2RKy2v4eVOAfEFLX q2JejUQfXZtzSrS/31ThMbfUmZsRi8CY3HRBAENX224Wcn6IsXj3K6lfYxImRKWGa/4KviLias917 DT/pjLw/hE8CYubEDpm6cYpHdeAEmsrt/9dMe6flzcNQZlCBgl9zuErP8Cwq8YNO4jN78vRlLLZ5s qgDTWtGWygi/SUj8AUQHyF677QARAQABiQI7BBgBCgAmFiEEZiKd+VhdGdcosBcafnvtNTGKqCkFA mWKTg4CGwwFCRLMAwAACgkQfnvtNTGKqCkpsw/2MuS0PVhl2iXs+MleEhnN1KjeSYaw+nLbRwd2Sd XoVXBquPP9Bgb92T2XilcWObNwfVtD2eDz8eKf3e9aaWIzZRQ3E5BxiQSHXl6bDDNaWJB6I8dd5TW +QnBPLzvqxgLIoYn+2FQ0AtL0wpMOdcFg3Av8MEmMJk6s/AHkL8HselA3+4h8mgoK7yMSh601WGrQ AFkrWabtynWxHrq4xGfyIPpq56e5ZFPEPd4Ou8wsagn+XEdjDof/QSSjJiIaenCdDiUYrx1jltLmS lN4gRxnlCBp6JYr/7GlJ9Gf26wk25pb9RD6xgMemYQHFgkUsqDulxoBit8g9e0Jlo0gwxvWWSKBJ8 3f22kKiMdtWIieq94KN8kqErjSXcpI8Etu8EZsuF7LArAPch/5yjltOR5NgbcZ1UBPIPzyPgcAmZl AQgpy5c2UBMmPzxco/A/JVp4pKX8elTc0pS8W7ne8mrFtG7JL0VQfdwNNn2R45VRf3Ag+0pLSLS7W OVQcB8UjwxqDC2t3tJymKmFUfIq8N1DsNrHkBxjs9m3r82qt64u5rBUH3GIO0MGxaI033P+Pq3BXy i1Ur7p0ufsjEj7QCbEAnCPBTSfFEQIBW4YLVPk76tBXdh9HsCwwsrGC2XBmi8ymA05tMAFVq7a2W+ TO0tfEdfAX7IENcV87h2yAFBZkaA== Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.52.0-1build2 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Sat, 2024-07-06 at 22:45 +0800, Geliang Tang wrote: > From: Geliang Tang > > v9: >  - new patches 5-7, new struct member expect_errno for > network_helper_opts. >  - patches 1-4, 8-9 unchanged. >  - update patches 10-11 to make sure all tests pass. Superseded, v10 is sent. Thanks, -Geliang > > v8: >  - only patch 8 updated, to fix errors reported by CI. > > v7: >  - address Martin's comments in v6. (thanks) >  - use MAX(opts->backlog, 0) instead of opts->backlog. >  - use connect_to_fd_opts instead connect_to_fd. >  - more ASSERT_* to check errors. > > v6: >  - update patch 6 as Daniel suggested. (thanks) > > v5: >  - keep make_server and make_client as Eduard suggested. > > v4: >  - a new patch to use make_sockaddr in sockmap_ktls. >  - a new patch to close fd in error path in drop_on_reuseport. >  - drop make_server() in patch 7. >  - drop make_client() too in patch 9. > > v3: >  - a new patch to add backlog for network_helper_opts. >  - use start_server_str in sockmap_ktls now, not start_server. > > v2: >  - address Eduard's comments in v1. (thanks) >  - fix errors reported by CI. > > This patch set uses network helpers in sockmap_ktls and sk_lookup, > and > drop three local helpers tcp_server(), inetaddr_len() and > make_socket() > in them. > > Geliang Tang (11): >   selftests/bpf: Add backlog for network_helper_opts >   selftests/bpf: Use start_server_str in sockmap_ktls >   selftests/bpf: Use connect_to_fd_opts in sockmap_ktls >   selftests/bpf: Use make_sockaddr in sockmap_ktls >   selftests/bpf: Add network_helper_opts for connect_fd_to_fd >   selftests/bpf: Add expect_errno for network_helper_opts >   selftests/bpf: Set expect_errno for cgroup_skb_sk_lookup >   selftests/bpf: Close fd in error path in drop_on_reuseport >   selftests/bpf: Use start_server_str in sk_lookup >   selftests/bpf: Use connect_to_addr in sk_lookup >   selftests/bpf: Drop make_socket in sk_lookup > >  tools/testing/selftests/bpf/network_helpers.c |  23 ++- >  tools/testing/selftests/bpf/network_helpers.h |   8 +- >  .../testing/selftests/bpf/prog_tests/bpf_nf.c |   5 +- >  .../bpf/prog_tests/cgroup_skb_sk_lookup.c     |   8 +- >  .../selftests/bpf/prog_tests/cgroup_tcp_skb.c |   4 +- >  .../selftests/bpf/prog_tests/cgroup_v1v2.c    |   1 + >  .../selftests/bpf/prog_tests/sk_lookup.c      | 152 +++++++--------- > -- >  .../selftests/bpf/prog_tests/sockmap_ktls.c   |  53 ++---- >  8 files changed, 106 insertions(+), 148 deletions(-) >