From: Eduard Zingerman <eddyz87@gmail.com>
To: Paul Chaignon <paul.chaignon@gmail.com>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>
Subject: Re: [PATCH bpf-next 1/2] bpf: Avoid warning on unexpected map for tail call
Date: Thu, 03 Jul 2025 14:51:45 -0700 [thread overview]
Message-ID: <b30b2404c40fa170c13ec1750b4c00d0480a582f.camel@gmail.com> (raw)
In-Reply-To: <1f395b74e73022e47e04a31735f258babf305420.1751578055.git.paul.chaignon@gmail.com>
On Thu, 2025-07-03 at 23:35 +0200, Paul Chaignon wrote:
> Before handling the tail call in record_func_key(), we check that the
> map is of the expected type and log a verifier error if it isn't. Such
> an error however doesn't indicate anything wrong with the verifier. The
> check for map<>func compatibility is done after record_func_key(), by
> check_map_func_compatibility().
>
> Therefore, this patch logs the error as a typical reject instead of a
> verifier error.
>
> Fixes: d2e4c1e6c294 ("bpf: Constant map key tracking for prog array pokes")
> Fixes: 0df1a55afa83 ("bpf: Warn on internal verifier errors")
> Reported-by: syzbot+efb099d5833bca355e51@syzkaller.appspotmail.com
> Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
> ---
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
[...]
next prev parent reply other threads:[~2025-07-03 21:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-03 21:35 [PATCH bpf-next 1/2] bpf: Avoid warning on unexpected map for tail call Paul Chaignon
2025-07-03 21:36 ` [PATCH bpf-next 2/2] selftests/bpf: Negative test case for tail call map Paul Chaignon
2025-07-03 21:55 ` Eduard Zingerman
2025-07-04 13:06 ` Paul Chaignon
2025-07-03 21:51 ` Eduard Zingerman [this message]
2025-07-04 2:40 ` [PATCH bpf-next 1/2] bpf: Avoid warning on unexpected map for tail call patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b30b2404c40fa170c13ec1750b4c00d0480a582f.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=paul.chaignon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox