From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<bpf@vger.kernel.org>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<ast@kernel.org>, <daniel@iogearbox.net>, <hawk@kernel.org>,
<john.fastabend@gmail.com>, <maciej.fijalkowski@intel.com>,
<UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next v3] lan966x: Don't use xdp_frame when action is XDP_TX
Date: Mon, 24 Apr 2023 15:36:22 +0200 [thread overview]
Message-ID: <b32703ea-2074-1ad3-621f-370bc2a14727@intel.com> (raw)
In-Reply-To: <20230422142344.3630602-1-horatiu.vultur@microchip.com>
From: Horatiu Vultur <horatiu.vultur@microchip.com>
Date: Sat, 22 Apr 2023 16:23:44 +0200
> When the action of an xdp program was XDP_TX, lan966x was creating
> a xdp_frame and use this one to send the frame back. But it is also
> possible to send back the frame without needing a xdp_frame, because
> it is possible to send it back using the page.
> And then once the frame is transmitted is possible to use directly
> page_pool_recycle_direct as lan966x is using page pools.
> This would save some CPU usage on this path, which results in higher
> number of transmitted frames. Bellow are the statistics:
> Frame size: Improvement:
> 64 ~8%
> 256 ~11%
> 512 ~8%
> 1000 ~0%
> 1500 ~0%
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> ---
> v2->v3:
> - fix length issue when the XDP action is XDP_REDIRECT, this issue was
> introduced in v2 of this patch series.
> - reduce the number of changes by moving back all the assignments to
> next_dcb_buf
>
> v1->v2:
> - reduce number of arguments for the function lan966x_fdma_xmit_xdpf,
> as some of them are mutual exclusive, and other can be replaced with
> deduced from the other ones
> - update commit message and add statistics for the improvement
[...]
Thanks,
Olek
next prev parent reply other threads:[~2023-04-24 13:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-22 14:23 [PATCH net-next v3] lan966x: Don't use xdp_frame when action is XDP_TX Horatiu Vultur
2023-04-24 13:36 ` Alexander Lobakin [this message]
2023-04-25 2:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b32703ea-2074-1ad3-621f-370bc2a14727@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox