public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
From: Eduard Zingerman <eddyz87@gmail.com>
To: Harishankar Vishwanathan <harishankar.vishwanathan@gmail.com>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann	 <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	Paul Chaignon	 <paul.chaignon@gmail.com>,
	Shung-Hsi Yu <shung-hsi.yu@suse.com>,
	Srinivas Narayana <srinivas.narayana@rutgers.edu>,
	Santosh Nagarakatte <santosh.nagarakatte@rutgers.edu>
Subject: Re: [PATCH bpf-next 1/2] bpf/verifier: Use intersection checks when simulating to detect dead branches
Date: Mon, 20 Apr 2026 15:41:22 -0700	[thread overview]
Message-ID: <b44b4b9333cc099882c919145306381ab01d747c.camel@gmail.com> (raw)
In-Reply-To: <CAM=Ch079=-6advVJAaEv8U5-N3_nZY39qf_5c7s0krU02oEa7A@mail.gmail.com>

On Mon, 2026-04-20 at 18:35 -0400, Harishankar Vishwanathan wrote:
> On Fri, Apr 17, 2026 at 8:45 PM Eduard Zingerman <eddyz87@gmail.com> wrote:
> > 
> > On Fri, 2026-04-17 at 20:38 -0400, Harishankar Vishwanathan wrote:
> > > On Fri, Apr 17, 2026 at 7:19 PM Eduard Zingerman <eddyz87@gmail.com> wrote:
> > > > 
> > > > On Fri, 2026-04-17 at 14:17 -0700, Eduard Zingerman wrote:
> > > > > On Fri, 2026-04-17 at 01:34 -0400, Harishankar Vishwanathan wrote:
> > > > > 
> > > [...]
> > > > 
> 
> > Thank you for sharing the code. Indeed very similar logic.
> > I was under impression that you don't like the witness idea hence
> > proceeded on my own. Would have deferred to you if not for that.
> 
> I suppose I didn't look at it like "witness generation", but rather an
> "allwise intersection exists". Turns out of course, that both ideas
> are essentially similar. Also figured I should finish verifying and then
> share my implementation.
> 
> > Tbh, my version looks a bit shorter/simpler.
> 
> Agree yours is shorter. But I found the individual
> computations in my implementation easier to follow.

find_witness_aux() might be a bit packed, but I like the successive
subdivision into cases more than ranges accumulation into array.

> [...]
> 
> I can follow up with a v2, which includes ideas from both, probably closer
> to your version.

Sure, please follow-up.

  reply	other threads:[~2026-04-20 22:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-15 16:07 [PATCH bpf-next 0/2] Detect and prune dead branches using intersection checks Harishankar Vishwanathan
2026-04-15 16:07 ` [PATCH bpf-next 1/2] bpf/verifier: Use intersection checks when simulating to detect dead branches Harishankar Vishwanathan
2026-04-15 17:04   ` bot+bpf-ci
2026-04-15 19:02   ` Paul Chaignon
2026-04-16  1:10   ` Eduard Zingerman
2026-04-16 17:23     ` Eduard Zingerman
2026-04-16 23:13     ` Harishankar Vishwanathan
2026-04-16 23:33       ` Eduard Zingerman
2026-04-17  5:24         ` Eduard Zingerman
2026-04-17  5:34         ` Harishankar Vishwanathan
2026-04-17 21:17           ` Eduard Zingerman
2026-04-17 23:19             ` Eduard Zingerman
2026-04-18  0:38               ` Harishankar Vishwanathan
2026-04-18  0:45                 ` Eduard Zingerman
2026-04-20 22:35                   ` Harishankar Vishwanathan
2026-04-20 22:41                     ` Eduard Zingerman [this message]
2026-04-21  3:18                       ` Harishankar Vishwanathan
2026-04-18  0:22             ` Harishankar Vishwanathan
2026-04-15 16:07 ` [PATCH bpf-next 2/2] selftests/bpf: Test for empty intersection of tnum and u64 Harishankar Vishwanathan
2026-04-15 18:29   ` sashiko-bot
2026-04-16 17:51     ` Paul Chaignon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b44b4b9333cc099882c919145306381ab01d747c.camel@gmail.com \
    --to=eddyz87@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=harishankar.vishwanathan@gmail.com \
    --cc=paul.chaignon@gmail.com \
    --cc=santosh.nagarakatte@rutgers.edu \
    --cc=shung-hsi.yu@suse.com \
    --cc=srinivas.narayana@rutgers.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox