Re: [PATCH bpf-next v7 4/5] selftests/bpf: Test parameterized task BPF iterators.

[Kui-Feng Lee <kuifeng@fb.com>]

On Fri, 2022-08-26 at 14:24 -0700, Yonghong Song wrote:
> 
> 
> On 8/25/22 5:37 PM, Kui-Feng Lee wrote:
> > Test iterators of vma, files, and tasks of tasks.
> 
> 'tasks of tasks' is confusing.
> I guess you mean:
>    Test iterators of (1). vma, files and tasks of a process,
>    (2). vma, files of a task, and (3). a single task.
> ?

"Test iterators of vma, files and tasks."
It would be enough since the following lines explains the effects of
the parameters.

> 
> > 
> > Ensure the API works appropriately to visit all tasks,
> > tasks in a process, or a particular task.
> > 
> > Signed-off-by: Kui-Feng Lee <kuifeng@fb.com>
> > ---
> >   .../selftests/bpf/prog_tests/bpf_iter.c       | 282
> > ++++++++++++++++--
> >   .../selftests/bpf/prog_tests/btf_dump.c       |   2 +-
> >   .../selftests/bpf/progs/bpf_iter_task.c       |   9 +
> >   .../selftests/bpf/progs/bpf_iter_task_file.c  |   9 +-
> >   .../selftests/bpf/progs/bpf_iter_task_vma.c   |   7 +-
> >   .../selftests/bpf/progs/bpf_iter_vma_offset.c |  37 +++
> >   6 files changed, 322 insertions(+), 24 deletions(-)
> >   create mode 100644
> > tools/testing/selftests/bpf/progs/bpf_iter_vma_offset.c
> > 
> [...]