Re: [PATCH bpf-next v2] selftests/bpf: convert test_xdp_features.sh to test_progs

["Alexis Lothoré" <alexis.lothore@bootlin.com>]

Hi Martin,

On 9/25/24 22:01, Martin KaFai Lau wrote:
> On 9/25/24 3:37 AM, Martin KaFai Lau wrote:
>> I am not sure which case in xdp_features.c does not have existing coverage in
>> test_progs. From a quick look, it seems only BPF_MAP_TYPE_CPUMAP is missing
>> (please check)?
> 
> Re: CPUMAP, I noticed there is a xdp_(cpu)map_attach.c test but it only does
> attach test. May be something similar can be done like
> https://lore.kernel.org/bpf/20240911-devel-koalo-fix-ingress-ifindex-v4-2-5c643ae10258@linutronix.de/ to exercise the xdp prog that does cpumap redirect.

Thanks for the guidance, I was not aware of the possibility to perform those
tests with BPF_PROG_RUN.
Indeed, the basic return values from XDP programs seem to be covered with this
method in other tests under prog_tests. For BPF_MAP_TYPE_CPUMAP, I can check and
try to apply the same logic as the series in progress you have pointed.

Once done, test_xdp_features.sh could be let as-is. Let me know if we should
stillmove it elsewhere instead of keeping it in selftests
(tools/bpf/xdp_features/ maybe ?)

And noted for the most relevant tests to convert after that, thanks :)

Alexis


-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com