From: "Ruinskiy, Dima" <dima.ruinskiy@intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<kuba@kernel.org>, <pabeni@redhat.com>, <edumazet@google.com>,
<netdev@vger.kernel.org>
Cc: Kurt Kanzenbach <kurt@linutronix.de>, <sasha.neftin@intel.com>,
<vitaly.lifshits@intel.com>, <maciej.fijalkowski@intel.com>,
<magnus.karlsson@intel.com>, <ast@kernel.org>,
<daniel@iogearbox.net>, <hawk@kernel.org>,
<john.fastabend@gmail.com>, <bpf@vger.kernel.org>,
<bigeasy@linutronix.de>,
Vinicius Costa Gomes <vinicius.gomes@intel.com>,
Simon Horman <horms@kernel.org>,
Mor Bar-Gabay <morx.bar.gabay@intel.com>
Subject: Re: [PATCH net-next 2/6] igc: Get rid of spurious interrupts
Date: Thu, 5 Sep 2024 09:16:01 +0300 [thread overview]
Message-ID: <b5120c1e-4312-40da-8c11-c0af035dbbb5@intel.com> (raw)
In-Reply-To: <20240830210451.2375215-3-anthony.l.nguyen@intel.com>
On 31/08/2024 0:04, Tony Nguyen wrote:
> - wr32(IGC_ICS, IGC_ICS_RXDMT0);
> + struct igc_ring *rx_ring = adapter->rx_ring[0];
> +
> + if (test_bit(IGC_RING_FLAG_RX_ALLOC_FAILED, &rx_ring->flags)) {
> + clear_bit(IGC_RING_FLAG_RX_ALLOC_FAILED, &rx_ring->flags);
> + wr32(IGC_ICS, IGC_ICS_RXDMT0);
> + }
I have some concerns specifically about this code (Legacy/MSI interrupt
case). The code only checks the IGC_RING_FLAG_RX_ALLOC_FAILED flag of
ring 0. What if the failure was on another ring? It seems proper to
iterate over all Rx rings in the adapter (I believe igc can have up to 4).
next prev parent reply other threads:[~2024-09-05 6:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240830210451.2375215-1-anthony.l.nguyen@intel.com>
2024-08-30 21:04 ` [PATCH net-next 2/6] igc: Get rid of spurious interrupts Tony Nguyen
2024-09-05 6:16 ` Ruinskiy, Dima [this message]
2024-09-05 9:44 ` Kurt Kanzenbach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5120c1e-4312-40da-8c11-c0af035dbbb5@intel.com \
--to=dima.ruinskiy@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=morx.bar.gabay@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sasha.neftin@intel.com \
--cc=vinicius.gomes@intel.com \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox