From: Yonghong Song <yonghong.song@linux.dev>
To: Andrey Grafin <conquistador@yandex-team.ru>, bpf@vger.kernel.org
Cc: andrii@kernel.org
Subject: Re: [PATCH bpf v5 1/2] libbpf: Apply map_set_def_max_entries() for inner_maps on creation
Date: Wed, 17 Jan 2024 08:52:33 -0800 [thread overview]
Message-ID: <b6ea10f5-0643-4a82-a59a-aca1ff639fb5@linux.dev> (raw)
In-Reply-To: <20240117130619.9403-1-conquistador@yandex-team.ru>
On 1/17/24 5:06 AM, Andrey Grafin wrote:
> This patch allows to auto create BPF_MAP_TYPE_ARRAY_OF_MAPS and
> BPF_MAP_TYPE_HASH_OF_MAPS with values of BPF_MAP_TYPE_PERF_EVENT_ARRAY
> by bpf_object__load().
>
> Previous behaviour created a zero filled btf_map_def for inner maps and
> tried to use it for a map creation but the linux kernel forbids to create
> a BPF_MAP_TYPE_PERF_EVENT_ARRAY map with max_entries=0.
>
> Fixes: 646f02ffdd49 ("libbpf: Add BTF-defined map-in-map support")
> Signed-off-by: Andrey Grafin <conquistador@yandex-team.ru>
If the previous patch has been ack'ed, and the current version
is the same or only has minor change compared to previous version,
you can carry previous Ack. This will save maintainer and reviewer's
time.
Acked-by: Yonghong Song <yonghong.song@linux.dev>
next prev parent reply other threads:[~2024-01-17 16:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 13:06 [PATCH bpf v5 1/2] libbpf: Apply map_set_def_max_entries() for inner_maps on creation Andrey Grafin
2024-01-17 13:06 ` [PATCH bpf v5 2/2] selftest/bpf: Add map_in_maps with BPF_MAP_TYPE_PERF_EVENT_ARRAY values Andrey Grafin
2024-01-17 16:53 ` Yonghong Song
2024-01-18 1:14 ` Hou Tao
2024-01-17 16:52 ` Yonghong Song [this message]
2024-01-18 1:12 ` [PATCH bpf v5 1/2] libbpf: Apply map_set_def_max_entries() for inner_maps on creation Hou Tao
2024-01-19 21:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6ea10f5-0643-4a82-a59a-aca1ff639fb5@linux.dev \
--to=yonghong.song@linux.dev \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=conquistador@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox