BPF List
 help / color / mirror / Atom feed
From: Eduard Zingerman <eddyz87@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Ihor Solodrai <ihor.solodrai@pm.me>,
	Daniel Borkmann <daniel@iogearbox.net>,
	 "bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"ast@kernel.org" <ast@kernel.org>,
	"andrii@kernel.org" <andrii@kernel.org>,
	"mykolal@fb.com" <mykolal@fb.com>
Subject: Re: [PATCH bpf-next v2] selftests/bpf: use auto-dependencies for test objects
Date: Fri, 12 Jul 2024 12:46:58 -0700	[thread overview]
Message-ID: <b97340645b9a730df46e69b03b3ccba39816c414.camel@gmail.com> (raw)
In-Reply-To: <CAEf4BzY4kXRSci3Lb6ZFT7++6fics-w4_8rYMB4vCEHgrCWEnQ@mail.gmail.com>

On Fri, 2024-07-12 at 12:20 -0700, Andrii Nakryiko wrote:

[...]

> > An alternative fix would be to specify additional dependencies for
> > core_reloc.test.o (and others) directly, e.g.:
> > 
> >     core_reloc.test.o: test_core_reloc_module.bpf.o ...
> > 
> > (with correct trunner prefix)
> 
> I was about to say that not all tests use BPF skeleton headers just
> yet, so we have to have a way to explicitly specify dependencies. I
> think a separate list should be good enough for now, and in parallel
> we should try to switch remaining tests to skeleton headers. Even if
> we don't want to convert tests themselves to using skeleton structs,
> we can convert them to use elf_bytes from skeleton headers instead of
> loading .bpf.o files from disk. That should eliminate the need for
> extra dependencies.

For the scope of this patch-set, I'd say specifying dependencies
in the Makefile should be ok.
Or would you prefer migrating tests to use elf bytes?

[...]

  reply	other threads:[~2024-07-12 19:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-12  4:36 [PATCH bpf-next v2] selftests/bpf: use auto-dependencies for test objects Ihor Solodrai
2024-07-12 15:26 ` Daniel Borkmann
2024-07-12 17:48   ` Ihor Solodrai
2024-07-12 19:06     ` Eduard Zingerman
2024-07-12 19:20       ` Andrii Nakryiko
2024-07-12 19:46         ` Eduard Zingerman [this message]
2024-07-12 19:52           ` Andrii Nakryiko
2024-07-15  1:17             ` Ihor Solodrai
2024-07-15 17:44               ` Andrii Nakryiko
2024-07-16 23:21                 ` Eduard Zingerman
2024-07-17  0:36                   ` Ihor Solodrai
2024-07-17  0:57                     ` Eduard Zingerman
2024-07-17  1:49                       ` Ihor Solodrai
2024-07-17 16:41                   ` Andrii Nakryiko
2024-07-17 23:24                     ` Eduard Zingerman
2024-07-18 15:34                       ` Andrii Nakryiko
2024-07-18 22:42                         ` Ihor Solodrai
2024-07-19  5:02                           ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b97340645b9a730df46e69b03b3ccba39816c414.camel@gmail.com \
    --to=eddyz87@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=ihor.solodrai@pm.me \
    --cc=mykolal@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox