BPF List
 help / color / mirror / Atom feed
From: Yonghong Song <yhs@fb.com>
To: Andrii Nakryiko <andriin@fb.com>,
	"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Alexei Starovoitov <ast@fb.com>,
	"daniel@iogearbox.net" <daniel@iogearbox.net>
Cc: "andrii.nakryiko@gmail.com" <andrii.nakryiko@gmail.com>,
	Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH bpf-next] bpftool: work-around rst2man conversion bug
Date: Wed, 18 Dec 2019 23:35:03 +0000	[thread overview]
Message-ID: <bc49104a-01a7-8731-e811-53a6c9861a48@fb.com> (raw)
In-Reply-To: <20191218221707.2552199-1-andriin@fb.com>



On 12/18/19 2:17 PM, Andrii Nakryiko wrote:
> Work-around what appears to be a bug in rst2man convertion tool, used to
> create man pages out of reStructureText-formatted documents. If text line
> starts with dot, rst2man will put it in resulting man file verbatim. This
> seems to cause man tool to interpret it as a directive/command (e.g., `.bs`), and
> subsequently not render entire line because it's unrecognized one.
> 
> Enclose '.xxx' words in extra formatting to work around.
> 
> Fixes: cb21ac588546 ("bpftool: Add gen subcommand manpage")
> Reported-by: Alexei Starovoitov <ast@kernel.org>
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>
> ---
>   tools/bpf/bpftool/Documentation/bpftool-gen.rst | 15 ++++++++-------
>   1 file changed, 8 insertions(+), 7 deletions(-)
> 
> diff --git a/tools/bpf/bpftool/Documentation/bpftool-gen.rst b/tools/bpf/bpftool/Documentation/bpftool-gen.rst
> index b6a114bf908d..86a87da97d0b 100644
> --- a/tools/bpf/bpftool/Documentation/bpftool-gen.rst
> +++ b/tools/bpf/bpftool/Documentation/bpftool-gen.rst
> @@ -112,13 +112,14 @@ DESCRIPTION
>   
>   		  If BPF object has global variables, corresponding structs
>   		  with memory layout corresponding to global data data section
> -		  layout will be created. Currently supported ones are: .data,
> -		  .bss, .rodata, and .extern structs/data sections. These
> -		  data sections/structs can be used to set up initial values of
> -		  variables, if set before **example__load**. Afterwards, if
> -		  target kernel supports memory-mapped BPF arrays, same
> -		  structs can be used to fetch and update (non-read-only)
> -		  data from userspace, with same simplicity as for BPF side.
> +		  layout will be created. Currently supported ones are: *.data*,
> +		  *.bss*, *.rodata*, and *.kconfig* structs/data sections.
> +		  These data sections/structs can be used to set up initial
> +		  values of variables, if set before **example__load**.
> +		  Afterwards, if target kernel supports memory-mapped BPF
> +		  arrays, same structs can be used to fetch and update
> +		  (non-read-only) data from userspace, with same simplicity
> +		  as for BPF side.

Still does not look right.

After build, I did `man ./bpftool-gen.8`, and I got the following,

                  sponding to global data data section layout will be 
created. Currently supported ones
                  are: .data, data sections/structs can be used to set 
up initial values of  variables,

.bss, .rodata .kconfig etc. are missing. I am using:

-bash-4.4$ man --version
man 2.6.3

>   
>   	**bpftool gen help**
>   		  Print short help message.
> 

  reply	other threads:[~2019-12-18 23:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 22:17 [PATCH bpf-next] bpftool: work-around rst2man conversion bug Andrii Nakryiko
2019-12-18 23:35 ` Yonghong Song [this message]
2019-12-19  0:40   ` Andrii Nakryiko
2019-12-19  0:41   ` Yonghong Song
2019-12-19  1:04     ` Alexei Starovoitov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc49104a-01a7-8731-e811-53a6c9861a48@fb.com \
    --to=yhs@fb.com \
    --cc=Kernel-team@fb.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox