From: Eduard Zingerman <eddyz87@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Ihor Solodrai <ihor.solodrai@pm.me>,
bpf@vger.kernel.org, andrii@kernel.org, ast@kernel.org,
daniel@iogearbox.net, mykolal@fb.com
Subject: Re: [PATCH bpf-next] libbpf: change log level of BTF loading error message
Date: Wed, 18 Sep 2024 21:32:09 -0700 [thread overview]
Message-ID: <beeceb70d2a8b60d08e5d76c99040789615584c6.camel@gmail.com> (raw)
In-Reply-To: <CAEf4Bza3JcUQP8KikcizW5-K_JpvZFeXr9aJvOCeO1VD+qySoA@mail.gmail.com>
On Thu, 2024-09-19 at 06:25 +0200, Andrii Nakryiko wrote:
[...]
> Nowadays the expectation is that the BPF program will have a valid
> .BTF section, so even though .BTF is "optional", I think it's fine to
> emit a warning for that case (any reasonably recent Clang will produce
> valid BTF).
>
> Ihor's patch is fixing the situation with an outdated host kernel that
> doesn't understand BTF. libbpf will try to "upload" the program's BTF,
> but if that fails and the BPF object doesn't use any features that
> require having BTF uploaded, then it's just an information message to
> the user, but otherwise can be ignored.
>
> tl;dr, I think Ihor's patch is fine and sufficient. bpf-next is
> closed, will apply when it reopens.
Understood, thank you for explaining.
next prev parent reply other threads:[~2024-09-19 4:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-18 19:33 [PATCH bpf-next] libbpf: change log level of BTF loading error message Ihor Solodrai
2024-09-18 21:03 ` Eduard Zingerman
2024-09-18 21:45 ` Ihor Solodrai
2024-09-19 4:25 ` Andrii Nakryiko
2024-09-19 4:32 ` Eduard Zingerman [this message]
2024-09-25 10:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=beeceb70d2a8b60d08e5d76c99040789615584c6.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=ihor.solodrai@pm.me \
--cc=mykolal@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox