From: "Jiayuan Chen" <jiayuan.chen@linux.dev>
To: "John Fastabend" <john.fastabend@gmail.com>, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v2 1/2] bpf: fix ktls panic with sockmap
Date: Tue, 08 Apr 2025 15:04:03 +0000 [thread overview]
Message-ID: <bf967b32b696ee00ad865d5e4ed247386c332960@linux.dev> (raw)
In-Reply-To: <20250402231548.5d242cty2r4msj52@gmail.com>
April 3, 2025 at 07:15, "John Fastabend" <john.fastabend@gmail.com> wrote:
>
> I tend to agree this is not a good situation. Returning 0 is probably
>
> suspect as well and likely breaks some applications. But considering
>
> we already have this behavior I think its best not to change here
>
> if its not causing trouble.
>
> And not panic'ing is clearly better. So...
>
> Acked-by: John Fastabend <john.fastabend@gmail.com>
>
Thank you, John, for your review, we're glad to have finally
resolved this issue!
Thank.
next prev parent reply other threads:[~2025-04-08 15:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 5:20 [PATCH bpf-next v2 0/2] bpf: fix ktls panic with sockmap and add tests Jiayuan Chen
2025-02-19 5:20 ` [PATCH bpf-next v2 1/2] bpf: fix ktls panic with sockmap Jiayuan Chen
2025-04-02 23:10 ` John Fastabend
2025-04-02 23:15 ` John Fastabend
2025-04-08 15:04 ` Jiayuan Chen [this message]
2025-02-19 5:20 ` [PATCH bpf-next v2 2/2] selftests/bpf: add ktls selftest Jiayuan Chen
2025-04-02 23:49 ` John Fastabend
2025-04-10 3:00 ` [PATCH bpf-next v2 0/2] bpf: fix ktls panic with sockmap and add tests patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf967b32b696ee00ad865d5e4ed247386c332960@linux.dev \
--to=jiayuan.chen@linux.dev \
--cc=bpf@vger.kernel.org \
--cc=john.fastabend@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox