From: Quentin Monnet <qmo@kernel.org>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Mykyta Yatsenko <mykyta.yatsenko5@gmail.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
daniel@iogearbox.net, kafai@meta.com, kernel-team@meta.com,
Mykyta Yatsenko <yatsenko@meta.com>
Subject: Re: [PATCH bpf-next] bpf: improve error message for unsupported helper
Date: Mon, 25 Mar 2024 23:36:01 +0000 [thread overview]
Message-ID: <c00ec359-a99f-42b7-894a-8e79a7cce888@kernel.org> (raw)
In-Reply-To: <CAEf4Bzb_3d=+PfaBFCDDOSnU3jwb_W1BaVkgZsF-UcVefysOOg@mail.gmail.com>
On 25/03/2024 23:19, Andrii Nakryiko wrote:
> On Mon, Mar 25, 2024 at 8:22 AM Mykyta Yatsenko
> <mykyta.yatsenko5@gmail.com> wrote:
>>
>> From: Mykyta Yatsenko <yatsenko@meta.com>
>>
>> BPF verifier emits "unknown func" message when given BPF program type
>> does not support BPF helper. This message may be confusing for users, as
>> important context that helper is unknown only to current program type is
>> not provided.
>>
>> This patch changes message to "program of this type cannot use helper "
>> and aligns dependent code in libbpf and tests. Any suggestions on
>> improving/changing this message are welcome.
>>
>> Signed-off-by: Mykyta Yatsenko <yatsenko@meta.com>
>> ---
>
> "unknown func bpf_somehelper" is one of the common confusions users
> run into (and I had to explain multiple times), so this more
> meaningful message is definitely an improvement, thanks!
>
> Acked-by: Andrii Nakryiko <andrii@kernel.org>
Same here; and thanks for including the bpftool update!
Acked-by: Quentin Monnet <qmo@kernel.org>
next prev parent reply other threads:[~2024-03-25 23:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 15:22 [PATCH bpf-next] bpf: improve error message for unsupported helper Mykyta
2024-03-25 23:19 ` Andrii Nakryiko
2024-03-25 23:36 ` Quentin Monnet [this message]
2024-03-27 16:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c00ec359-a99f-42b7-894a-8e79a7cce888@kernel.org \
--to=qmo@kernel.org \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@meta.com \
--cc=kernel-team@meta.com \
--cc=mykyta.yatsenko5@gmail.com \
--cc=yatsenko@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox