From: Eduard Zingerman <eddyz87@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Mykyta Yatsenko <mykyta.yatsenko5@gmail.com>,
bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
daniel@iogearbox.net, kafai@meta.com, kernel-team@meta.com,
Mykyta Yatsenko <yatsenko@meta.com>
Subject: Re: [PATCH bpf-next v3] selftests/bpf: add BPF program dump in veristat
Date: Wed, 20 Aug 2025 15:06:12 -0700 [thread overview]
Message-ID: <c1b62e3fa2e7a6de635815efff6cbb641d999a3a.camel@gmail.com> (raw)
In-Reply-To: <CAEf4BzbtzTZ5t3UwN-cgDNUqSE6vMdDZCHtPWy6bjAUaDhHsKA@mail.gmail.com>
On Wed, 2025-08-20 at 15:02 -0700, Andrii Nakryiko wrote:
[...]
> What's the concern with popen()? That we have to copy one stream into another?
No concern, just see an additional loop as unnecessary, this does not
matter much.
>
> I didn't like (instinctively) the implicitness of system() adding
> something to veristat's output, and you just proved that instinct
> correct with that fflush()... ;)
You asked a question off-list on Tuesday whether system() and popen()
behave the same, here is an answer (both are wrappers for 'sh -c').
[...]
prev parent reply other threads:[~2025-08-20 22:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 11:43 [PATCH bpf-next v3] selftests/bpf: add BPF program dump in veristat Mykyta Yatsenko
2025-08-20 21:34 ` Andrii Nakryiko
2025-08-20 21:52 ` Eduard Zingerman
2025-08-20 22:02 ` Andrii Nakryiko
2025-08-20 22:06 ` Eduard Zingerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1b62e3fa2e7a6de635815efff6cbb641d999a3a.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@meta.com \
--cc=kernel-team@meta.com \
--cc=mykyta.yatsenko5@gmail.com \
--cc=yatsenko@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).