From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 173D31C69C; Wed, 28 Aug 2024 13:58:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=167.114.26.122 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724853533; cv=none; b=ZlLnQQcOV4YL01elk/MPd2yEsWeqYWgn78+X9XkrfzrMmqNZrhGenMQCHt9LTgYQ/srbzZvqwudiNOMwGgxGKnrGW6dJgLuACwseO6BahCuYr9vu4yNxhsUkPJF3is9ZiscIwJd7f9kb4j7BJdvADoQcLyEjSQwsGg9gEC5wkwE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724853533; c=relaxed/simple; bh=D/QwnR7xfk7AmyRNSdHLddBpqIZ6b6ckbSM2sk7O7lE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=XqpLd3lbyKZ0y8iAUJOyFhCZcc4pZKHuETmD8YFr56rzWMmTvs6IEfjNLlI63dFp/Yzwfw19VgD8409ZeiTIs26PxDQ8QygxjlPVS0RFPYnL8L/v96FlwosNcVu5NikF8fZtlrvRDDjpljhv/0j/y7vUHs8+Sn/qOa0ufxXu95E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=PZQOVl3n; arc=none smtp.client-ip=167.114.26.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="PZQOVl3n" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1724853529; bh=D/QwnR7xfk7AmyRNSdHLddBpqIZ6b6ckbSM2sk7O7lE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PZQOVl3nDbtcbNtTV2me4c4cb3fCC/PvdCi+Cpvb9ExqVzKiWG/1ULbjpS/okLNef 71op6CsPEgj+6tmzUZa3bjIWjyNyb11wxy7O2eH/9YeOb9ACpDmYLNx24IdUKWS9LA +1PcU9wQfRScHoB7MF3eznr7nSN40JWbMXUXwg+Q+0Qfk1ct44hB9kEDeHyHGbdf+6 DFR+UwCi6dUihWU5LUAK+BD3AOnrdkhV8wrGC4nzORJLurACiAsD9Sd/FKfMhQfYrv 0LLrm2H1zlADDK5vy/ERFB4gsKQ7wbPGV0H2y8Ppor3OWVrnKx3HA5cvI3c74DYUGc ddG2/23u6Humg== Received: from [172.16.0.134] (96-127-217-162.qc.cable.ebox.net [96.127.217.162]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4Wv5c94Q3hz1JcN; Wed, 28 Aug 2024 09:58:49 -0400 (EDT) Message-ID: Date: Wed, 28 Aug 2024 09:58:25 -0400 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 3/8] cleanup.h: Introduce DEFINE_INACTIVE_GUARD and activate_guard To: Steven Rostedt Cc: Masami Hiramatsu , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Alexei Starovoitov , Yonghong Song , "Paul E . McKenney" , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , bpf@vger.kernel.org, Joel Fernandes , Ingo Molnar , Linus Torvalds , Kees Cook , Greg KH , Sean Christopherson References: <20240627152340.82413-1-mathieu.desnoyers@efficios.com> <20240627152340.82413-4-mathieu.desnoyers@efficios.com> <20240819190014.31ab74d8@gandalf.local.home> From: Mathieu Desnoyers Content-Language: en-US In-Reply-To: <20240819190014.31ab74d8@gandalf.local.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024-08-20 01:00, Steven Rostedt wrote: > On Thu, 27 Jun 2024 11:23:35 -0400 > Mathieu Desnoyers wrote: > >> To cover scenarios where the scope of the guard differs from the scope >> of its activation, introduce DEFINE_INACTIVE_GUARD() and activate_guard(). >> >> Here is an example use for a conditionally activated guard variable: >> >> void func(bool a) >> { >> DEFINE_INACTIVE_GUARD(preempt_notrace, myguard); >> >> [...] >> if (a) { >> might_sleep(); >> activate_guard(preempt_notrace, myguard)(); >> } >> [ protected code ] >> } >> > > Hi Mathieu, > > The three cleanup patches fail to apply (I believe one has already been > fixed by Ingo too). Could you have the clean up patches be a separate > series that is likely to get in, especially since it's more of a moving > target. Then it would make sense to split this into two series: one for the guard stuff, and one for tracing which depends on the first one. I'll do that. Mathieu > > Thanks, > > -- Steve -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com