From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-170.mta0.migadu.com (out-170.mta0.migadu.com [91.218.175.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D044C15B for ; Tue, 21 May 2024 02:20:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716258031; cv=none; b=RNTCNhHyRxfYTeZY9MTp6sIAXPhmojDvmJxx6jqyNuieLvrLaGp9vlMgx619CqL9IxjU2L2i+BvUJSdNYQz60Dzz06ZZhqtxaALes3DSnbMz5VgFjlU3Yzgthwa8SHDD7jPYm/9S6YlAM+OT7a9hsVYPQXo1F78yBpE1fiyR2i0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716258031; c=relaxed/simple; bh=IfDpDl1wMdJJ6d7nOOuaBXPYvBfJ2aHMYt1CcXwdbTA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PL3OT3ix0V13WTbctRH3wpBp96gWROqDJ3S4f8FXaIX72VyMdKH3VCnBgv2K3nou4CQfLReIJVGigYvAn7yGnYG8JBSFbfUtbaNmhfDlMjQkHIlwoK8VVTFgMqU7dZhp4fPmH7IqJPnx+ZFjgZdK6xRs4fklDNJ+SaoG6pR/xIc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=FXERWRCD; arc=none smtp.client-ip=91.218.175.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="FXERWRCD" X-Envelope-To: dthaler1968@googlemail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716258027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IfDpDl1wMdJJ6d7nOOuaBXPYvBfJ2aHMYt1CcXwdbTA=; b=FXERWRCDBahryJFKbcE+ZvI+AfYISFjtb0VobE97eGWkY9i3yozT40WFdAHfKbyDxymdWE NslOIJPfzfPAck32MwYdTgdIbs/k7mLqwbDAbQowP9/XS6P4pq3X4Q9iI0WuXvOOa5DztB +PPx0PmK9FPWNjsSsiOlhWw1fRZ3BsU= X-Envelope-To: bpf@vger.kernel.org X-Envelope-To: bpf@ietf.org X-Envelope-To: dthaler1968@gmail.com Message-ID: Date: Mon, 20 May 2024 19:20:24 -0700 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v2] bpf, docs: clarify sign extension of 64-bit use of 32-bit imm Content-Language: en-GB To: Dave Thaler , bpf@vger.kernel.org Cc: bpf@ietf.org, Dave Thaler References: <20240520215255.10595-1-dthaler1968@gmail.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: <20240520215255.10595-1-dthaler1968@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 5/20/24 3:52 PM, Dave Thaler wrote: > imm is defined as a 32-bit signed integer. > > {MOV, K, ALU64} says it does "dst = src" (where src is 'imm') and it > does do dst = (s64)imm, which in that sense does sign extend imm. The MOVSX > instruction is explained as sign extending, so added the example of > {MOV, K, ALU64} to make this more clear. > > {JLE, K, JMP} says it does "PC += offset if dst <= src" (where src is 'imm', > and the comparison is unsigned). This was apparently ambiguous to some > readers as to whether the comparison was "dst <= (u64)(u32)imm" or > "dst <= (u64)(s64)imm" so added an example to make this more clear. > > v1 -> v2: Address comments from Yonghong > > Signed-off-by: Dave Thaler Acked-by: Yonghong Song From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.ietf.org (mail.ietf.org [50.223.129.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 25921C15B for ; Tue, 21 May 2024 02:20:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=50.223.129.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716258046; cv=none; b=WaUNplFz0bvd54bnugOOzw2wYd3iippTEPwlUjr5LhITpHjEzrbLVd8Pj3PTQJslo+5/JDAqPwuI3S3X7R0AqLP1NtU2S8O6CMb7U0tGqqrnPjIH+9DRSBgeWEWULm+k5P+lxpQsRsJLjKioxhxkEZ6IgwnjRhJk1aYvPjQfuKQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716258046; c=relaxed/simple; bh=oGVUTghDb0n40j72Q+oe7k2Nsi48wFmLYIh+otDn9i0=; h=Message-ID:Date:MIME-Version:To:References:From:In-Reply-To:CC: Subject:Content-Type; b=MKoKgoLgcpsYO7ZMILdOhwV1tqM/xBePUVj1XkxQguAHwZkMkcSf96dUUaskc5WSddm7TVEjpmC0rnb2dGn0ZW6QYYibSVlh6D0gQDVleFHFQFQiqSZ/zUW2r4NqqeUBHddfbMHqNZDXYrp+a9xu/UyjYebd6dRbW+yLqW/aY78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=ietf.org; dkim=pass (1024-bit key) header.d=ietf.org header.i=@ietf.org header.b=nX3y13My; dkim=pass (1024-bit key) header.d=ietf.org header.i=@ietf.org header.b=nX3y13My; dkim=fail (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=FXERWRCD reason="signature verification failed"; arc=none smtp.client-ip=50.223.129.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ietf.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ietf.org header.i=@ietf.org header.b="nX3y13My"; dkim=pass (1024-bit key) header.d=ietf.org header.i=@ietf.org header.b="nX3y13My"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="FXERWRCD" Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 73C98C180B64 for ; Mon, 20 May 2024 19:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ietf.org; s=ietf1; t=1716258044; bh=oGVUTghDb0n40j72Q+oe7k2Nsi48wFmLYIh+otDn9i0=; h=Date:To:References:From:In-Reply-To:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe; b=nX3y13MyjMd/MERDMsZzv6HN/coyRdS0wgwDmjE9XYdx51h4lb8+Rp1bvflomRhA4 nYp3zk7TYmGUC7zxG6KnpU28nj/f80F8beyiPmAKZ8lO7M0zzI0/WMCP3huo0A7nQ/ Htf4yj1rSy2ZKF3mB0df7IsHo+EuUYsMnjh2oMuY= X-Mailbox-Line: From bpf-bounces+bpf=vger.kernel.org@ietf.org Mon May 20 19:20:44 2024 Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id 63A4EC169404 for ; Mon, 20 May 2024 19:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ietf.org; s=ietf1; t=1716258044; bh=oGVUTghDb0n40j72Q+oe7k2Nsi48wFmLYIh+otDn9i0=; h=Date:To:References:From:In-Reply-To:CC:Subject:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe; b=nX3y13MyjMd/MERDMsZzv6HN/coyRdS0wgwDmjE9XYdx51h4lb8+Rp1bvflomRhA4 nYp3zk7TYmGUC7zxG6KnpU28nj/f80F8beyiPmAKZ8lO7M0zzI0/WMCP3huo0A7nQ/ Htf4yj1rSy2ZKF3mB0df7IsHo+EuUYsMnjh2oMuY= Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 17D7AC1516EB for ; Mon, 20 May 2024 19:20:36 -0700 (PDT) X-Virus-Scanned: amavisd-new at amsl.com X-Spam-Flag: NO X-Spam-Score: -7.096 X-Spam-Level: Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=linux.dev Received: from mail.ietf.org ([50.223.129.194]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id spG-xLdqs6s0 for ; Mon, 20 May 2024 19:20:31 -0700 (PDT) Received: from out-182.mta0.migadu.com (out-182.mta0.migadu.com [IPv6:2001:41d0:1004:224b::b6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 167A7C14CE4D for ; Mon, 20 May 2024 19:20:30 -0700 (PDT) X-Envelope-To: dthaler1968@googlemail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1716258027; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IfDpDl1wMdJJ6d7nOOuaBXPYvBfJ2aHMYt1CcXwdbTA=; b=FXERWRCDBahryJFKbcE+ZvI+AfYISFjtb0VobE97eGWkY9i3yozT40WFdAHfKbyDxymdWE NslOIJPfzfPAck32MwYdTgdIbs/k7mLqwbDAbQowP9/XS6P4pq3X4Q9iI0WuXvOOa5DztB +PPx0PmK9FPWNjsSsiOlhWw1fRZ3BsU= X-Envelope-To: bpf@vger.kernel.org X-Envelope-To: bpf@ietf.org X-Envelope-To: dthaler1968@gmail.com Message-ID: Date: Mon, 20 May 2024 19:20:24 -0700 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Language: en-GB To: Dave Thaler , bpf@vger.kernel.org References: <20240520215255.10595-1-dthaler1968@gmail.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: <20240520215255.10595-1-dthaler1968@gmail.com> X-Migadu-Flow: FLOW_OUT Message-ID-Hash: RNMFYXJZU4B7VMRSUD4REUOEZ632ZFHS X-Message-ID-Hash: RNMFYXJZU4B7VMRSUD4REUOEZ632ZFHS X-MailFrom: yonghong.song@linux.dev X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: bpf@ietf.org, Dave Thaler X-Mailman-Version: 3.3.9rc4 Precedence: list Subject: =?utf-8?q?=5BBpf=5D_Re=3A_=5BPATCH_bpf-next_v2=5D_bpf=2C_docs=3A_clarify_sig?= =?utf-8?q?n_extension_of_64-bit_use_of_32-bit_imm?= Archived-At: List-Archive: List-Help: List-Owner: List-Post: X-Mailman-Copy: yes Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 Message-ID: <20240521022024.nDiG9tgQq8gLg4j0ruHqCnOn9R2odFktjKkUjfWPd6E@z> DQpPbiA1LzIwLzI0IDM6NTIgUE0sIERhdmUgVGhhbGVyIHdyb3RlOg0KPiBpbW0gaXMgZGVmaW5l ZCBhcyBhIDMyLWJpdCBzaWduZWQgaW50ZWdlci4NCj4NCj4ge01PViwgSywgQUxVNjR9IHNheXMg aXQgZG9lcyAiZHN0ID0gc3JjIiAod2hlcmUgc3JjIGlzICdpbW0nKSBhbmQgaXQNCj4gZG9lcyBk byBkc3QgPSAoczY0KWltbSwgd2hpY2ggaW4gdGhhdCBzZW5zZSBkb2VzIHNpZ24gZXh0ZW5kIGlt bS4gVGhlIE1PVlNYDQo+IGluc3RydWN0aW9uIGlzIGV4cGxhaW5lZCBhcyBzaWduIGV4dGVuZGlu Zywgc28gYWRkZWQgdGhlIGV4YW1wbGUgb2YNCj4ge01PViwgSywgQUxVNjR9IHRvIG1ha2UgdGhp cyBtb3JlIGNsZWFyLg0KPg0KPiB7SkxFLCBLLCBKTVB9IHNheXMgaXQgZG9lcyAiUEMgKz0gb2Zm c2V0IGlmIGRzdCA8PSBzcmMiICh3aGVyZSBzcmMgaXMgJ2ltbScsDQo+IGFuZCB0aGUgY29tcGFy aXNvbiBpcyB1bnNpZ25lZCkuIFRoaXMgd2FzIGFwcGFyZW50bHkgYW1iaWd1b3VzIHRvIHNvbWUN Cj4gcmVhZGVycyBhcyB0byB3aGV0aGVyIHRoZSBjb21wYXJpc29uIHdhcyAiZHN0IDw9ICh1NjQp KHUzMilpbW0iIG9yDQo+ICJkc3QgPD0gKHU2NCkoczY0KWltbSIgc28gYWRkZWQgYW4gZXhhbXBs ZSB0byBtYWtlIHRoaXMgbW9yZSBjbGVhci4NCj4NCj4gdjEgLT4gdjI6IEFkZHJlc3MgY29tbWVu dHMgZnJvbSBZb25naG9uZw0KPg0KPiBTaWduZWQtb2ZmLWJ5OiBEYXZlIFRoYWxlciA8ZHRoYWxl cjE5NjhAZ29vZ2xlbWFpbC5jb20+DQoNCkFja2VkLWJ5OiBZb25naG9uZyBTb25nIDx5b25naG9u Zy5zb25nQGxpbnV4LmRldj4NCg0KLS0gCkJwZiBtYWlsaW5nIGxpc3QgLS0gYnBmQGlldGYub3Jn ClRvIHVuc3Vic2NyaWJlIHNlbmQgYW4gZW1haWwgdG8gYnBmLWxlYXZlQGlldGYub3JnCg==