From: Yonghong Song <yhs@fb.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>,
"Andrii Nakryiko" <andriin@fb.com>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Alexei Starovoitov" <ast@fb.com>,
"daniel@iogearbox.net" <daniel@iogearbox.net>
Cc: "andrii.nakryiko@gmail.com" <andrii.nakryiko@gmail.com>,
Kernel Team <Kernel-team@fb.com>
Subject: Re: [PATCH v4 bpf-next 2/4] libbpf: support libbpf-provided extern variables
Date: Sat, 14 Dec 2019 20:27:21 +0000 [thread overview]
Message-ID: <c5f3bc99-1e1d-f8cf-2bbe-5e86c61c64b6@fb.com> (raw)
In-Reply-To: <87a77vcbqt.fsf@toke.dk>
On 12/14/19 4:50 AM, Toke Høiland-Jørgensen wrote:
> [...]
>
>> +static bool sym_is_extern(const GElf_Sym *sym)
>> +{
>> + int bind = GELF_ST_BIND(sym->st_info);
>> + /* externs are symbols w/ type=NOTYPE, bind=GLOBAL|WEAK, section=UND */
>> + return sym->st_shndx == SHN_UNDEF &&
>> + (bind == STB_GLOBAL || bind == STB_WEAK) &&
>> + GELF_ST_TYPE(sym->st_info) == STT_NOTYPE;
>> +}
>
> Will this also match function declarations marked as extern? I've
Yes. They are treated the same as other extern variables in symbol table.
> started looking into how to handle this for the static/dynamic linking
> use cases and am wondering whether it makes sense to pull in this series
> and build on that?
>
> -Toke
>
next prev parent reply other threads:[~2019-12-14 20:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-14 1:47 [PATCH v4 bpf-next 0/4] Add libbpf-provided extern variables support Andrii Nakryiko
2019-12-14 1:47 ` [PATCH v4 bpf-next 1/4] libbpf: extract internal map names into constants Andrii Nakryiko
2019-12-14 1:47 ` [PATCH v4 bpf-next 2/4] libbpf: support libbpf-provided extern variables Andrii Nakryiko
2019-12-14 12:50 ` Toke Høiland-Jørgensen
2019-12-14 20:27 ` Yonghong Song [this message]
2019-12-16 11:17 ` Daniel Borkmann
2019-12-16 19:29 ` Andrii Nakryiko
2019-12-17 14:42 ` Daniel Borkmann
2019-12-17 19:03 ` Andrii Nakryiko
2019-12-17 19:50 ` Daniel Borkmann
2019-12-17 20:16 ` Alexei Starovoitov
2019-12-17 23:37 ` Daniel Borkmann
2019-12-18 0:08 ` Andrii Nakryiko
2019-12-16 12:43 ` Daniel Borkmann
2019-12-16 18:19 ` Andrii Nakryiko
2019-12-14 1:47 ` [PATCH v4 bpf-next 3/4] bpftool: generate externs datasec in BPF skeleton Andrii Nakryiko
2019-12-14 1:47 ` [PATCH v4 bpf-next 4/4] selftests/bpf: add tests for libbpf-provided externs Andrii Nakryiko
2019-12-16 0:52 ` [PATCH v4 bpf-next 0/4] Add libbpf-provided extern variables support Alexei Starovoitov
2019-12-16 1:47 ` Andrii Nakryiko
2019-12-16 4:42 ` Alexei Starovoitov
2019-12-16 19:34 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5f3bc99-1e1d-f8cf-2bbe-5e86c61c64b6@fb.com \
--to=yhs@fb.com \
--cc=Kernel-team@fb.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox