From: Martin KaFai Lau <martin.lau@linux.dev>
To: Stanislav Fomichev <sdf@google.com>
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
song@kernel.org, yhs@fb.com, john.fastabend@gmail.com,
kpsingh@kernel.org, haoluo@google.com, jolsa@kernel.org,
Martin KaFai Lau <martin.lau@kernel.org>,
syzbot+d8bd751aef7c6b39a344@syzkaller.appspotmail.com,
bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next 2/2] bpf: prevent decl_tag from being referenced in func_proto
Date: Mon, 17 Oct 2022 11:32:49 -0700 [thread overview]
Message-ID: <c89f7691-d413-cc4e-2f8f-11abe9680e33@linux.dev> (raw)
In-Reply-To: <20221015002444.2680969-2-sdf@google.com>
On 10/14/22 5:24 PM, Stanislav Fomichev wrote:
> diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
> index eba603cec2c5..35c07afac924 100644
> --- a/kernel/bpf/btf.c
> +++ b/kernel/bpf/btf.c
> @@ -4436,6 +4436,11 @@ static int btf_func_proto_check(struct btf_verifier_env *env,
> return -EINVAL;
> }
>
> + if (btf_type_is_resolve_source_only(ret_type)) {
> + btf_verifier_log_type(env, t, "Invalid return type");
> + return -EINVAL;
> + }
Thanks for the fix. It is applied to the bpf tree.
next prev parent reply other threads:[~2022-10-17 18:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 0:24 [PATCH bpf-next 1/2] selftests/bpf: Add reproducer for decl_tag in func_proto return type Stanislav Fomichev
2022-10-15 0:24 ` [PATCH bpf-next 2/2] bpf: prevent decl_tag from being referenced in func_proto Stanislav Fomichev
2022-10-17 5:33 ` Yonghong Song
2022-10-17 18:32 ` Martin KaFai Lau [this message]
2022-10-17 5:33 ` [PATCH bpf-next 1/2] selftests/bpf: Add reproducer for decl_tag in func_proto return type Yonghong Song
2022-10-17 18:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c89f7691-d413-cc4e-2f8f-11abe9680e33@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@kernel.org \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=syzbot+d8bd751aef7c6b39a344@syzkaller.appspotmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox