Re: [PATCH bpf-next] bpf: rename BTF_KIND_TAG to BTF_KIND_DECL_TAG

[Daniel Borkmann <daniel@iogearbox.net>]

On 10/11/21 6:06 AM, Yonghong Song wrote:
> Patch set [1] introduced BTF_KIND_TAG to allow tagging
> declarations for struct/union, struct/union field, var, func
> and func arguments and these tags will be encoded into
> dwarf. They are also encoded to btf by llvm for the bpf target.
> 
> After BTF_KIND_TAG is introduced, we intended to use it
> for kernel __user attributes. But kernel __user is actually
> a type attribute. Upstream and internal discussion showed
> it is not a good idea to mix declaration attribute and
> type attribute. So we proposed to introduce btf_type_tag
> as a type attribute and existing btf_tag renamed to
> btf_decl_tag ([2]).
> 
> This patch renamed BTF_KIND_TAG to BTF_KIND_DECL_TAG and some
> other declarations with *_tag to *_decl_tag to make it clear
> the tag is for declaration. In the future, BTF_KIND_TYPE_TAG
> might be introduced per [2].
> 
>   [1] https://lore.kernel.org/bpf/20210914223004.244411-1-yhs@fb.com/
>   [2] https://reviews.llvm.org/D111199
> 

Just a small nit: no objections to the rename as its only in bpf-next, but
lets add proper Fixes tags to the three main commits from the series in [1]
(which adds it to core, libbpf, bpftool). Given these are in bpf-next, the
commit shas are more useful for searching in the git log compared to links
to lore in this case. Thanks!

> Signed-off-by: Yonghong Song <yhs@fb.com>