bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eduard Zingerman <eddyz87@gmail.com>
To: Yonghong Song <yhs@fb.com>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	 Daniel Borkmann <daniel@iogearbox.net>,
	Fangrui Song <maskray@google.com>,
	kernel-team@fb.com
Subject: Re: [PATCH bpf-next v2 12/15] selftests/bpf: Add unit tests for new sdiv/smod insns
Date: Wed, 19 Jul 2023 02:10:23 +0300	[thread overview]
Message-ID: <ca8894041f7f33e86ecbc4e03925bb4c67401e9f.camel@gmail.com> (raw)
In-Reply-To: <20230713060831.396527-1-yhs@fb.com>

On Wed, 2023-07-12 at 23:08 -0700, Yonghong Song wrote:
> Add unit tests for sdiv/smod insns.
> 
> Signed-off-by: Yonghong Song <yhs@fb.com>
> ---
>  .../selftests/bpf/prog_tests/verifier.c       |   2 +
>  .../selftests/bpf/progs/verifier_sdiv.c       | 763 ++++++++++++++++++
>  2 files changed, 765 insertions(+)
>  create mode 100644 tools/testing/selftests/bpf/progs/verifier_sdiv.c
> 
> diff --git a/tools/testing/selftests/bpf/prog_tests/verifier.c b/tools/testing/selftests/bpf/prog_tests/verifier.c
> index 885532540bc3..a591d7b673f1 100644
> --- a/tools/testing/selftests/bpf/prog_tests/verifier.c
> +++ b/tools/testing/selftests/bpf/prog_tests/verifier.c
> @@ -54,6 +54,7 @@
>  #include "verifier_ringbuf.skel.h"
>  #include "verifier_runtime_jit.skel.h"
>  #include "verifier_scalar_ids.skel.h"
> +#include "verifier_sdiv.skel.h"
>  #include "verifier_search_pruning.skel.h"
>  #include "verifier_sock.skel.h"
>  #include "verifier_spill_fill.skel.h"
> @@ -159,6 +160,7 @@ void test_verifier_regalloc(void)             { RUN(verifier_regalloc); }
>  void test_verifier_ringbuf(void)              { RUN(verifier_ringbuf); }
>  void test_verifier_runtime_jit(void)          { RUN(verifier_runtime_jit); }
>  void test_verifier_scalar_ids(void)           { RUN(verifier_scalar_ids); }
> +void test_verifier_sdiv(void)                 { RUN(verifier_sdiv); }
>  void test_verifier_search_pruning(void)       { RUN(verifier_search_pruning); }
>  void test_verifier_sock(void)                 { RUN(verifier_sock); }
>  void test_verifier_spill_fill(void)           { RUN(verifier_spill_fill); }
> diff --git a/tools/testing/selftests/bpf/progs/verifier_sdiv.c b/tools/testing/selftests/bpf/progs/verifier_sdiv.c
> new file mode 100644
> index 000000000000..d92098d670ef
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/progs/verifier_sdiv.c
> @@ -0,0 +1,763 @@
> +// SPDX-License-Identifier: GPL-2.0
> +
> +#include <linux/bpf.h>
> +#include <bpf/bpf_helpers.h>
> +#include "bpf_misc.h"
> +
> +SEC("socket")
> +__description("SDIV32, non-zero imm divisor, check 1")
> +__success __success_unpriv __retval(-20)
> +__naked void sdiv32_non_zero_imm_1(void)
> +{
> +	asm volatile ("					\
> +	w0 = -41;					\
> +	w0 s/= 2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV32, non-zero imm divisor, check 2")
> +__success __success_unpriv __retval(-20)
> +__naked void sdiv32_non_zero_imm_2(void)
> +{
> +	asm volatile ("					\
> +	w0 = 41;					\
> +	w0 s/= -2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV32, non-zero imm divisor, check 3")
> +__success __success_unpriv __retval(20)
> +__naked void sdiv32_non_zero_imm_3(void)
> +{
> +	asm volatile ("					\
> +	w0 = -41;					\
> +	w0 s/= -2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV32, non-zero imm divisor, check 4")
> +__success __success_unpriv __retval(-21)
> +__naked void sdiv32_non_zero_imm_4(void)
> +{
> +	asm volatile ("					\
> +	w0 = -42;					\
> +	w0 s/= 2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV32, non-zero imm divisor, check 5")
> +__success __success_unpriv __retval(-21)
> +__naked void sdiv32_non_zero_imm_5(void)
> +{
> +	asm volatile ("					\
> +	w0 = 42;					\
> +	w0 s/= -2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV32, non-zero imm divisor, check 6")
> +__success __success_unpriv __retval(21)
> +__naked void sdiv32_non_zero_imm_6(void)
> +{
> +	asm volatile ("					\
> +	w0 = -42;					\
> +	w0 s/= -2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV32, non-zero imm divisor, check 7")
> +__success __success_unpriv __retval(21)
> +__naked void sdiv32_non_zero_imm_7(void)
> +{
> +	asm volatile ("					\
> +	w0 = 42;					\
> +	w0 s/= 2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV32, non-zero imm divisor, check 8")
> +__success __success_unpriv __retval(20)
> +__naked void sdiv32_non_zero_imm_8(void)
> +{
> +	asm volatile ("					\
> +	w0 = 41;					\
> +	w0 s/= 2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV32, non-zero reg divisor, check 1")
> +__success __success_unpriv __retval(-20)
> +__naked void sdiv32_non_zero_reg_1(void)
> +{
> +	asm volatile ("					\
> +	w0 = -41;					\
> +	w1 = 2;						\
> +	w0 s/= w1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV32, non-zero reg divisor, check 2")
> +__success __success_unpriv __retval(-20)
> +__naked void sdiv32_non_zero_reg_2(void)
> +{
> +	asm volatile ("					\
> +	w0 = 41;					\
> +	w1 = -2;					\
> +	w0 s/= w1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV32, non-zero reg divisor, check 3")
> +__success __success_unpriv __retval(20)
> +__naked void sdiv32_non_zero_reg_3(void)
> +{
> +	asm volatile ("					\
> +	w0 = -41;					\
> +	w1 = -2;					\
> +	w0 s/= w1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV32, non-zero reg divisor, check 4")
> +__success __success_unpriv __retval(-21)
> +__naked void sdiv32_non_zero_reg_4(void)
> +{
> +	asm volatile ("					\
> +	w0 = -42;					\
> +	w1 = 2;						\
> +	w0 s/= w1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV32, non-zero reg divisor, check 5")
> +__success __success_unpriv __retval(-21)
> +__naked void sdiv32_non_zero_reg_5(void)
> +{
> +	asm volatile ("					\
> +	w0 = 42;					\
> +	w1 = -2;					\
> +	w0 s/= w1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV32, non-zero reg divisor, check 6")
> +__success __success_unpriv __retval(21)
> +__naked void sdiv32_non_zero_reg_6(void)
> +{
> +	asm volatile ("					\
> +	w0 = -42;					\
> +	w1 = -2;					\
> +	w0 s/= w1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV32, non-zero reg divisor, check 7")
> +__success __success_unpriv __retval(21)
> +__naked void sdiv32_non_zero_reg_7(void)
> +{
> +	asm volatile ("					\
> +	w0 = 42;					\
> +	w1 = 2;						\
> +	w0 s/= w1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV32, non-zero reg divisor, check 8")
> +__success __success_unpriv __retval(20)
> +__naked void sdiv32_non_zero_reg_8(void)
> +{
> +	asm volatile ("					\
> +	w0 = 41;					\
> +	w1 = 2;						\
> +	w0 s/= w1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV64, non-zero imm divisor, check 1")
> +__success __success_unpriv __retval(-20)
> +__naked void sdiv64_non_zero_imm_1(void)
> +{
> +	asm volatile ("					\
> +	r0 = -41;					\
> +	r0 s/= 2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV64, non-zero imm divisor, check 2")
> +__success __success_unpriv __retval(-20)
> +__naked void sdiv64_non_zero_imm_2(void)
> +{
> +	asm volatile ("					\
> +	r0 = 41;					\
> +	r0 s/= -2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV64, non-zero imm divisor, check 3")
> +__success __success_unpriv __retval(20)
> +__naked void sdiv64_non_zero_imm_3(void)
> +{
> +	asm volatile ("					\
> +	r0 = -41;					\
> +	r0 s/= -2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV64, non-zero imm divisor, check 4")
> +__success __success_unpriv __retval(-21)
> +__naked void sdiv64_non_zero_imm_4(void)
> +{
> +	asm volatile ("					\
> +	r0 = -42;					\
> +	r0 s/= 2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV64, non-zero imm divisor, check 5")
> +__success __success_unpriv __retval(-21)
> +__naked void sdiv64_non_zero_imm_5(void)
> +{
> +	asm volatile ("					\
> +	r0 = 42;					\
> +	r0 s/= -2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV64, non-zero imm divisor, check 6")
> +__success __success_unpriv __retval(21)
> +__naked void sdiv64_non_zero_imm_6(void)
> +{
> +	asm volatile ("					\
> +	r0 = -42;					\
> +	r0 s/= -2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV64, non-zero reg divisor, check 1")
> +__success __success_unpriv __retval(-20)
> +__naked void sdiv64_non_zero_reg_1(void)
> +{
> +	asm volatile ("					\
> +	r0 = -41;					\
> +	r1 = 2;						\
> +	r0 s/= r1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV64, non-zero reg divisor, check 2")
> +__success __success_unpriv __retval(-20)
> +__naked void sdiv64_non_zero_reg_2(void)
> +{
> +	asm volatile ("					\
> +	r0 = 41;					\
> +	r1 = -2;					\
> +	r0 s/= r1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV64, non-zero reg divisor, check 3")
> +__success __success_unpriv __retval(20)
> +__naked void sdiv64_non_zero_reg_3(void)
> +{
> +	asm volatile ("					\
> +	r0 = -41;					\
> +	r1 = -2;					\
> +	r0 s/= r1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV64, non-zero reg divisor, check 4")
> +__success __success_unpriv __retval(-21)
> +__naked void sdiv64_non_zero_reg_4(void)
> +{
> +	asm volatile ("					\
> +	r0 = -42;					\
> +	r1 = 2;						\
> +	r0 s/= r1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV64, non-zero reg divisor, check 5")
> +__success __success_unpriv __retval(-21)
> +__naked void sdiv64_non_zero_reg_5(void)
> +{
> +	asm volatile ("					\
> +	r0 = 42;					\
> +	r1 = -2;					\
> +	r0 s/= r1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV64, non-zero reg divisor, check 6")
> +__success __success_unpriv __retval(21)
> +__naked void sdiv64_non_zero_reg_6(void)
> +{
> +	asm volatile ("					\
> +	r0 = -42;					\
> +	r1 = -2;					\
> +	r0 s/= r1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD32, non-zero imm divisor, check 1")
> +__success __success_unpriv __retval(-1)
> +__naked void smod32_non_zero_imm_1(void)
> +{
> +	asm volatile ("					\
> +	w0 = -41;					\
> +	w0 s%%= 2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD32, non-zero imm divisor, check 2")
> +__success __success_unpriv __retval(1)
> +__naked void smod32_non_zero_imm_2(void)
> +{
> +	asm volatile ("					\
> +	w0 = 41;					\
> +	w0 s%%= -2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD32, non-zero imm divisor, check 3")
> +__success __success_unpriv __retval(-1)
> +__naked void smod32_non_zero_imm_3(void)
> +{
> +	asm volatile ("					\
> +	w0 = -41;					\
> +	w0 s%%= -2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD32, non-zero imm divisor, check 4")
> +__success __success_unpriv __retval(0)
> +__naked void smod32_non_zero_imm_4(void)
> +{
> +	asm volatile ("					\
> +	w0 = -42;					\
> +	w0 s%%= 2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD32, non-zero imm divisor, check 5")
> +__success __success_unpriv __retval(0)
> +__naked void smod32_non_zero_imm_5(void)
> +{
> +	asm volatile ("					\
> +	w0 = 42;					\
> +	w0 s%%= -2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD32, non-zero imm divisor, check 6")
> +__success __success_unpriv __retval(0)
> +__naked void smod32_non_zero_imm_6(void)
> +{
> +	asm volatile ("					\
> +	w0 = -42;					\
> +	w0 s%%= -2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD32, non-zero reg divisor, check 1")
> +__success __success_unpriv __retval(-1)
> +__naked void smod32_non_zero_reg_1(void)
> +{
> +	asm volatile ("					\
> +	w0 = -41;					\
> +	w1 = 2;						\
> +	w0 s%%= w1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD32, non-zero reg divisor, check 2")
> +__success __success_unpriv __retval(1)
> +__naked void smod32_non_zero_reg_2(void)
> +{
> +	asm volatile ("					\
> +	w0 = 41;					\
> +	w1 = -2;					\
> +	w0 s%%= w1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD32, non-zero reg divisor, check 3")
> +__success __success_unpriv __retval(-1)
> +__naked void smod32_non_zero_reg_3(void)
> +{
> +	asm volatile ("					\
> +	w0 = -41;					\
> +	w1 = -2;					\
> +	w0 s%%= w1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD32, non-zero reg divisor, check 4")
> +__success __success_unpriv __retval(0)
> +__naked void smod32_non_zero_reg_4(void)
> +{
> +	asm volatile ("					\
> +	w0 = -42;					\
> +	w1 = 2;						\
> +	w0 s%%= w1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD32, non-zero reg divisor, check 5")
> +__success __success_unpriv __retval(0)
> +__naked void smod32_non_zero_reg_5(void)
> +{
> +	asm volatile ("					\
> +	w0 = 42;					\
> +	w1 = -2;					\
> +	w0 s%%= w1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD32, non-zero reg divisor, check 6")
> +__success __success_unpriv __retval(0)
> +__naked void smod32_non_zero_reg_6(void)
> +{
> +	asm volatile ("					\
> +	w0 = -42;					\
> +	w1 = -2;					\
> +	w0 s%%= w1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD64, non-zero imm divisor, check 1")
> +__success __success_unpriv __retval(-1)
> +__naked void smod64_non_zero_imm_1(void)
> +{
> +	asm volatile ("					\
> +	r0 = -41;					\
> +	r0 s%%= 2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD64, non-zero imm divisor, check 2")
> +__success __success_unpriv __retval(1)
> +__naked void smod64_non_zero_imm_2(void)
> +{
> +	asm volatile ("					\
> +	r0 = 41;					\
> +	r0 s%%= -2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD64, non-zero imm divisor, check 3")
> +__success __success_unpriv __retval(-1)
> +__naked void smod64_non_zero_imm_3(void)
> +{
> +	asm volatile ("					\
> +	r0 = -41;					\
> +	r0 s%%= -2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD64, non-zero imm divisor, check 4")
> +__success __success_unpriv __retval(0)
> +__naked void smod64_non_zero_imm_4(void)
> +{
> +	asm volatile ("					\
> +	r0 = -42;					\
> +	r0 s%%= 2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD64, non-zero imm divisor, check 5")
> +__success __success_unpriv __retval(-0)
> +__naked void smod64_non_zero_imm_5(void)
> +{
> +	asm volatile ("					\
> +	r0 = 42;					\
> +	r0 s%%= -2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD64, non-zero imm divisor, check 6")
> +__success __success_unpriv __retval(0)
> +__naked void smod64_non_zero_imm_6(void)
> +{
> +	asm volatile ("					\
> +	r0 = -42;					\
> +	r0 s%%= -2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD64, non-zero imm divisor, check 7")
> +__success __success_unpriv __retval(0)
> +__naked void smod64_non_zero_imm_7(void)
> +{
> +	asm volatile ("					\
> +	r0 = 42;					\
> +	r0 s%%= 2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD64, non-zero imm divisor, check 8")
> +__success __success_unpriv __retval(1)
> +__naked void smod64_non_zero_imm_8(void)
> +{
> +	asm volatile ("					\
> +	r0 = 41;					\
> +	r0 s%%= 2;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD64, non-zero reg divisor, check 1")
> +__success __success_unpriv __retval(-1)
> +__naked void smod64_non_zero_reg_1(void)
> +{
> +	asm volatile ("					\
> +	r0 = -41;					\
> +	r1 = 2;						\
> +	r0 s%%= r1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD64, non-zero reg divisor, check 2")
> +__success __success_unpriv __retval(1)
> +__naked void smod64_non_zero_reg_2(void)
> +{
> +	asm volatile ("					\
> +	r0 = 41;					\
> +	r1 = -2;					\
> +	r0 s%%= r1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD64, non-zero reg divisor, check 3")
> +__success __success_unpriv __retval(-1)
> +__naked void smod64_non_zero_reg_3(void)
> +{
> +	asm volatile ("					\
> +	r0 = -41;					\
> +	r1 = -2;					\
> +	r0 s%%= r1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD64, non-zero reg divisor, check 4")
> +__success __success_unpriv __retval(0)
> +__naked void smod64_non_zero_reg_4(void)
> +{
> +	asm volatile ("					\
> +	r0 = -42;					\
> +	r1 = 2;						\
> +	r0 s%%= r1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD64, non-zero reg divisor, check 5")
> +__success __success_unpriv __retval(0)
> +__naked void smod64_non_zero_reg_5(void)
> +{
> +	asm volatile ("					\
> +	r0 = 42;					\
> +	r1 = -2;					\
> +	r0 s%%= r1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD64, non-zero reg divisor, check 6")
> +__success __success_unpriv __retval(0)
> +__naked void smod64_non_zero_reg_6(void)
> +{
> +	asm volatile ("					\
> +	r0 = -42;					\
> +	r1 = -2;					\
> +	r0 s%%= r1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD64, non-zero reg divisor, check 7")
> +__success __success_unpriv __retval(0)
> +__naked void smod64_non_zero_reg_7(void)
> +{
> +	asm volatile ("					\
> +	r0 = 42;					\
> +	r1 = 2;						\
> +	r0 s%%= r1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD64, non-zero reg divisor, check 8")
> +__success __success_unpriv __retval(1)
> +__naked void smod64_non_zero_reg_8(void)
> +{
> +	asm volatile ("					\
> +	r0 = 41;					\
> +	r1 = 2;						\
> +	r0 s%%= r1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SDIV32, zero divisor")
> +__success __success_unpriv __retval(42)
> +__naked void sdiv32_zero_divisor(void)
> +{
> +	asm volatile ("					\
> +	w0 = 42;					\
> +	w1 = 0;						\
> +	w2 = -1;					\
> +	w2 s/= w1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}

Maybe add "w0 = w2" in the end to check how division by zero modifies
the DST register?

> +
> +SEC("socket")
> +__description("SDIV64, zero divisor")
> +__success __success_unpriv __retval(42)
> +__naked void sdiv64_zero_divisor(void)
> +{
> +	asm volatile ("					\
> +	r0 = 42;					\
> +	r1 = 0;						\
> +	r2 = -1;					\
> +	r2 s/= r1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD32, zero divisor")
> +__success __success_unpriv __retval(42)
> +__naked void smod32_zero_divisor(void)
> +{
> +	asm volatile ("					\
> +	w0 = 42;					\
> +	w1 = 0;						\
> +	w2 = -1;					\
> +	w2 s%%= w1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +SEC("socket")
> +__description("SMOD64, zero divisor")
> +__success __success_unpriv __retval(42)
> +__naked void smod64_zero_divisor(void)
> +{
> +	asm volatile ("					\
> +	r0 = 42;					\
> +	r1 = 0;						\
> +	r2 = -1;					\
> +	r2 s%%= r1;					\
> +	exit;						\
> +"	::: __clobber_all);
> +}
> +
> +char _license[] SEC("license") = "GPL";


  reply	other threads:[~2023-07-18 23:10 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13  6:07 [PATCH bpf-next v2 00/15] bpf: Support new insns from cpu v4 Yonghong Song
2023-07-13  6:07 ` [PATCH bpf-next v2 01/15] bpf: Support new sign-extension load insns Yonghong Song
2023-07-14 18:13   ` Alexei Starovoitov
2023-07-14 23:22     ` Yonghong Song
2023-07-17  1:39   ` Eduard Zingerman
2023-07-19  0:15   ` Eduard Zingerman
2023-07-19  2:28     ` Yonghong Song
2023-07-13  6:07 ` [PATCH bpf-next v2 02/15] bpf: Fix sign-extension ctx member accesses Yonghong Song
2023-07-17  1:40   ` Eduard Zingerman
2023-07-19  0:40     ` Yonghong Song
2023-07-13  6:07 ` [PATCH bpf-next v2 03/15] bpf: Support new sign-extension mov insns Yonghong Song
2023-07-17  1:41   ` Eduard Zingerman
2023-07-19  1:17     ` Yonghong Song
2023-07-19 12:53       ` Eduard Zingerman
2023-07-19 15:59         ` Fangrui Song
2023-07-19 16:57           ` Eduard Zingerman
2023-07-13  6:07 ` [PATCH bpf-next v2 04/15] bpf: Support new unconditional bswap instruction Yonghong Song
2023-07-17  1:42   ` Eduard Zingerman
2023-07-19  1:22     ` Yonghong Song
2023-07-13  6:07 ` [PATCH bpf-next v2 05/15] bpf: Support new signed div/mod instructions Yonghong Song
2023-07-18 23:00   ` Eduard Zingerman
2023-07-19  2:30     ` Yonghong Song
2023-07-19  2:44       ` Alexei Starovoitov
2023-07-19  6:57         ` Yonghong Song
2023-07-13  6:07 ` [PATCH bpf-next v2 06/15] bpf: Fix jit blinding with new sdiv/smov insns Yonghong Song
2023-07-13  6:07 ` [PATCH bpf-next v2 07/15] bpf: Support new 32bit offset jmp instruction Yonghong Song
2023-07-13  6:08 ` [PATCH bpf-next v2 08/15] selftests/bpf: Add a cpuv4 test runner for cpu=v4 testing Yonghong Song
2023-07-13  6:18   ` Fangrui Song
2023-07-13  6:25     ` Yonghong Song
2023-07-13  6:08 ` [PATCH bpf-next v2 09/15] selftests/bpf: Add unit tests for new sign-extension load insns Yonghong Song
2023-07-18 23:06   ` Eduard Zingerman
2023-07-13  6:08 ` [PATCH bpf-next v2 10/15] selftests/bpf: Add unit tests for new sign-extension mov insns Yonghong Song
2023-07-13  6:08 ` [PATCH bpf-next v2 11/15] selftests/bpf: Add unit tests for new bswap insns Yonghong Song
2023-07-13  6:08 ` [PATCH bpf-next v2 12/15] selftests/bpf: Add unit tests for new sdiv/smod insns Yonghong Song
2023-07-18 23:10   ` Eduard Zingerman [this message]
2023-07-13  6:08 ` [PATCH bpf-next v2 13/15] selftests/bpf: Add unit tests for new gotol insn Yonghong Song
2023-07-13  6:08 ` [PATCH bpf-next v2 14/15] selftests/bpf: Test ldsx with more complex cases Yonghong Song
2023-07-13  6:08 ` [PATCH bpf-next v2 15/15] docs/bpf: Add documentation for new instructions Yonghong Song
2023-07-14 18:28   ` Alexei Starovoitov
2023-07-14 23:26     ` Yonghong Song
2023-07-14 23:33   ` Dave Thaler
2023-07-14 23:33     ` [Bpf] " Dave Thaler
2023-07-15  0:23     ` Alexei Starovoitov
2023-07-15  0:23       ` [Bpf] " Alexei Starovoitov
2023-07-14 23:34   ` Dave Thaler
2023-07-14 23:34     ` [Bpf] " Dave Thaler
2023-07-17  1:39 ` [PATCH bpf-next v2 00/15] bpf: Support new insns from cpu v4 Eduard Zingerman
2023-07-17 16:56   ` Alexei Starovoitov
2023-07-17 17:04     ` Eduard Zingerman
2023-07-17 21:52   ` Yonghong Song
2023-07-21 14:56     ` Jose E. Marchesi
2023-07-24  0:17       ` Jose E. Marchesi
2023-07-24  1:04         ` Jose E. Marchesi
2023-07-24  2:35           ` Yonghong Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ca8894041f7f33e86ecbc4e03925bb4c67401e9f.camel@gmail.com \
    --to=eddyz87@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=maskray@google.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).