From: Daniel Borkmann <daniel@iogearbox.net>
To: Hechao Li <hechaol@fb.com>, bpf@vger.kernel.org
Cc: rdna@fb.com, ast@kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2 bpf-next] bpf: Print error message for bpftool cgroup show
Date: Thu, 26 Dec 2019 10:51:29 +0100 [thread overview]
Message-ID: <cc43e37a-2ac3-36fc-e18f-59d42b2e5d8f@iogearbox.net> (raw)
In-Reply-To: <20191224011742.3714301-1-hechaol@fb.com>
On 12/24/19 2:17 AM, Hechao Li wrote:
> Currently, when bpftool cgroup show <path> has an error, no error
> message is printed. This is confusing because the user may think the
> result is empty.
>
> Before the change:
>
> $ bpftool cgroup show /sys/fs/cgroup
> ID AttachType AttachFlags Name
> $ echo $?
> 255
>
> After the change:
> $ ./bpftool cgroup show /sys/fs/cgroup
> Error: can't query bpf programs attached to /sys/fs/cgroup: Operation
> not permitted
>
> v2: Rename check_query_cgroup_progs to cgroup_has_attached_progs
>
> Signed-off-by: Hechao Li <hechaol@fb.com>
Applied, thanks!
prev parent reply other threads:[~2019-12-26 9:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-24 1:17 [PATCH v2 bpf-next] bpf: Print error message for bpftool cgroup show Hechao Li
2019-12-26 9:51 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc43e37a-2ac3-36fc-e18f-59d42b2e5d8f@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=hechaol@fb.com \
--cc=kernel-team@fb.com \
--cc=rdna@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox