From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BBDEC433E6 for ; Tue, 1 Sep 2020 06:13:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4DC6120FC3 for ; Tue, 1 Sep 2020 06:13:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726020AbgIAGNB (ORCPT ); Tue, 1 Sep 2020 02:13:01 -0400 Received: from mga02.intel.com ([134.134.136.20]:24145 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726006AbgIAGNB (ORCPT ); Tue, 1 Sep 2020 02:13:01 -0400 IronPort-SDR: N3Wjuo5KVDTqZoySiHLcqO31UpHuzvT2TWHvaq2kIkjecVGSXDleJGFgjn6/H9LE64YDmtPSuU yLDuni3Xl7tg== X-IronPort-AV: E=McAfee;i="6000,8403,9730"; a="144856125" X-IronPort-AV: E=Sophos;i="5.76,378,1592895600"; d="scan'208";a="144856125" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2020 23:13:00 -0700 IronPort-SDR: fcveK4Xd1ok6qSKSg/ca8jUiUE07Je+bJ/dmvDLANkrE0zdq7zyJ8zdvVK94A9AhJkVE4ag0z2 zYV2DdTFzoTw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,378,1592895600"; d="scan'208";a="375051416" Received: from swulich-mobl.ger.corp.intel.com (HELO btopel-mobl.ger.intel.com) ([10.252.34.221]) by orsmga001.jf.intel.com with ESMTP; 31 Aug 2020 23:12:57 -0700 Subject: Re: [PATCH bpf-next] bpf: change bq_enqueue() return type from int to void To: David Ahern , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , ast@kernel.org, daniel@iogearbox.net, bpf@vger.kernel.org Cc: magnus.karlsson@intel.com, netdev@vger.kernel.org, toke@redhat.com, brouer@redhat.com References: <20200831150730.35530-1-bjorn.topel@gmail.com> <8eda320b-3e32-d0c2-7746-cdef52b2468e@gmail.com> From: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Message-ID: Date: Tue, 1 Sep 2020 08:12:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <8eda320b-3e32-d0c2-7746-cdef52b2468e@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 2020-08-31 18:07, David Ahern wrote: > On 8/31/20 9:07 AM, Björn Töpel wrote: >> From: Björn Töpel >> >> The bq_enqueue() functions for {DEV, CPU}MAP always return >> zero. Changing the return type from int to void makes the code easier >> to follow. >> > > You can expand that to a few other calls in this code path - both > bq_flush_to_queue and bq_xmit_all always return 0 as well. > Indeed! I'll spin a new rev!