From: Martin KaFai Lau <martin.lau@linux.dev>
To: xulang@uniontech.com
Cc: bot+bpf-ci@kernel.org, ast@kernel.org, bpf@vger.kernel.org,
daniel@iogearbox.net, dddddd@hust.edu.cn, dzm91@hust.edu.cn,
hust-os-kernel-patches@googlegroups.com, kaiyanm@hust.edu.cn,
sdf@fomichev.me, andrii@kernel.org, martin.lau@kernel.org,
eddyz87@gmail.com, yonghong.song@linux.dev, clm@meta.com,
ihor.solodrai@linux.dev
Subject: Re: [PATCH v2] bpf: fix: Race condition in bpf_trampoline_unlink_cgroup_shim
Date: Fri, 27 Feb 2026 12:33:37 -0800 [thread overview]
Message-ID: <cd99eba7-ac03-4b53-a79c-a6206abbddb6@linux.dev> (raw)
In-Reply-To: <37aef2457aa50ca719b97ed4f945c6b22c219398d87296c72bcd69a678986ece@mail.kernel.org>
>
>> + /* Reusing existing shim attached by the other program. */
>> + mutex_unlock(&tr->mutex);
>> + bpf_trampoline_put(tr); /* bpf_trampoline_get above */
>> + return 0;
>> + }
>> }
>
> This commit fixes a use-after-free introduced by commit 69fd337a975c
> ("bpf: per-cgroup lsm flavor"), which added the bpf_link_inc() call
> that could resurrect a zero-refcount link.
>
> Should this include a Fixes: tag?
>
> Suggested:
> Fixes: 69fd337a975c ("bpf: per-cgroup lsm flavor")
On top of the Fixes tag, please add bpf to the subject, e.g. "[PATCH bpf
v3] bpf: Fix race condition...". Please also use the
FirstName[[:space:]]LastName <email> format in the "Signed-off-by". For
example: Lang Xu <xulang@uniontech.com>. Understood that there are
different name formatting but the reviewers can't possibly know all of
them, so it is useful to write it in a way that most people in the list
can understand.
next prev parent reply other threads:[~2026-02-27 20:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-25 11:14 bpf: Race condition in bpf_trampoline_unlink_cgroup_shim during concurrent cgroup LSM link release 梅开彦
2025-12-01 20:21 ` Martin KaFai Lau
2025-12-02 4:48 ` 梅开彦
2026-02-06 7:13 ` [PATCH] bpf: fix: Race condition in bpf_trampoline_unlink_cgroup_shim xulang
2026-02-06 7:50 ` bot+bpf-ci
2026-02-12 19:51 ` Martin KaFai Lau
2026-02-24 9:42 ` xulang
2026-02-25 6:54 ` [PATCH v2] " xulang
2026-02-25 7:38 ` bot+bpf-ci
2026-02-27 20:33 ` Martin KaFai Lau [this message]
2026-02-28 2:24 ` [PATCH bpf v3] " xulang
2026-02-28 3:04 ` bot+bpf-ci
2026-03-03 2:39 ` Martin KaFai Lau
2026-03-03 8:36 ` [PATCH bpf v4] " xulang
2026-03-03 9:28 ` bot+bpf-ci
2026-03-03 9:52 ` [PATCH bpf v5] bpf: fix: Race condition in bpf_trampoline_link_cgroup_shim xulang
2026-03-03 23:30 ` patchwork-bot+netdevbpf
2026-03-03 23:30 ` [PATCH bpf v4] bpf: fix: Race condition in bpf_trampoline_unlink_cgroup_shim patchwork-bot+netdevbpf
2026-03-03 23:46 ` Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd99eba7-ac03-4b53-a79c-a6206abbddb6@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bot+bpf-ci@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clm@meta.com \
--cc=daniel@iogearbox.net \
--cc=dddddd@hust.edu.cn \
--cc=dzm91@hust.edu.cn \
--cc=eddyz87@gmail.com \
--cc=hust-os-kernel-patches@googlegroups.com \
--cc=ihor.solodrai@linux.dev \
--cc=kaiyanm@hust.edu.cn \
--cc=martin.lau@kernel.org \
--cc=sdf@fomichev.me \
--cc=xulang@uniontech.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox