Re: [PATCH RFC bpf-next v2 04/18] rhashtable: Add rhashtable_walk_enter_from()

Mykyta Yatsenko
2026-04-13T12:22:05Z

On 4/13/26 12:13 AM, Alexei Starovoitov wrote:
> On Wed, Apr 8, 2026 at 8:10 AM Mykyta Yatsenko
> <mykyta.yatsenko5@gmail.com> wrote:
>>
>> +
>> + /* Test 2: walk_enter_from with non-existent key starts from bucket */
>> + {
>> + struct test_obj_val key = { .id = 99 };
>> +
>> + scoped_guard(rcu) {
>> + rhashtable_walk_enter_from(&ht, &iter, &key,
>> + test_rht_params);
>> + rhashtable_walk_start(&iter);
>> + }
>> +
>> + obj = rhashtable_walk_next(&iter);
>> + while (IS_ERR(obj) && PTR_ERR(obj) == -EAGAIN)
>> + obj = rhashtable_walk_next(&iter);
>> +
>> + /* Should still return some element (iteration from bucket start) */
>> + rhashtable_walk_stop(&iter);
>> + rhashtable_walk_exit(&iter);
>> + }
>> +
>> + /* Test 3: verify walk_enter_from + walk_next can iterate remaining elements */
>> + {
>> + struct test_obj_val key = { .id = 0 };
>> + int count = 0;
>
> Please de-claude this.
> I couldn't force claude to avoid using these pointless indents.
> Either figure out how to do it or remove it manually.

Thanks for the reviews, I'll apply your suggestions here and other
patches for the v3.