From: Andrey Ignatov <rdna@fb.com>
To: <bpf@vger.kernel.org>
Cc: Andrey Ignatov <rdna@fb.com>, <ast@kernel.org>,
<daniel@iogearbox.net>, <kafai@fb.com>, <andriin@fb.com>,
<kernel-team@fb.com>
Subject: [PATCH v2 bpf-next 0/5] bpf: Support access to bpf map fields
Date: Fri, 19 Jun 2020 14:11:40 -0700 [thread overview]
Message-ID: <cover.1592600985.git.rdna@fb.com> (raw)
v1->v2:
- move btf id cache to a new bpf_map_ops.map_btf_id field (Martin, Andrii);
- don't check btf names for collisions (Martin);
- drop btf_find_by_name_kind_next() patch since it was needed only for
collision check;
- don't fall back to `struct bpf_map` if a map type doesn't specify both
map_btf_name and map_btf_id;
This patch set adds support to access bpf map fields from bpf programs
using btf_struct_access().
That way a program can cast a pointer to map to either `struct bpf_map *`
or map type specific struct pointer such as `struct bpf_array *` or
`struct bpf_htab *`, and access necessary fields, e.g. map->max_entries.
The fields, in turn, should be defined by a user provided struct with
preserve_access_index attribute or included from vmlinux.h.
Please see patch 3 for more details on the feature and use-cases.
Other patches:
Patch 1 is refactoring to simplify btf_parse_vmlinux().
Patch 2 is a rename to avoid having two different `struct bpf_htab`.
Patch 4 enables access to map fields for all map types.
Patch 5 adds selftests.
Andrey Ignatov (5):
bpf: Switch btf_parse_vmlinux to btf_find_by_name_kind
bpf: Rename bpf_htab to bpf_shtab in sock_map
bpf: Support access to bpf map fields
bpf: Set map_btf_{name,id} for all map types
selftests/bpf: Test access to bpf map pointer
include/linux/bpf.h | 9 +
include/linux/bpf_verifier.h | 1 +
kernel/bpf/arraymap.c | 18 +
kernel/bpf/bpf_struct_ops.c | 3 +
kernel/bpf/btf.c | 63 +-
kernel/bpf/cpumap.c | 3 +
kernel/bpf/devmap.c | 6 +
kernel/bpf/hashtab.c | 15 +
kernel/bpf/local_storage.c | 3 +
kernel/bpf/lpm_trie.c | 3 +
kernel/bpf/queue_stack_maps.c | 6 +
kernel/bpf/reuseport_array.c | 3 +
kernel/bpf/ringbuf.c | 3 +
kernel/bpf/stackmap.c | 3 +
kernel/bpf/verifier.c | 82 ++-
net/core/bpf_sk_storage.c | 3 +
net/core/sock_map.c | 88 +--
net/xdp/xskmap.c | 3 +
.../selftests/bpf/prog_tests/map_ptr.c | 32 +
.../selftests/bpf/progs/map_ptr_kern.c | 686 ++++++++++++++++++
.../testing/selftests/bpf/verifier/map_ptr.c | 62 ++
.../selftests/bpf/verifier/map_ptr_mixing.c | 2 +-
22 files changed, 1030 insertions(+), 67 deletions(-)
create mode 100644 tools/testing/selftests/bpf/prog_tests/map_ptr.c
create mode 100644 tools/testing/selftests/bpf/progs/map_ptr_kern.c
create mode 100644 tools/testing/selftests/bpf/verifier/map_ptr.c
--
2.24.1
next reply other threads:[~2020-06-19 21:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 21:11 Andrey Ignatov [this message]
2020-06-19 21:11 ` [PATCH v2 bpf-next 1/5] bpf: Switch btf_parse_vmlinux to btf_find_by_name_kind Andrey Ignatov
2020-06-20 6:04 ` John Fastabend
2020-06-19 21:11 ` [PATCH v2 bpf-next 2/5] bpf: Rename bpf_htab to bpf_shtab in sock_map Andrey Ignatov
2020-06-20 6:08 ` John Fastabend
2020-06-19 21:11 ` [PATCH v2 bpf-next 3/5] bpf: Support access to bpf map fields Andrey Ignatov
2020-06-21 3:27 ` John Fastabend
2020-06-22 18:39 ` Andrey Ignatov
2020-06-22 22:11 ` Alexei Starovoitov
2020-06-19 21:11 ` [PATCH v2 bpf-next 4/5] bpf: Set map_btf_{name,id} for all map types Andrey Ignatov
2020-06-21 3:28 ` John Fastabend
2020-06-19 21:11 ` [PATCH v2 bpf-next 5/5] selftests/bpf: Test access to bpf map pointer Andrey Ignatov
2020-06-21 3:35 ` John Fastabend
2020-06-22 17:42 ` [PATCH v2 bpf-next 0/5] bpf: Support access to bpf map fields Martin KaFai Lau
2020-06-22 21:22 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1592600985.git.rdna@fb.com \
--to=rdna@fb.com \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox