From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 917BD12A146 for ; Wed, 31 Jan 2024 16:24:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706718266; cv=none; b=VKR3TRN5llv6YnrMX2cA2baf9vjLl68Rrkhp2Pr3FoSs0m/nev8IRvkmJCUEMkcI4Y8v5hEtcB/dlo54Up0cxuFXG3x1eLpPKS+hMK/uMouCPCkmB6sgAROBQXBTb8dn6kHb1tXAQf1+ykpoOy7Dt+kXUxPjsKj0I9oEptSi/bY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706718266; c=relaxed/simple; bh=QzdaSYBYj0oQdaxeovKmznN0l6Hxa30hq/qfARLKbjE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=IqwE9ev9ZLoBnsmUgKJfA1yFxdEuRcLVDS/Z5GiHA4ABNHSIM9e67sOfg1KBJpPO/ScRiEv+bKK1NZSNVkPEeNJd+hJFTBqZSauWpaVK8h05xub1phbzag/rwT/TtBgq+EuMjIPOuiI00G/UbTAYgyJ/WOlM57UcxQlgzg50HRQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=guXVxxei; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="guXVxxei" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706718263; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=QAwtJgTN3R29PiPjMA36yhtoCDNAU3HdwxP0TJVB7ls=; b=guXVxxeiZD+N/ZOcA/UrveP5RMis6ladAaxr2pbQ42pMPJS4HZzA/Y/V03xiyKbUh7AlNz e3HYAiwhvGwYaV4JzO5mC7iLFX40uUBNqV+B8X8yjfgcE5Y7daLWPQSafPO8LLh0KiUQqH i0dpav6xhOe7bibs0/csphitwNY6hfY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-12-c0ar0QIcOVSBoGnssidVBA-1; Wed, 31 Jan 2024 11:24:17 -0500 X-MC-Unique: c0ar0QIcOVSBoGnssidVBA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C4B8885A5A3; Wed, 31 Jan 2024 16:24:16 +0000 (UTC) Received: from dhcpf210.fit.vutbr.com (unknown [10.45.224.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 978CE1C060AF; Wed, 31 Jan 2024 16:24:13 +0000 (UTC) From: Viktor Malik To: bpf@vger.kernel.org Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Viktor Malik , Andrew Morton , Alexey Dobriyan , Kumar Kartikeya Dwivedi Subject: [PATCH bpf-next v2 0/2] tools/resolve_btfids: fix cross-compilation to non-host endianness Date: Wed, 31 Jan 2024 17:24:07 +0100 Message-ID: Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 The .BTF_ids section is pre-filled with zeroed BTF ID entries during the build and afterwards patched by resolve_btfids with correct values. Since resolve_btfids always writes in host-native endianness, it relies on libelf to do the translation when the target ELF is cross-compiled to a different endianness (this was introduced in commit 61e8aeda9398 ("bpf: Fix libelf endian handling in resolv_btfids")). Unfortunately, the translation will corrupt the flags fields of SET8 entries because these were written during vmlinux compilation and are in the correct endianness already. This will lead to numerous selftests failures such as: $ sudo ./test_verifier 502 502 #502/p sleepable fentry accept FAIL Failed to load prog 'Invalid argument'! bpf_fentry_test1 is not sleepable verification time 34 usec stack depth 0 processed 0 insns (limit 1000000) max_states_per_insn 0 total_states 0 peak_states 0 mark_read 0 Summary: 0 PASSED, 0 SKIPPED, 1 FAILED Since it's not possible to instruct libelf to translate just certain values, let's manually bswap the flags in resolve_btfids when needed, so that libelf then translates everything correctly. The first patch of the series refactors resolve_btfids by using types from btf_ids.h instead of accessing the BTF ID data using magic offsets. Viktor Malik (2): tools/resolve_btfids: Refactor set sorting with types from btf_ids.h tools/resolve_btfids: fix cross-compilation to non-host endianness tools/bpf/resolve_btfids/main.c | 55 ++++++++++++++++++++++++++++----- tools/include/linux/btf_ids.h | 9 ++++++ 2 files changed, 56 insertions(+), 8 deletions(-) -- 2.43.0