From: Paul Chaignon <paul.chaignon@gmail.com>
To: bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Eduard Zingerman <eddyz87@gmail.com>,
Amery Hung <ameryhung@gmail.com>,
Martin KaFai Lau <martin.lau@linux.dev>
Subject: [PATCH bpf-next v4 0/5] Support non-linear skbs for BPF_PROG_TEST_RUN
Date: Wed, 1 Oct 2025 23:27:14 +0200 [thread overview]
Message-ID: <cover.1759341538.git.paul.chaignon@gmail.com> (raw)
This patchset adds support for non-linear skbs when running tc programs
with BPF_PROG_TEST_RUN.
We've had multiple bugs in the past few years in Cilium caused by
missing calls to bpf_skb_pull_data(). Daniel suggested this new
BPF_PROG_TEST_RUN flag as a way to uncover these bugs in our BPF tests.
Changes in v4:
- Per Martin's suggestion, follow the XDP code pattern and use
bpf_test_init only to initialize the linear area. That way data is
directly copied to the right areas and we avoid the call to
__pskb_pull_tail.
- Fixed outdated commit descriptions.
- Rebased.
Changes in v3:
- Dropped BPF_F_TEST_SKB_NON_LINEAR and used the ctx->data_end to
determine if the user wants non-linear skb, as suggested by Amery.
- Introduced a second commit with a bit of refactoring to allow for
the above requested change.
- Fix bug found by syzkaller on third commit.
- Rebased.
Changes in v2:
- Made the linear size configurable via ctx->data_end, as suggested
by Amery.
- Reworked the selftests to allow testing the configurable linear
size.
- Fix warnings reported by kernel test robot on first commit.
- Rebased.
Paul Chaignon (5):
bpf: Refactor cleanup of bpf_prog_test_run_skb
bpf: Reorder bpf_prog_test_run_skb initialization
bpf: Craft non-linear skbs in BPF_PROG_TEST_RUN
selftests/bpf: Support non-linear flag in test loader
selftests/bpf: Test direct packet access on non-linear skbs
net/bpf/test_run.c | 105 +++++++++++++-----
tools/testing/selftests/bpf/progs/bpf_misc.h | 4 +
.../bpf/progs/verifier_direct_packet_access.c | 54 +++++++++
tools/testing/selftests/bpf/test_loader.c | 19 +++-
4 files changed, 155 insertions(+), 27 deletions(-)
--
2.43.0
next reply other threads:[~2025-10-01 21:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 21:27 Paul Chaignon [this message]
2025-10-01 21:28 ` [PATCH bpf-next v4 1/5] bpf: Refactor cleanup of bpf_prog_test_run_skb Paul Chaignon
2025-10-01 21:29 ` [PATCH bpf-next v4 2/5] bpf: Reorder bpf_prog_test_run_skb initialization Paul Chaignon
2025-10-01 21:30 ` [PATCH bpf-next v4 3/5] bpf: Craft non-linear skbs in BPF_PROG_TEST_RUN Paul Chaignon
2025-10-01 21:31 ` [PATCH bpf-next v4 4/5] selftests/bpf: Support non-linear flag in test loader Paul Chaignon
2025-10-01 21:31 ` [PATCH bpf-next v4 5/5] selftests/bpf: Test direct packet access on non-linear skbs Paul Chaignon
2025-10-02 6:48 ` [syzbot ci] Re: Support non-linear skbs for BPF_PROG_TEST_RUN syzbot ci
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1759341538.git.paul.chaignon@gmail.com \
--to=paul.chaignon@gmail.com \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=martin.lau@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox