From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta0.migadu.com (out-178.mta0.migadu.com [91.218.175.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1C2F2C864 for ; Thu, 4 Jan 2024 22:38:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="DwNklJpg" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1704407924; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EkMtO7OMGDyg6R+09zztV2BVqicry/aYqL1e7xDWm5M=; b=DwNklJpgVLb683Mtt6WklAiXzFklJjmyJEy/q+Qlx7upKWQsx+a58ljH3pGQgW/eOUxxHM qFNCcguN3Eg+o6KHwej/osmNDFNgvr+OzQ/f3XRNVCUxYH8ejov8GneamF4k1fqe1r3ICE uWO07P/otTwg6CrPfxMKFgjy3A+MjnA= Date: Thu, 4 Jan 2024 14:38:39 -0800 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf 2/3] selftests/bpf: Double the size of test_loader log Content-Language: en-GB To: Alexei Starovoitov Cc: Ilya Leoshkevich , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , bpf , Heiko Carstens , Vasily Gorbik , Alexander Gordeev References: <20240102193531.3169422-1-iii@linux.ibm.com> <20240102193531.3169422-3-iii@linux.ibm.com> <6f05eb0d-4807-4eef-99ba-2bfa9bd334af@linux.dev> <958781f9b02cb1d5ef82a0d78d65ecdbb3f26893.camel@linux.ibm.com> <3ac01843-9dbf-4c5b-a1ac-9acda8c47f19@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 1/4/24 2:33 PM, Alexei Starovoitov wrote: > On Thu, Jan 4, 2024 at 1:19 PM Alexei Starovoitov > wrote: >> On Wed, Jan 3, 2024 at 10:15 AM Yonghong Song wrote: >>> >>> Okay, thanks for the explanation. I applied the patch set to >>> my local env and indeed, with this patch, I can see libbpf returns >>> an error. >> How did you repro this? >> I've tried reverting this patch, but the test in patch 3 still passes >> for me without errors. > Took me a long time... I was able to repro with: > > diff --git a/tools/testing/selftests/bpf/progs/verifier_gotol.c > b/tools/testing/selftests/bpf/progs/verifier_gotol.c > index 05a329ee45ee..66bdb940a40b 100644 > --- a/tools/testing/selftests/bpf/progs/verifier_gotol.c > +++ b/tools/testing/selftests/bpf/progs/verifier_gotol.c > @@ -36,6 +36,7 @@ l3_%=: > \ > SEC("socket") > __description("gotol, large_imm") > __success __failure_unpriv __retval(40000) > +__log_level(1) > __naked void gotol_large_imm(void) > > and then I finally realized that this patch is fixing > the case when test_progs runs with -v. Like: > ./test_progs -t gotol -v Sorry for replying later. Just taking a nap... I reproduced the issue when I tried to find out why unpriv failed with cpuv4 as I cannot remember why. IIRC, I am using is ./test_progs-cpuv4 -v -t gotol > > I wish you mentioned this in the commit log. > Would have saved me a ton of time.