From: Yonghong Song <yhs@fb.com>
To: Daniel Borkmann <daniel@iogearbox.net>, <bpf@vger.kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>, <kernel-team@fb.com>
Subject: Re: [PATCH bpf-next 2/2] selftests/bpf: add a dedup selftest with equivalent structure types
Date: Tue, 16 Nov 2021 08:19:56 -0800 [thread overview]
Message-ID: <d3bcbdea-9e45-1a36-c5a2-29ff0bca2264@fb.com> (raw)
In-Reply-To: <d7ce592f-9dcd-3bde-7f61-12d46e352dca@iogearbox.net>
On 11/16/21 4:27 AM, Daniel Borkmann wrote:
> On 11/15/21 5:39 PM, Yonghong Song wrote:
>> Without previous libbpf patch, the following error will occur:
>> $ ./test_progs -t btf
>> ...
>> do_test_dedup:FAIL:check btf_dedup failed errno:-22#13/205
>> btf/dedup: btf_type_tag #5, struct:FAIL
>>
>> And the previfous libbpf patch fixed the issue.
>
> Fixed up the typo above while applying and also formatted the 1/2 a bit
> better.
> checkpatch usually has a lot of noise in its output, but it would catch
> things
> like typos when quickly running before submission, fwiw. Anyway, thanks!
Thanks for the fixup! I need to remember to run checkpatch even for
small patches!
next prev parent reply other threads:[~2021-11-16 16:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 16:39 [PATCH bpf-next 0/2] bpf: fix a couple of missed btf_type_tag handling in libbpf Yonghong Song
2021-11-15 16:39 ` [PATCH bpf-next 1/2] libbpf: fix a couple of missed btf_type_tag handling in btf.c Yonghong Song
2021-11-15 16:39 ` [PATCH bpf-next 2/2] selftests/bpf: add a dedup selftest with equivalent structure types Yonghong Song
2021-11-16 12:27 ` Daniel Borkmann
2021-11-16 16:19 ` Yonghong Song [this message]
2021-11-16 12:20 ` [PATCH bpf-next 0/2] bpf: fix a couple of missed btf_type_tag handling in libbpf patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3bcbdea-9e45-1a36-c5a2-29ff0bca2264@fb.com \
--to=yhs@fb.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox